On Wed, 14 Oct 2020 01:52:35 GMT, Sergey Bylokhov wrote:
>> Tejpal Rebari has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> changed mode of files
>
> Changes requested by serb (Reviewer).
@mrserb please take a look.
-
PR: ht
On Tue, 15 Dec 2020 17:14:11 GMT, Andrey Turbanov
wrote:
>>> I've added few words in description.
>>>
>>> About testing: as I can see testing is done via Github Actions. tier1
>>> builds are ok.
>>
>> OK that's better But about testing. The github actions won't run a single
>> test that touc
On Mon, 14 Dec 2020 04:55:02 GMT, Prasanta Sadhukhan
wrote:
> The forumpost is here https://discussions.apple.com/thread/252067605
> The hardcoded being referred was in this 1st iteration of the fix
> https://openjdk.github.io/cr/?repo=jdk&pr=1182&range=00
OK. So I guess this could work for eit
On Thu, 19 Nov 2020 03:37:16 GMT, Prasanta Sadhukhan
wrote:
>> On macOS 11 (bigsur) beta, using the Swing Aqua Look and Feel, the text of
>> the selected JTabbedPane tab title text is just a light gray outline of
>> white text on a white background. The macOS 11 design inverted from dark
>> b
On Tue, 15 Dec 2020 09:46:49 GMT, Prasanta Sadhukhan
wrote:
> Test was failing if JComboBox tests was run in group in nightly mach5 testing.
> Modified test to move frame to centre of screen, add delays before frame
> show. Also updated the test that ran just before this test move frame to
> c
On Mon, 14 Dec 2020 20:04:05 GMT, Phil Race wrote:
>> I've added few words in description.
>>
>> About testing: as I can see testing is done via Github Actions. tier1 builds
>> are ok.
>
>> I've added few words in description.
>>
>> About testing: as I can see testing is done via Github Action
> There are few places in code where manual `while` loop is used with
> `Iterator` to iterate over `Collection`.
> Instead of manual `while` cycles it's preferred to use _enhanced-for_ cycle
> instead: it's less verbose, makes code easier to read and it's less
> error-prone.
> It doesn't have an
Test was failing if JComboBox tests was run in group in nightly mach5 testing.
Modified test to move frame to centre of screen, add delays before frame show.
Also updated the test that ran just before this test move frame to center of
screen.
Resultant modified test ran fine in JComboBox group an