Re: RFR: 8263136: C4530 was reported from VS 2019 at access bridge [v2]

2021-03-12 Thread Yasumasa Suenaga
On Sat, 13 Mar 2021 01:57:53 GMT, Sergey Bylokhov wrote: >> This change looks fine, I was able to see the proper logs in the >> java_access_bridge.log, but I cannot find the logs from the >> windows_access_bridge.log. It seems unrelated to this fix. @pankaj-bansal >> please take a look at why

Re: RFR: 8263136: C4530 was reported from VS 2019 at access bridge [v2]

2021-03-12 Thread Sergey Bylokhov
On Wed, 10 Mar 2021 01:40:39 GMT, Sergey Bylokhov wrote: >> No, can you help? > > I'll check. This change looks fine, I was able to see the proper logs in the java_access_bridge.log, but I cannot find the logs from the windows_access_bridge.log. It seems unrelated to this fix. @pankaj-bansal

Re: RFR: 8263136: C4530 was reported from VS 2019 at access bridge [v2]

2021-03-12 Thread Sergey Bylokhov
On Sat, 13 Mar 2021 01:56:06 GMT, Sergey Bylokhov wrote: >> I'll check. > > This change looks fine, I was able to see the proper logs in the > java_access_bridge.log, but I cannot find the logs from the > windows_access_bridge.log. It seems unrelated to this fix. @pankaj-bansal > please take a

Re: RFR: 8263136: C4530 was reported from VS 2019 at access bridge [v2]

2021-03-12 Thread Sergey Bylokhov
On Mon, 8 Mar 2021 00:56:24 GMT, Yasumasa Suenaga wrote: >> I saw C4530 with VS 2019 (16.9.0) as following (on Japanese locale): >> >> AccessBridgeDebug.cpp >> メモ: インクルード ファイル: >> d:\github-forked\jdk\src\jdk.accessibility\windows\native\common\AccessBridgeDebug.h >> >> : >> >> c:\progra~

Re: RFR: 8189198: Add "forRemoval = true" to Applet API deprecations

2021-03-12 Thread Alexander Matveev
On Wed, 10 Mar 2021 18:33:37 GMT, Andy Herrick wrote: > implementation of > JDK-8256145: JEP 398: Deprecate the Applet API for Removal Marked as reviewed by almatvee (Committer). - PR: https://git.openjdk.java.net/jdk/pull/2920

Re: RFR: 8263472: Specification of JComponent::updateUI doesn't mention that the original implementaiton does nothing

2021-03-12 Thread Sergey Bylokhov
On Fri, 12 Mar 2021 04:33:43 GMT, Prasanta Sadhukhan wrote: > It's unclear from the spec that the original implementation of the method > JComponent.updateUI() does nothing which needs to be explicitly stated in the > javadoc. Do we really want to specify this as a noop method? In this case,

Re: RFR: 8263472: Specification of JComponent::updateUI doesn't mention that the original implementaiton does nothing

2021-03-12 Thread Alexey Ivanov
On Fri, 12 Mar 2021 04:33:43 GMT, Prasanta Sadhukhan wrote: > It's unclear from the spec that the original implementation of the method > JComponent.updateUI() does nothing which needs to be explicitly stated in the > javadoc. src/java.desktop/share/classes/javax/swing/JComponent.java line 66

Re: RFR: 8189198: Add "forRemoval = true" to Applet API deprecations

2021-03-12 Thread Iris Clark
On Wed, 10 Mar 2021 18:33:37 GMT, Andy Herrick wrote: > implementation of > JDK-8256145: JEP 398: Deprecate the Applet API for Removal Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2920

RFR: 8189198: Add "forRemoval = true" to Applet API deprecations

2021-03-12 Thread Andy Herrick
implementation of JDK-8256145: JEP 398: Deprecate the Applet API for Removal - Commit messages: - 8189198: Add "forRemoval = true" to Applet API deprecations Changes: https://git.openjdk.java.net/jdk/pull/2920/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2920&range=0

Re: RFR: JDK-8263235 : sanity/client/SwingSet/src/ColorChooserDemoTest.java failed throwing java.lang.NoClassDefFoundError [v2]

2021-03-12 Thread Amresh Sahu
> Added @build org.jemmy2ext.JemmyExt. Amresh Sahu has updated the pull request incrementally with one additional commit since the last revision: JDK-8263235:Added @build org.jemmy2ext.JemmyExt - Changes: - all: https://git.openjdk.java.net/jdk/pull/2958/files - new: https://

Re: RFR: JDK-8263235 : sanity/client/SwingSet/src/ColorChooserDemoTest.java failed throwing java.lang.NoClassDefFoundError

2021-03-12 Thread Prasanta Sadhukhan
On Fri, 12 Mar 2021 05:29:01 GMT, Amresh Sahu wrote: > Added @build org.jemmy2ext.JemmyExt. test/jdk/sanity/client/SwingSet/src/ColorChooserDemoTest.java line 66: > 64: * java.logging > 65: * @build org.jemmy2ext.JemmyExt > 66: * @build com.sun.swingset3.demos.colorchooser.ColorChoose