RFR: 8263768: JFormattedTextField.AbstractFormatter.getDocumentFilter()/getNavigationFilter() spec doesn't mention what the default impls return and what does it mean

2021-03-17 Thread Prasanta Sadhukhan
Default implementation of JFormattedTextField.AbstractFormatter.getDocumentFilter()/getNavigationFilter() returns null but it is not mentioned in the spec. It is now explicitly mentioned in the spec by @impNote tag. - Commit messages: - 8263768: JFormattedTextField.AbstractFormatt

Re: RFR: 8189198: Add "forRemoval = true" to Applet API deprecations

2021-03-17 Thread Andy Herrick
On Wed, 17 Mar 2021 19:02:39 GMT, Alan Bateman wrote: > > > > I cannot find any instances where the scope can be narrowed > > Are you about AquaInternalFrameUI.mouseRelased, BasicPopupMenuUI. > stateChanged, and other non-trivial methods? These have the code pattern such as: } else if (c in

Re: RFR: 8189198: Add "forRemoval = true" to Applet API deprecations

2021-03-17 Thread Alan Bateman
On Wed, 17 Mar 2021 16:44:19 GMT, Andy Herrick wrote: > I cannot find any instances where the scope can be narrowed Are you about AquaInternalFrameUI.mouseRelased, BasicPopupMenuUI. stateChanged, and other non-trivial methods? - PR: https://git.openjdk.java.net/jdk/pull/2920

Re: RFR: 8189198: Add "forRemoval = true" to Applet API deprecations

2021-03-17 Thread Andy Herrick
On Sun, 14 Mar 2021 12:06:08 GMT, Alan Bateman wrote: > > > Have you looked at narrowing the use of the SuppressWarnings to local > variable declarations to avoid adding it to some of these methods? in all cases either: - the class or method itself is being deprecated - the method takes a d

Re: RFR: 8189198: Add "forRemoval = true" to Applet API deprecations

2021-03-17 Thread Andy Herrick
On Sun, 14 Mar 2021 12:06:08 GMT, Alan Bateman wrote: > the - PR: https://git.openjdk.java.net/jdk/pull/2920

Withdrawn: 8189198: Add "forRemoval = true" to Applet API deprecations

2021-03-17 Thread Andy Herrick
On Wed, 10 Mar 2021 18:33:37 GMT, Andy Herrick wrote: > implementation of > JDK-8256145: JEP 398: Deprecate the Applet API for Removal This pull request has been closed without being integrated. - PR: https://git.openjdk.java.net/jdk/pull/2920

Re: RFR: 8263481: Specification of JComponent::setDefaultLocale doesn't mention that passing 'null' restores VM's default locale [v2]

2021-03-17 Thread Prasanta Sadhukhan
> The current state of specification for > https://docs.oracle.com/en/java/javase/15/docs/api/java.desktop/javax/swing/JComponent.html#setDefaultLocale(java.util.Locale) > doesn't mention anything about passing 'null' as a new default locale. > > In fact for OpenJDK implementation passing 'null' r

Integrated: 8263410: ListModel javadoc refers to non-existent interface

2021-03-17 Thread Prasanta Sadhukhan
On Thu, 11 Mar 2021 04:32:18 GMT, Prasanta Sadhukhan wrote: > ListModel class javadoc refers to ListDataModel interface but there is no > ListDataModel interface. Rectified the anomaly. This pull request has now been integrated. Changeset: ec95a5c6 Author:Prasanta Sadhukhan URL: ht