Re: RFR JDK-8172804: SwingSet Automation: Jemmy Library : FrameOperator: maximize() and demaximize() are not properly implemented

2017-02-15 Thread Alexander Kouznetsov
Looks good to me. Best regards, Alexander Kouznetsov On 1/16/2017 5:39 AM, Muneer Kolarkunnu wrote: Hi All, Please review the following: Bug : https://bugs.openjdk.java.net/browse/JDK-8172804 Webrev Link: http://cr.openjdk.java.net/~akolarkunnu/8172804/webrev.00/ <h

Re: Review Request for JDK-8174161

2017-02-15 Thread Alexander Kouznetsov
Looks good to me. Best regards, Alexander Kouznetsov On 2/13/2017 10:09 PM, Vikrant Agarwal wrote: Hi Sergey, Thanks, I have removed JemmyExt from the new webrev: http://cr.openjdk.java.net/~vagarwal/8174161/webrev_2/ <http://cr.openjdk.java.net/%7Evagarwal/8174161/webrev_2/>

Re: Review Request for JDK-8172500

2017-01-12 Thread Alexander Kouznetsov
Looks good to me. Best regards, Alexander Kouznetsov (408) 276-0387 On 1/12/2017 12:26 AM, Vikrant Agarwal wrote: Hi All, Please review the following: Bug : https://bugs.openjdk.java.net/browse/JDK-8172500 Webrev Link: http://cr.openjdk.java.net/~vagarwal/8172500/webrev_01/ <h

Re: Review request for JDK-8172489

2017-01-12 Thread Alexander Kouznetsov
Looks good to me. Phil, could you please review? Best regards, Alexander Kouznetsov (408) 276-0387 On 1/12/2017 12:43 AM, Vikrant Agarwal wrote: Hi All, Please review the following: *Bug :* https://bugs.openjdk.java.net/browse/JDK-8172489 *Webrev Link:* http://cr.openjdk.java.net

Re: RFR 8157339: Further stabilization for the SwingSet client sanity tests.

2016-05-24 Thread Alexander Kouznetsov
Hi Sergey, I'm wondering how strict this rule is. I'm ready to push it to jdk-dev but will leave it to you if it must go through the client. Best regards, Alexander Kouznetsov (408) 276-0387 On 5/24/2016 9:15 AM, Sergey Bylokhov wrote: usually all client related fixes goes to the

Re: RFR 8157339: Further stabilization for the SwingSet client sanity tests.

2016-05-23 Thread Alexander Kouznetsov
Looks good to me. Phil, Sergey, would you be able to promote me to a reviewer? I can review changes to these tests and demos. Thank you! Best regards, Alexander Kouznetsov (408) 276-0387 On 5/23/2016 11:52 AM, Alexandre (Shura) Iline wrote: Sergey, Phil, could any of you take a look or

Re: RFR 8157339: Further stabilization for the SwingSet client sanity tests.

2016-05-20 Thread Alexander Kouznetsov
tate without writing many lines of code. Something like: waitState("All nodes to be expanded in the tree", () -> tree.getRowCount() == NODES_TOTAL); That would allow to eliminate several methods like waitRowCount() above. Best regards, Alexander Kouznetsov (40

hg: jdk8/swing/jdk: 7074853: TransparentRuler demos Readme should mention the correct jar file name

2011-10-06 Thread alexander . kouznetsov
Changeset: 2409cb55b545 Author:mrkam Date: 2011-10-06 11:32 -0700 URL: http://hg.openjdk.java.net/jdk8/swing/jdk/rev/2409cb55b545 7074853: TransparentRuler demos Readme should mention the correct jar file name Reviewed-by: rupashka ! src/share/demo/jfc/TransparentRuler/README.txt

hg: jdk7/swing/jdk: 2 new changesets

2011-03-31 Thread alexander . kouznetsov
Changeset: 3ced4a33c831 Author:mrkam Date: 2011-03-31 10:15 -0700 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/3ced4a33c831 7027700: /jfc/SwingApplet demo needs to be improved Reviewed-by: alexp ! src/share/demo/jfc/SwingApplet/SwingApplet.java Changeset: f007fa22625d Author

hg: jdk7/swing/jdk: 7027693: /jfc/CodePointIM demo needs to be improved

2011-03-30 Thread alexander . kouznetsov
Changeset: f29110bbcaa2 Author:mrkam Date: 2011-03-30 15:52 -0700 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/f29110bbcaa2 7027693: /jfc/CodePointIM demo needs to be improved Reviewed-by: alexp ! src/share/demo/jfc/CodePointIM/CodePointIM.java ! src/share/demo/jfc/CodePointI

hg: jdk7/swing/jdk: 7027682: /applets/Fractal demo needs to be improved

2011-03-30 Thread alexander . kouznetsov
Changeset: 7e4ce6c1e58b Author:mrkam Date: 2011-03-30 08:58 -0700 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/7e4ce6c1e58b 7027682: /applets/Fractal demo needs to be improved Reviewed-by: alexp ! src/share/demo/applets/Fractal/CLSFractal.java ! src/share/demo/applets/Fractal

hg: jdk7/swing/jdk: 7027701: /jfc/TableExample demo needs to be improved

2011-03-30 Thread alexander . kouznetsov
Changeset: 10f3161ff33f Author:mrkam Date: 2011-03-30 08:58 -0700 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/10f3161ff33f 7027701: /jfc/TableExample demo needs to be improved Reviewed-by: alexp ! src/share/demo/jfc/TableExample/JDBCAdapter.java ! src/share/demo/jfc/TableExa

hg: jdk7/swing/jdk: 7027690: /applets/SpreadSheet demo needs to be improved

2011-03-30 Thread alexander . kouznetsov
Changeset: 08bd29e16159 Author:mrkam Date: 2011-03-30 08:54 -0700 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/08bd29e16159 7027690: /applets/SpreadSheet demo needs to be improved Reviewed-by: alexp ! src/share/demo/applets/SpreadSheet/SpreadSheet.java

hg: jdk7/swing/jdk: 7027687: /applets/NervousText demo needs to be improved

2011-03-30 Thread alexander . kouznetsov
Changeset: bdd09379168e Author:mrkam Date: 2011-03-30 08:52 -0700 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/bdd09379168e 7027687: /applets/NervousText demo needs to be improved Reviewed-by: alexp ! src/share/demo/applets/NervousText/NervousText.java

hg: jdk7/swing/jdk: 7027673: /applets/ArcTest demo needs to be improved

2011-03-26 Thread alexander . kouznetsov
Changeset: e72a348f25c9 Author:mrkam Date: 2011-03-25 18:00 +0100 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/e72a348f25c9 7027673: /applets/ArcTest demo needs to be improved Reviewed-by: alexp ! src/share/demo/applets/ArcTest/ArcTest.java

hg: jdk7/swing/jdk: 7027698: /jfc/SampleTree demo needs to be improved

2011-03-26 Thread alexander . kouznetsov
Changeset: 26ff800b75ad Author:mrkam Date: 2011-03-25 13:23 +0100 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/26ff800b75ad 7027698: /jfc/SampleTree demo needs to be improved Reviewed-by: rupashka ! src/share/demo/jfc/SampleTree/DynamicTreeNode.java ! src/share/demo/jfc/Sampl

hg: jdk7/swing/jdk: 7027849: New demo for Shaped/Translucent windows feature needs to be created

2011-03-26 Thread alexander . kouznetsov
Changeset: f293a36f05fe Author:mrkam Date: 2011-03-24 18:54 +0100 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/f293a36f05fe 7027849: New demo for Shaped/Translucent windows feature needs to be created Reviewed-by: rupashka + src/share/demo/jfc/TransparentRuler/README.txt + sr

hg: jdk7/swing/jdk: 7027694: /jfc/FileChooserDemo demo needs to be improved

2011-03-26 Thread alexander . kouznetsov
Changeset: 35fba3254594 Author:mrkam Date: 2011-03-25 13:27 +0100 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/35fba3254594 7027694: /jfc/FileChooserDemo demo needs to be improved Reviewed-by: rupashka ! src/share/demo/jfc/FileChooserDemo/ExampleFileSystemView.java ! src/shar

hg: jdk7/swing/jdk: 7027675: /applets/Blink demo needs to be improved

2011-03-26 Thread alexander . kouznetsov
Changeset: a92ab497d39c Author:mrkam Date: 2011-03-25 17:52 +0100 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/a92ab497d39c 7027675: /applets/Blink demo needs to be improved Reviewed-by: alexp ! src/share/demo/applets/Blink/Blink.java

hg: jdk7/swing/jdk: 7027676: /applets/CardTest demo needs to be improved

2011-03-26 Thread alexander . kouznetsov
Changeset: b52d96e7e125 Author:mrkam Date: 2011-03-24 17:45 +0100 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/b52d96e7e125 7027676: /applets/CardTest demo needs to be improved Reviewed-by: rupashka ! src/share/demo/applets/CardTest/CardTest.java

hg: jdk7/swing/jdk: 7027678: /applets/DitherTest demo needs to be improved

2011-03-26 Thread alexander . kouznetsov
Changeset: 291505740de9 Author:mrkam Date: 2011-03-24 18:13 +0100 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/291505740de9 7027678: /applets/DitherTest demo needs to be improved Reviewed-by: rupashka ! src/share/demo/applets/DitherTest/DitherTest.java

hg: jdk7/swing/jdk: 7027677: /applets/Clock demo needs to be improved

2011-03-26 Thread alexander . kouznetsov
Changeset: 49e67bb5782c Author:mrkam Date: 2011-03-24 18:03 +0100 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/49e67bb5782c 7027677: /applets/Clock demo needs to be improved Reviewed-by: rupashka ! src/share/demo/applets/Clock/Clock.java

hg: jdk7/swing/jdk: 7027686: /applets/MoleculeViewer demo needs to be improved

2011-03-26 Thread alexander . kouznetsov
Changeset: 6b560dd15705 Author:mrkam Date: 2011-03-25 17:56 +0100 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/6b560dd15705 7027686: /applets/MoleculeViewer demo needs to be improved Reviewed-by: alexp ! src/share/demo/applets/MoleculeViewer/Matrix3D.java ! src/share/demo/app

hg: jdk7/swing/jdk: 7027680: /applets/DrawTest demo needs to be improved

2011-03-26 Thread alexander . kouznetsov
Changeset: 3ed1b13ba934 Author:mrkam Date: 2011-03-24 18:20 +0100 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/3ed1b13ba934 7027680: /applets/DrawTest demo needs to be improved Reviewed-by: rupashka ! src/share/demo/applets/DrawTest/DrawTest.java

hg: jdk7/swing/jdk: 7027697: /jfc/Notepad demo needs to be improved

2011-03-26 Thread alexander . kouznetsov
Changeset: 098a8c2e9bd2 Author:mrkam Date: 2011-03-25 13:24 +0100 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/098a8c2e9bd2 7027697: /jfc/Notepad demo needs to be improved Reviewed-by: rupashka ! src/share/demo/jfc/Notepad/ElementTreePanel.java ! src/share/demo/jfc/Notepad/No

hg: jdk7/swing/jdk: 7027689: /applets/SortDemo demo needs to be improved

2011-03-26 Thread alexander . kouznetsov
Changeset: f296a7c17120 Author:mrkam Date: 2011-03-24 18:09 +0100 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/f296a7c17120 7027689: /applets/SortDemo demo needs to be improved Reviewed-by: rupashka ! src/share/demo/applets/SortDemo/BidirBubbleSortAlgorithm.java ! src/share/d

hg: jdk7/swing/jdk: 7030792: /jfc/TransparentRuler needs to be included into build process

2011-03-26 Thread alexander . kouznetsov
Changeset: 5d96d28e8b41 Author:mrkam Date: 2011-03-25 13:17 +0100 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/5d96d28e8b41 7030792: /jfc/TransparentRuler needs to be included into build process Reviewed-by: rupashka, ohair ! make/mkdemo/jfc/Makefile + make/mkdemo/jfc/Transpa

hg: jdk7/swing/jdk: 7027683: /applets/GraphicsTest demo needs to be improved

2011-03-26 Thread alexander . kouznetsov
Changeset: 584dde6ffd1f Author:mrkam Date: 2011-03-25 17:55 +0100 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/584dde6ffd1f 7027683: /applets/GraphicsTest demo needs to be improved Reviewed-by: alexp ! src/share/demo/applets/GraphicsTest/AppletFrame.java ! src/share/demo/appl

hg: jdk7/swing/jdk: 7027674: /applets/BarChart demo needs to be improved

2011-03-26 Thread alexander . kouznetsov
Changeset: 489a9669a344 Author:mrkam Date: 2011-03-25 17:57 +0100 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/489a9669a344 7027674: /applets/BarChart demo needs to be improved Reviewed-by: alexp ! src/share/demo/applets/BarChart/BarChart.java

hg: jdk7/swing/jdk: 7027696: /jfc/Metalworks demo needs to be improved

2011-03-26 Thread alexander . kouznetsov
Changeset: 010dc79258da Author:mrkam Date: 2011-03-24 18:15 +0100 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/010dc79258da 7027696: /jfc/Metalworks demo needs to be improved Reviewed-by: rupashka ! src/share/demo/jfc/Metalworks/AquaMetalTheme.java ! src/share/demo/jfc/Metalw

hg: jdk7/swing/jdk: 7027692: /applets/WireFrame demo needs to be improved

2011-03-26 Thread alexander . kouznetsov
Changeset: db5fea7fbf76 Author:mrkam Date: 2011-03-25 17:59 +0100 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/db5fea7fbf76 7027692: /applets/WireFrame demo needs to be improved Reviewed-by: alexp ! src/share/demo/applets/WireFrame/Matrix3D.java ! src/share/demo/applets/WireF

hg: jdk7/swing/jdk: 7027688: /applets/SimpleGraph demo needs to be improved

2011-03-26 Thread alexander . kouznetsov
Changeset: 98b66b617c31 Author:mrkam Date: 2011-03-24 18:07 +0100 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/98b66b617c31 7027688: /applets/SimpleGraph demo needs to be improved Reviewed-by: rupashka ! src/share/demo/applets/SimpleGraph/GraphApplet.java