Re: [11] Review Request: 8202768 [macos] Appkit thread slows when any Window Manager active

2018-06-09 Thread Anton Tarasov
On 6/8/2018 11:38 PM, Sergey Bylokhov wrote: Hi, Anton. On 08/06/2018 07:57, Anton Tarasov wrote: Is it possible that 'accessibilityAttributeNames' is called not from 'NSAccessibilityUnignoredAncestor'? In that case it will behave differently when the element is ignored.

Re: [11] Review Request: 8202768 [macos] Appkit thread slows when any Window Manager active

2018-06-08 Thread Anton Tarasov
Hi Sergey, Is it possible that 'accessibilityAttributeNames' is called not from 'NSAccessibilityUnignoredAncestor'? In that case it will behave differently when the element is ignored. From the other hand, it's probably useless to return any attribute except 'NSAccessibilityParentAttribute' f

Re: [11] RFR JDK-8189687:Swing: Invalid position of candidate pop-up of InputMethod in Hi-DPI on Windows

2018-04-25 Thread Anton Tarasov
On 4/24/2018 11:55 PM, Sergey Bylokhov wrote: BTW there is a typo: 3888 int sx = ScaleUpX(x) - p.x; 3889 int sy = ScaleUpX(y) - p.y; Thanks for the catch, fixed it. http://cr.openjdk.java.net/~ant/JDK-8202084/webrev.1 Looks fine Thanks. As the fix now has two reviewers it can be pu

Re: [11] RFR JDK-8189687:Swing: Invalid position of candidate pop-up of InputMethod in Hi-DPI on Windows

2018-04-25 Thread Anton Tarasov
On 4/24/2018 11:53 PM, Sergey Bylokhov wrote: On 24/04/2018 13:22, Anton Tarasov wrote: Clarification. The coordinate should not actually be split into displays every time it's scaled up/down. It's enough to calculate its offset in the "terminal" display and scale it ac

Re: [11] RFR JDK-8189687:Swing: Invalid position of candidate pop-up of InputMethod in Hi-DPI on Windows

2018-04-24 Thread Anton Tarasov
On 4/24/2018 9:07 PM, Anton Tarasov wrote: However, there's some serious problem in this construct which you may have noticed. It's here: x = peer->ScaleDownX(rect.left); 'rect.left' may span a number of displays, each with different scale. Thus, to get the real Scal

Re: [11] RFR JDK-8189687:Swing: Invalid position of candidate pop-up of InputMethod in Hi-DPI on Windows

2018-04-24 Thread Anton Tarasov
e variable at the top as some old compiler may give warning and make the build fail. Regards Prasanta On 4/21/2018 12:53 AM, Anton Tarasov wrote: Hi Sergey, Prasanta, I'm sorry to interpose, but I've just submitted a fix for this issue: http://mail.openjdk.java.net/pipermail/awt

Re: [11] RFR JDK-8189687:Swing: Invalid position of candidate pop-up of InputMethod in Hi-DPI on Windows

2018-04-23 Thread Anton Tarasov
47 AM, Prasanta Sadhukhan wrote: Hi Anton, This fix looks okĀ  to me. Probably, you should consider naming the variable at the top as some old compiler may give warning and make the build fail. Regards Prasanta On 4/21/2018 12:53 AM, Anton Tarasov wrote: Hi Sergey, Prasanta, I'm sorry to inte

Re: [11] Review request for 8202084: [win] IME candidate window wrong position

2018-04-20 Thread Anton Tarasov
. -- Kevin [1] http://mail.openjdk.java.net/pipermail/swing-dev/2018-March/008462.html On 4/20/2018 9:28 AM, Anton Tarasov wrote: Hi Kevin, Thanks for pointing (I didn't find it). Closed it as duplicate. Regards, Anton. On 4/20/2018 7:19 PM, Kevin Rushforth wrote: I think the first of

Re: [11] RFR JDK-8189687:Swing: Invalid position of candidate pop-up of InputMethod in Hi-DPI on Windows

2018-04-20 Thread Anton Tarasov
Hi Sergey, Prasanta, I'm sorry to interpose, but I've just submitted a fix for this issue: http://mail.openjdk.java.net/pipermail/awt-dev/2018-April/013891.html As it seems to more relate to AWT not Swing, I submitted it to awt-dev (I didn't notice you discussion here, but thanks to Kevin who p

Re: RfR JDK-8160893 [macosx] JMenuItems in JPopupMenu are not accessible

2016-09-26 Thread Anton Tarasov
Hi Pete, The fix looks fine to me. Thanks, Anton. On 9/24/2016 2:59 AM, Pete Brunet wrote: New webrev: http://cr.openjdk.java.net/~ptbrunet/JDK-8160893/webrev.02/ I added a null check at line 688 like the one at line 693. Pete On 9/23/16 2:46 PM, Pete Brunet wrote: Please review the patch

Re: RfR JDK-8145207 [macosx] JList, VO can't access non-visible list items

2016-07-19 Thread Anton Tarasov
Thanks, Pete! Keeping an eye on JDK-8160893 status as well, as we discussed. Regards, Anton. On 7/18/2016 11:47 PM, Pete Brunet wrote: Anton, If you'd like to check out the changeset I just pushed it. Pete On 7/18/16 3:25 PM, Pete Brunet wrote: JPRT ran OK. On 7/15/16 9:24 AM, Pete Brunet

Re: RfR JDK-8145207 [macosx] JList, VO can't access non-visible list items

2016-06-24 Thread Anton Tarasov
javase/8/docs/api/javax/swing/JList.AccessibleJList.AccessibleJListChild.html> > by adding "implements AccessibleAction" and this will cause a JCK failure. > > Next week I'll see if there is any way I can come up with a different > solution that will allow me to bac

Re: RfR JDK-8145207 [macosx] JList, VO can't access non-visible list items

2016-06-23 Thread Anton Tarasov
thoughts on backporting your OSX a11y fixes into jdk8. As the a11y codebase is quite the same, this seems possible with reasonable time investment. Thank you for the long-awaited fix! ) Anton. > > Pete > > On 6/22/16 4:28 AM, Anton Tarasov wrote: >> Hi Pete, >> >> I

Re: RfR JDK-8145207 [macosx] JList, VO can't access non-visible list items

2016-06-22 Thread Anton Tarasov
Hi Pete, I went through the fix and found it looking fine to me, except for these two minor issues: - JavaComponentAccessibility.m In this chunk: +- (void)postSelectionChanged +{ +NSAccessibilityPostNotification(self, NSAccessibilitySelectedChildrenChangedNotification); +} AWT_ASSERT_APP

Re: [9] Review Request for 6921687: Mnemonic disappears after repeated attempts to open menu items using mnemonics

2015-03-24 Thread Anton Tarasov
Hi Semyon, On 23/03/15 14:48, Semyon Sadetsky wrote: +description When ALT PRESSED event comes for the second time it can be the case to clear menu focus and srokes or the case when ALT+key combination is about to be pressed. The last one was missed in the ALT key handler. I see nothing bad

Re: [OpenJDK 2D-Dev] [9] Review Request: 8074028 Remove API references to java.awt.peer

2015-03-16 Thread Anton Tarasov
Thanks for the check, Kevin! Anton. On 06/03/15 02:13, Kevin Rushforth wrote: I verified that this doesn't break JavaFX Swing interop (specifically Drag and Drop), so it looks fine to me. -- Kevin Sergey Bylokhov wrote: The new version of the fix: http://cr.openjdk.java.net/~serb/8074028/w

Re: [9] Review Request: 8074028 Remove API references to java.awt.peer

2015-03-06 Thread Anton Tarasov
Hi Sergey, Looks good to me. Thanks, Anton. On 04/03/15 15:37, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 9. There are a number of public API whichreference the unsupported java.awt.peer interfaces. public java.awt.Component.getPeer() @deprecated 1.1 public java.awt.Font.ge

Re: [Accessibility]Focus unable to traverse in the menubar

2011-10-14 Thread Anton Tarasov
Hi Neil and Jing, On 10/5/2011 7:38 PM, Pavel Porvatov wrote: Hi Neil and Jing, On Mon, 2011-09-19 at 13:52 +0400, Pavel Porvatov wrote: Hi Jing, I can't agree with you about the problem. According to http://download.oracle.com/javase/tutorial/uiswing/components/menu.html "Menus are unique in

Re: [Accessibility]Focus unable to traverse in the menubar

2011-10-14 Thread Anton Tarasov
Hi Neil, On 10/10/2011 7:01 PM, Neil Richards wrote: On Mon, 2011-10-10 at 16:56 +0400, Anton Tarasov wrote: Hi Neil and Jing, I'm afraid that it's wrong to use ContainerOrderFocusTraversalPolicy for swing components. This policy is designed for AWT. JMenuBar calls setFocusTraversalK