Re: [9] Review fix for JDK-8020039 : SynthTableHeaderUI refers to possibly null parameter in cell renderer

2016-02-19 Thread Miguel Munoz
e/ajit/8020039/webrev.04/  Regards,Ajit   From: Miguel Munoz [mailto:swingguy1...@yahoo.com] Sent: Thursday, February 18, 2016 4:29 PM To: Ajit Ghaisas; Sergey Bylokhov; Rajeev Chamyal; Alexander Scherbatiy; swing-dev@openjdk.java.net Subject: Re: [9] Review fix for JDK-8020039 : SynthTableHead

Re: [9] Review fix for JDK-8020039 : SynthTableHeaderUI refers to possibly null parameter in cell renderer

2016-02-18 Thread Miguel Munoz
It would seem to me that if the table is null, you have a bug in another class. Is there a valid reason for the table to be null? I would guess not. In my experience, many null checks are either unnecessary or only serve to hide bugs. Steve Maguire writes about this in his book Writing Solid Cod

Re: Synth LnF developers?

2009-09-12 Thread Miguel Munoz
ed it, got somebody else, who email me and told me (correctly) that it had already been fixed in the next major release. -- Miguel Munoz --- On Sat, 9/5/09, Matthieu Philip wrote: > From: Matthieu Philip > Subject: Synth LnF developers? > To: swing-dev@openjdk.java.net > Date: Satur

Re: Bug 6499857: JMenuItem.getRootPane() returns null

2007-09-24 Thread Miguel Munoz
Alex, I got this message when I submitted it: Your suggested bug-fix has been assigned an internal review ID of: 1070487 As for the rest of the email, I'm still investigating. However, I've discovered that the JPopupMenu's parent is set to null when I call getRootPane from a JMenuItem, but

Re: Bug 6499857: JMenuItem.getRootPane() returns null

2007-09-21 Thread Miguel Munoz
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6499857 I submitted a fix. The fix works for JMenuItems, but when I look at the documentation, I see that other components may also be added to JMenus, and the fix won't work for them. But after experimenting, I discovered that, if I add a JBut