Hello, Joe.
The fix looks good.
With best regards. Petr.
On 19 авг. 2014 г., at 5:33, Joe Darcy wrote:
> Hello,
>
> Please review my proposed changes to address:
>
>JDK-8055059: JDK9b22 public API exposes package private classes
>http://cr.openjdk.java.net/~darcy/8055059.0/
>
> Bug
Hello, Alexander.
The new version looks good to me.
With best regards. Petr.
> On Nov 24, 2014, at 6:32 PM, Alexander Scherbatiy
> wrote:
>
> On 11/24/2014 12:15 PM, Petr Pchelko wrote:
>> Hello, Alexander.
>>
>> I bet you do not need to remove the
Hello, Alexander.
I bet you do not need to remove the “filter != null” part, because
Object.equals(null, null) is true and the code will be executed.
With best regards. Petr.
> On Nov 21, 2014, at 7:01 PM, Alexander Scherbatiy
> wrote:
>
>
> Hello,
>
> Could you review the fix:
> bug: htt
Hello, Alexander.
The fix looks fine to me.
With best regards. Petr.
> On Nov 21, 2014, at 7:08 PM, Alexander Scherbatiy
> wrote:
>
> On 11/21/2014 5:41 PM, Alexey Ivanov wrote:
>> Hi Alexandr,
>>
>> Although I'm not a reviewer, the fix look good to me.
>>
>> The fix works with JColorChoose
Hello, Yuri.
The fix looks good to me too.
With best regards. Petr.
> On Nov 21, 2014, at 2:34 PM, Alexander Scherbatiy
> wrote:
>
>
> The fix looks good to me.
>
> Thanks,
> Alexandr.
>
> On 11/21/2014 2:26 PM, Yuri Nesterenko wrote:
>> Colleagues,
>>
>> please review yet another modu
The fix looks good.
With best regards. Petr.
On 14 нояб. 2014 г., at 17:59, Anton Nashatyrev
wrote:
> Ops, sorry, copied to wrong dir. Please try again:
>
> http://cr.openjdk.java.net/%7Eanashaty/8059739/9/webrev.01/
>
> On 14.11.2014 16:00, Petr Pchelko wrote:
>> Hel
nton.
>
> On 14.11.2014 15:09, Petr Pchelko wrote:
>> Hello, Anton.
>>
>> To get a charset from the DataFlavor object there is a utility method:
>> DataFlavorUtils.getTextCharset.
>> Could you please reuse this method, it's more precise than a fallback t
Hello, Anton.
To get a charset from the DataFlavor object there is a utility method:
DataFlavorUtils.getTextCharset.
Could you please reuse this method, it's more precise than a fallback to plain
unicode.
With best regards. Petr.
On 14 нояб. 2014 г., at 16:49, Anton Nashatyrev
wrote:
> Hell
Hello, Yuri.
The fix looks good to me.
With best regards. Petr.
On 10 нояб. 2014 г., at 12:31, Yuri Nesterenko
wrote:
> Colleagues,
>
> this is Swing part of the change: a first batch of 35 regression
> tests (or rather 34 tests and a helper) modified
> to eliminate internal references (mos
Vote: YES.
With best regards. Petr.
> On Sep 3, 2014, at 2:37 PM, pavel porvatov wrote:
>
> Vote: yes
>
> On 9/3/2014 2:25 PM, pavel porvatov wrote:
>> I hereby nominate Alexander Scherbatiy to SWING Group Lead [1].
>>
>> Alexander has been working in Swing group for several years and now he
Hello, Alexander.
The fix looks fine.
With best regards. Petr.
On 28 июля 2014 г., at 18:20, Alexander Scherbatiy
wrote:
>
> Hello,
>
> Could you review the fix:
> bug: https://bugs.openjdk.java.net/browse/JDK-6219960
> webrev: http://cr.openjdk.java.net/~alexsch/6219960/webrev.00
>
>
>
Hello, Alexander.
The fix looks good to me.
With best regards. Petr.
> On Jul 22, 2014, at 6:32 PM, Alexander Scherbatiy
> wrote:
>
>
> Hello,
>
> Could you review the fix:
> bug: https://bugs.openjdk.java.net/browse/JDK-8017284
> webrev: http://cr.openjdk.java.net/~alexsch/8017284/webrev
ying the existing tags and instead try to conform to them
> (unless something obvious needs fixing).
> If the formatting you prefer does not match existing tags for the method,
> should I modify the existing tags (in the method or entire file) to conform
> to the new formatting?
>
Hello, Andrei.
The fix looks good to me.
With best regards. Petr.
On 11 июля 2014 г., at 19:12, andrei.eremeev wrote:
> Hi Swing team,
>
> Please, review the fix for the issue:
> https://bugs.openjdk.java.net/browse/JDK-8050009
>
> The fix is available at:
> http://cr.openjdk.java.net/~yan/8
Hello, Andrei.
The fix looks good to me.
With best regards. Petr.
> On Jul 11, 2014, at 4:15 PM, andrei.eremeev wrote:
>
> Hi Swing team,
>
> Please, review the fix for the issue:
> http://cr.openjdk.java.net/~yan/8049870/
>
> The fix is available at:
> https://bugs.openjdk.java.net/browse/J
forced the boxing to avoid this method and go
> directly to setLayer(Integer), line 1254.
>
> JlayeredPane
> Done.
>
> BasicLookAndFeel
> Integer four //fixed
> How was talked 500 is not in cached range.
>
>
> On Fri, Jul 11, 2014 at 6:03 AM, Petr Pchelko wrote
> 500 and 1000L are outside of the range [-127, 128]. Therefore they won't be
> cached.
Agreed, that’s what I didn’t think about.
With best regards. Petr.
> On Jul 11, 2014, at 1:00 PM, Andrej Golovnin
> wrote:
>
> Hi Petr,
>
> BasicLookAndFeel - making “shared Integers” and “shared longs” i
Hello, Otávio.
JInternalFrame:2110 - Why did you add explicit boxing? Is auto boxing not good
enough?
JLayeredPane:299 - layerObj is unnecessary. Please inline it.
BasicLookAndFeel - making “shared Integers” and “shared longs” is pointless
after your fix. Please inline.
With best regards. Petr.
Hello, Alexey.
Looks OK to me too.
With best regards. Petr.
> On Jul 11, 2014, at 1:43 AM, Anthony Petrov wrote:
>
> Hi Alexey,
>
> I skimmed through the changes and they look fine to me. +1.
>
> --
> best regards,
> Anthony
>
> On 7/10/2014 7:59 PM, Alexey Ivanov wrote:
>> Hi AWT, Swing te
s are also copied in the
> LWComponentPeer.createDelegateEvent() and ResizeBox.mouseWheelMoved() methods.
>
> Thanks,
> Alexandr.
>
> On 7/10/2014 6:45 PM, Petr Pchelko wrote:
>> Hello, Alexander.
>>
>> The .01 version looks good.
>>
>> With best
Hello, Alexander.
The .01 version looks good.
With best regards. Petr.
On 10 июля 2014 г., at 18:32, Alexander Scherbatiy
wrote:
>
> Could you review the updated fix:
>http://cr.openjdk.java.net/~alexsch/8049533/webrev.01
>
> The preciseWheelRotation field is copied in the
> LWComponen
Hello, Andrei.
The fix looks good.
With best regards. Petr.
On 10 июля 2014 г., at 17:12, andrei.eremeev wrote:
> Ok.
> http://cr.openjdk.java.net/~yan/8049808/webrev.02/
>
> Andrei
>
> On 07/10/2014 05:05 PM, Petr Pchelko wrote:
>>> Fixed.
>&
>
> Andrei
>
> On 07/10/2014 04:03 PM, Petr Pchelko wrote:
>> Hello, Andrei.
>>
>> BasicBorders:353 - typo, the constructor constructs and not draws.
>> BasicBorders:442 - need an empty line
>> BasicListUI - what the {JList} construct is intended
Hello, Andrei.
BasicBorders:353 - typo, the constructor constructs and not draws.
BasicBorders:442 - need an empty line
BasicListUI - what the {JList} construct is intended to mean? You forgot @code?
BasicListUI:247 - forgot @code
BasicListUI:1621 - same here
BasicMenuItemUI:481 @return what?
Wit
Hello, Rocky.
A couple of comments.
1. Please control the correct indentation of the second line of the
@param/@return tag descriptions. You have many places where it's incorrect.
2. Please use @code instead of
3. AbstractWriter - no need to mention variable names in the javadoc. Please
remove
Hello, Andrei.
Looks fine to me.
With best regards. Petr.
On 10 июля 2014 г., at 11:58, andrei.eremeev wrote:
> Hi Swing team,
>
> Please, review the fix for the issue:
> https://bugs.openjdk.java.net/browse/JDK-8049704
>
> The fix is available at:
> http://cr.openjdk.java.net/~yan/8049704/w
ted webrev is at,
> http://cr.openjdk.java.net/~henryjen/jdk9/8044862/1/webrev/
>
> Cheers,
> Henry
>
>
> On 07/09/2014 01:07 AM, Petr Pchelko wrote:
>> Hello, Henry.
>>
>> AquaComboBoxRendererInternal : why and not just ?
>>
>> AquaComboBox
Hello, Andrei.
The new version looks good.
With best regards. Petr.
On 09 июля 2014 г., at 16:56, andrei.eremeev wrote:
> The second iteration:
> http://cr.openjdk.java.net/~yan/8043968/webrev.01/
>
> Andrei
>
> On 07/09/2014 04:22 PM, Petr Pchelko wrote
h some less detailed description.
>
> I cannot find the overriden method Metal L&F. But what should I write here?
> "Checks an opacity of the {@code AbsractButton}."?
>
> Andrei
>
> On 07/09/2014 04:22 PM, Petr Pchelko wrote:
>> Hello, Andrei.
>>
&
Hello, Andrei.
BasicButtonListener.checkOpacity - I think the doc is to detailed. You
basically write how the method works and it prevents us prom changing it in the
future. Also it's overridden in Metal L&F and it does a different thing there.
Could you please come up with some less detailed d
Hello, Henry.
AquaComboBoxRendererInternal : why and not just ?
AquaComboBoxUI:427, 510, 530 - you can replace JComboBox with
JComboBox and avoid a @SupressWarning annotation.
AquaFileChooserUI.createDirectoryComboBoxRenderer actually returns a
ListCellRenderer,
DirectoryComboBoxModel is a
Hello, Steve.
The fix looks good to me.
With best regards. Petr.
On 09 июля 2014 г., at 4:59, Steve Sides wrote:
> Hello,
>
> Could you please review this 2nd revision of doclint fixes for the following
> bug:
> https://bugs.openjdk.java.net/browse/JDK-8046597 : "fix doclint issues in
> swi
Hello, Alexey.
The new version still looks good.
With best regards. Petr.
> On Jul 4, 2014, at 3:14 PM, Petr Pchelko wrote:
>
> Hello, Alexey.
>
>> Your test does not test the JFileChooser hang, because the bug is
>> reproducible only in plugin mode where TK th
Hello, Anton.
The fix looks good.
With best regards. Petr.
On 04 июля 2014 г., at 17:43, Alexander Scherbatiy
wrote:
>
> The fix looks good to me.
>
> Thanks,
> Alexandr.
>
> On 7/4/2014 5:29 PM, Anton V. Tarasov wrote:
>> Hello,
>>
>> This is a direct [*] backport into jdk8u-dev (8u40
Hello, Anton.
The fix looks good.
With best regards. Petr.
On 04 июля 2014 г., at 17:45, Anton V. Tarasov wrote:
> Hello,
>
> Please, review a fix of the reg test for JDK-8048887, where I put a wrong
> bugid into the @run tag:
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8049346
> webr
so that now it could
deadlock in standalone too.
The fix looks good.
With best regards. Petr.
On 04 июля 2014 г., at 14:28, Petr Pchelko wrote:
> Hello, Alexey.
>
> Your test does not test the JFileChooser hang, because the bug is
> reproducible only in plugin mode where TK thread d
Hello, Alexey.
Your test does not test the JFileChooser hang, because the bug is reproducible
only in plugin mode where TK thread doesn't
have an AppContext and we update the ThemeReader on the Toolkit thread. Your
test runs in standalone mode
where completely different codepath is used. So I s
ould you please file a P4 bug against
swing? We will handle it further. Thank you.
With best regards. Petr.
> On Jul 3, 2014, at 7:22 PM, Joe Darcy wrote:
>
> Hi Petr,
>
> On 07/01/2014 01:51 PM, Petr Pchelko wrote:
>> Hello, Joe.
>>
>>> (Is is correct t
Hello, Steve.
JTextField - wrong formatting of the @return tag
Otherwise the fix looks good, no need for a new webrev, just fix the formatting
before the push.
With best regards. Petr.
On 01 июля 2014 г., at 19:53, Steve Sides wrote:
> Hello,
>
> Could you please review the fix for the foll
responding:
> http://cr.openjdk.java.net/~ssides/8046590/8046590.3/
>
> This addresses missing @parm and @return block tags in javadoc for
> javax/swing classes as noted by doclint and some reformatting.
>
> thanks,
>
> -steve
>
>
> On 6/20/2014 10:03 PM, Steve Sides wrot
gh.
> The changes in javax.swing.tree and javax.swing.undo are new in this request.
I’ve looked at these too, no new comments about them.
Thank you.
With best regards. Petr.
> On Jul 1, 2014, at 8:22 PM, Joe Darcy wrote:
>
> Hi Petr,
>
> On 07/01/2014 01:17 AM, Petr Pchelko wrot
Hello, Joe.
It's hard to understand what to review and what not to review. Could you please
generate a separate webrev for the changes that needs to be reviewed next time?
I've looked only to the javax.swing package, so I'm not sure I've reviewed
everything that needed to be reviewed.
1. JCombo
>
> If you do not mind, I would like to stay the anonymous inner class as is to
> avoid test's modification during backport, since jdk7 does not support lambda.
>
> Thanks,
> Dmitry
> On 30/06/2014 12:23, Petr Pchelko wrote:
>> Hello, Dmitry.
>>
>> W
Hello, Dmitry.
Why are you making the test mac-specific? Why should it fail on other platforms?
Could you please replace the anonymous inner class with a method reference in
the test.
With best regards. Petr.
On 30 июня 2014 г., at 11:19, dmitry markov wrote:
> Hello,
>
> Could you review th
Hello, Peter.
Looks good to me.
With best regards. Petr.
> On Jun 26, 2014, at 1:18 AM, Pete Brunet wrote:
>
> Hi Swing team,
>
> Please review a change to javax.accessibility to fix the rawtype and
> unchecked lint warnings for that package.
>
> Bug: https://bugs.openjdk.java.net/browse/JD
Hello, Steve.
The fix looks good, just one comment:
CellRendererPane:126, 130, 131, 184, 188, 189 - you've missed "to"
No need to generate a new webrev for this change.
With best regards. Petr.
On 23 июня 2014 г., at 20:55, Steve Sides wrote:
> Hello,
>
> Could you please review the fix for
Hello, Joe.
Sorry for the delay. A couple of small comments:
BasicOptionPaneUI:1235 - is the the SuppressWarning needed here?
BasicScrollBarUI:1269 - why are you using here? would allow work
the same and allow to avoid SuppressWarning
BasicTableHeaderUI, BasicTableUI - you can replace Enumerat
es (or more) after the param name.
I would have agreed if we didn’t have 1 space everywhere in else in the same
file. Thank you for a reference to a nice reading.
The fix looks good.
With best regards. Petr.
> On Jun 21, 2014, at 9:03 AM, Steve Sides wrote:
>
>
> On 6/19/2014 12:1
июня 2014 г., at 10:26, Dmitriy Ermashov
wrote:
> On 06/19/2014 06:39 PM, Petr Pchelko wrote:
>> Hello, Dmitriy.
>>
>> It's impossible to review))
> Impossible is nothing! (c))
>> I've briefly skimmed the classes and didn't see any problems with the te
Hello, Dmitriy.
It's impossible to review))
I've briefly skimmed the classes and didn't see any problems with the tests.
Looks like these are pretty much the same)
Did you check that these tests pass on all platforms?
Thank you.
With best regards. Petr.
On 19 июня 2014 г., at 18:21, Dmitriy E
Thank you. The version looks good.
With best regards. Petr.
On 19 июня 2014 г., at 16:26, andrei.eremeev wrote:
> Hi,
>
> I have fixed Petr's remarks.
>
> http://cr.openjdk.java.net/~yan/8046895/webrev.01/
>
> Andrei
>
> On 06/18/2014 04:13 PM, Petr Pc
Looks good.
With best regards. Petr.
On 19 июня 2014 г., at 16:25, andrei.eremeev wrote:
> Hi,
>
> I have fixed Petr's remarks.
> http://cr.openjdk.java.net/~yan/8046446/webrev.01/
>
> Andrei
>
> On 06/18/2014 02:39 PM, Petr Pchelko wrote:
>> Hello, An
Hello, Steve.
A couple of comments:
1. CellRendererPane:192 - I've never seen that we write one-liner javadoc.
May be it's better to split it into 3 lines to conform to the common
pattern?
2. DefaultDesktopManager:480 - "iconifyFrame()" is definetely a candidate to
add @code tag
line 6
Hello, Andrei.
Looks fine to me.
With best regards. Petr
On 18 июня 2014 г., at 14:17, andrei.eremeev wrote:
> Hi Swing team,
>
> Please, review the fix for the issue:
> https://bugs.openjdk.java.net/browse/JDK-8046596
>
> The fix is available at:
> http://cr.openjdk.java.net/~yan/8046596/we
Hello, Andrei.
Looks good to me.
With best regards. Petr.
On 17 июня 2014 г., at 17:44, andrei.eremeev wrote:
> Hi Swing team,
>
> Please, review the fix for the issue:
> https://bugs.openjdk.java.net/browse/JDK-8046595
>
> The fix is available at:
> http://cr.openjdk.java.net/~yan/8046595/w
Please ignore my comment about alignment, you are actually doing that in a
right way, my bad.
With best regards. Petr.
On 18 июня 2014 г., at 16:06, Petr Pchelko wrote:
> Hello, Andrei.
>
> TagElement: 99 Could you please add an empty line before @return as
> everywhere els
Hello, Andrei.
TagElement: 99 Could you please add an empty line before @return as everywhere
else.
Also could could you please fix the alignment of the beginnings of the
parameter descriptions.
Thank you.
With best regards. Petr.
On 16 июня 2014 г., at 16:07, andrei.eremeev wrote:
> Hi Swi
Hello, Andrei.
HTMLEditorKit.java:276 - the beginning of the description if not aligned
Actually all the HTMLEditorKit has alignment issues. For example lines
1754-1764.
Why some parameter descriptions are aligned and others are not?
I think it's better to align the beginnings of the parameter
of
>>> synchronization in this method. Was the removal intentional? How is the
>>> method supposed to work now when called from multiple threads?
>>>
>>> --
>>> best regards,
>>> Anthony
>>>
>>> On 6/5/2014 12:16 PM, Pet
is unavailable.
> 3. No, I haven't filed any bugs yet. I'll file all the issues I've found in
> the nearest future.
>
> Regards,
> Alexey.
>
> On 05.06.2014 11:08, Petr Pchelko wrote:
>> Hello, Alexey.
>>
>> A couple of comments:
>>
Hello, Alexey.
A couple of comments:
1. ThemeReader:64 - I suggest to remove that comment as it does not add any
value. The variable name is self explanatory.
2. XPStyle - did you try providing a stub XPStyle object instead of changing
many of it's methods? Do I understand correctly that this
is
Hello, Roger.
The fix looks good.
With best regards. Petr.
On 30 мая 2014 г., at 22:22, roger riggs wrote:
> A quick sanity check please for these cleanup changes to remove uses of
> new Boolean and using chars instead of single character strings contributed
> by Otávio Gonçalves de Santana.
ly such behavior is caused by popups caching.
>>>>> I need more time for deeper investigation.
>>>>>
>>>>> Thanks,
>>>>> Dmitry
>>>>> On 14/05/2014 14:46, Anthony Petrov wrote:
>>>>>> To add to what Pe
Hello, Peter.
Looks good to me too.
With best regards. Petr.
On May 23, 2014, at 7:14 PM, Pete Brunet wrote:
> Thanks Alexandr.
>
> So far Alexandr is the only reviewer of this. I'd like one more.
>
> Thanks, Pete
>
> On 5/23/14 5:34 AM, Alexander Scherbatiy wrote:
>> On 5/22/2014 9:59 PM,
Hello, AWT Team.
Please review the fix for the issue:
https://bugs.openjdk.java.net/browse/JDK-8043610
The fix is available at:
http://cr.openjdk.java.net/~pchelko/9/8043610/webrev/
The problem is that JComponent has 3 methods which are known to be safe to call
from any thread - invalidate, reva
On May 14, 2014, at 7:00 PM, Alexander Scherbatiy
wrote:
>
> The fix looks good for me.
>
> Thanks,
> Alexandr.
>
> On 5/14/2014 6:13 PM, Petr Pchelko wrote:
>> Hello,
>>
>> Please review the fix for the issue:
>> https://bugs.op
Hello,
Please review the fix for the issue:
https://bugs.openjdk.java.net/browse/JDK-8031485
The fix is available at:
http://cr.openjdk.java.net/~pchelko/9/8031485/webrev.00/
We should not consume the ESC if the popup is not visible.
Thank you.
With best regards. Petr.
ou've removed a call to
> AquaUtils.getCImageCreator().createImageOfFile(path, height, width). What was
> the original purpose of that call? What icon it is used to return?
>
> On 4/23/2014 18:26, Petr Pchelko wrote:
>> Hello, AWT Team.
>>
>> Friendly reminder)
&
Hello, AWT Team.
Friendly reminder)
With best regards. Petr.
On 02.04.2014, at 19:02, Petr Pchelko wrote:
> Hello, AWT team.
>
> Please review a step 1 fix for the issue:
> https://bugs.openjdk.java.net/browse/JDK-7124250
> The fix is here:
> http://cr.openjdk.java.net/
es new package private
> function requires CCC approval?
>
> ~ Vivi
>
> On 4/10/2014 7:25 AM, Petr Pchelko wrote:
>> Hello, Vivi.
>>
>>>> Is it possible to write a test (manual or automated) for the fix?
>>> Two test files (One for JTree, one for J
Hello, Vivi.
>> Is it possible to write a test (manual or automated) for the fix?
> Two test files (One for JTree, one for JTable) attached to the bug for manual
> test, comments added in each file about the how to do the test.
Is is possible to make an automatic test?
You could show the JTree
Hello, Alexander.
The fix looks good.
With best regards. Petr.
On 07.04.2014, at 16:38, Alexander Scherbatiy
wrote:
>
> Hello,
>
> Could you review the fix:
> bug: https://bugs.openjdk.java.net/browse/JDK-6475394
> webrev: http://cr.openjdk.java.net/~alexsch/6475394/webrev.00
>
> The "h
Hello, Sergey.
The fix looks good to me.
With best regards. Petr.
On 05.04.2014, at 1:16, Jim Graham wrote:
> The new code in SwingUtilities2 looks good to me, so I'll approve that file.
> I'll leave the code in the rest of the files to Petr...
>
> ...jim
>
> On 4/4/1
Hello, AWT team.
Please review a step 1 fix for the issue:
https://bugs.openjdk.java.net/browse/JDK-7124250
The fix is here:
http://cr.openjdk.java.net/~pchelko/9/7124250/webrev/
In case Java is not installed we've requested an icon that Finder would've used
for the folder where the java executa
Hello, Alexander.
The fix looks good to me.
With best regards. Petr.
On 02.04.2014, at 18:10, Alexander Scherbatiy
wrote:
>
> Hello,
>
> Could you review the fix:
> bug: https://bugs.openjdk.java.net/browse/JDK-6612752
> webrev: http://cr.openjdk.java.net/~alexsch/6612752/webrev.00
>
>
Hello, Alexander.
The second version of the fix looks good to me.
With best regards. Petr.
On 02.04.2014, at 18:04, alexander stepanov
wrote:
> Please find the updated webrev here:
> http://cr.openjdk.java.net/~yan/8039074/webrev.01/
>
> On 02.04.2014 17:25, Petr Pchelko wro
itable:
> "painters for SynthPainter methods" - for
> plaf/synth/doc-files/synthFileFormat.html
> "nimbus primary colors" and "nimbus secondary colors" for
> plaf/nimbus/doc-files/properties.html
>
> Thanks.
>
> Regards,
> Alexander
>
Hello, Alexander.
src/share/classes/javax/swing/RowSorter.java - I assume the change's that you's
changed the minus symbol? It's not clear from the webrev..
src/share/classes/javax/swing/plaf/nimbus/doc-files/properties.html - line 89 -
"summaTy" - typo. Also, why don't you add a real summary f
Hello, Sergey.
Thank you for the clarification. I was worried because the focus size is
hard-coded.
The fix looks good to me.
With best regards. Petr.
On 01.04.2014, at 16:53, Sergey Bylokhov wrote:
> On 4/1/14 4:33 PM, Petr Pchelko wrote:
>> Hello, Sergey.
>>
>>
Hello, Sergey.
Does the fix work for retina thin focuses and non-retina thick?
With best regards. Petr.
On 01.04.2014, at 15:46, Sergey Bylokhov wrote:
> Hello.
> Please review the fix for jdk 9.
> JRS draws all component in specified bounds, but if a component is in focus,
> the frame of foc
Hello, Alexander.
The fix looks good to me.
With best regards. Petr.
On 01.04.2014, at 15:57, Sergey Bylokhov wrote:
> Hi, Alexander.
> Looks fine.
> On 4/1/14 2:53 PM, Alexander Scherbatiy wrote:
>>
>> Hello,
>>
>> Could you review the fix:
>> bug: https://bugs.openjdk.java.net/browse/JDK-7
Hello, Sergey.
Looks good to me.
With best regards. Petr.
With best regards. Petr.
On 31.03.2014, at 2:13, Sergey Bylokhov wrote:
> Hello.
> Please review a small fix for jdk 9.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8038657
> Webrev can be found at: http://cr.openjdk.java.net/~s
And to me.
With best regards. Petr.
On 04.03.2014, at 18:19, sergey malenkov wrote:
> The fix looks good to me.
>
> SAM
>
> On 03.03.2014 17:24, Alexander Scherbatiy wrote:
>>
>> Hello,
>>
>> Could you review the fix:
>> bug: https://bugs.openjdk.java.net/browse/JDK-8034955
>> webrev: htt
Hello, Holger.
Thank you for the report.
The reason is that the ThreadPool is creating a thread in a ThreadGroup which
is not associated with any AppContext.
I suppose that the fix for JDK-8019274 would also resolve this issue, but this
should be checked. I’ll write back as I have a chance to
Hello, Keith.
I suppose it was fixed under this bug:
https://bugs.openjdk.java.net/browse/JDK-8019623
With best regards. Petr.
On 19.02.2014, at 13:09, Alexander Scherbatiy
wrote:
> On 2/19/2014 8:03 AM, Keith Amling wrote:
>> I may be barking up the wrong tree e-mailing an OpenJDK list when
Great, thank you, Anton.
The fix looks good to me.
With best regards. Petr.
31 янв. 2014 г., в 11:55 до полудня, Anton V. Tarasov
написал(а):
> Hi Petr,
>
> On 30.01.2014 18:16, Petr Pchelko wrote:
>> Hello, Anton.
>>
>> Great, you are removing the dirty JViewP
Hello, AWT team.
Please review the simple fix for the issue:
https://bugs.openjdk.java.net/browse/JDK-8033326
The fix is available at:
http://cr.openjdk.java.net/~pchelko/9/8033326/webrev/
9 build failed due to an incorrect merge between dev and client.
Thank you,
With best regards. Petr.
Hello, Anton.
Great, you are removing the dirty JViewPort hack)
I have one question: is JViewport a single place where we use the "blit"
rendering?
Also, could you please update the copyright years.
Also, may be we could replace the RepaintListener instantiation in JLWF with a
lambda? What do
Hello, Alexander.
The fix looks good to me.
With best regards. Petr.
On 22.01.2014, at 15:13, Alexander Scherbatiy
wrote:
>
> Hello,
>
> Could you review the rollback of the fix 8022398:
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8032063
> webrev: http://cr.openjdk.java.net/~alexs
hts
>> reserved.
>> * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>> *
>> * This code is free software; you can redistribute it and/or modify it
>> @@ -57,11 +57,11 @@
>> super.drawGlyphVector(sg2d, g, x, y);
>>
Hello, Joe.
The fix looks good.
For the next reviewer - the correct link to the new version is
http://cr.openjdk.java.net/~darcy/8032047.1/
With best regards. Petr.
On 17.01.2014, at 11:31, Joe Darcy wrote:
> Hi Petr,
>
> On 01/16/2014 11:20 PM, Petr Pchelko wrote:
>> Hello
Hello, Joe.
A couple of small comments:
AffineTransformOp.java: Could you please split a long line #241
ClipboardTransferable.java: You can safely remove the
DataTransferer.getInstance in this place.
The DataTransferer is a singleton and it's already created by this time.
SunDragSourceContextP
Hello, AWT and Swing Team.
I want to discuss an idea with you. What do you think making almost all methods
in all listener interfaces in Swing and AWT default with empty implementation,
the same way it's done in adapters? This would be convenient if we are writing
something like this:
public c
Hello, Sergey.
The fix looks good.
With best regards. Petr.
On 23.12.2013, at 18:11, Sergey Bylokhov wrote:
> Hello.
> Please review the fix for jdk 9.
> Initial bug was accidentally fixed as a part of JDK-8004866. This is the test
> for this problem.
> The test draws jbutton to the graphics
Hello, Sergey.
The fix looks good, just 2 tiny comments:
line 64: you have a typo: shuould
line 65: testImages(images[1], images[1], false) - I believe this is also a
typo, you are comparing the same images, so the second 1 should be changed to 2.
With best regards. Petr.
On 28.11.2013, at 17:
95 matches
Mail list logo
