[jdk17] Withdrawn: 8271489: (doc) Clarify Filter Factory example

2021-07-29 Thread Roger Riggs
On Thu, 29 Jul 2021 16:36:21 GMT, Roger Riggs wrote: > Improve the clarity of comments in the ObjectInputFilter FilterInThread > example. This pull request has been closed without being integrated. - PR: https://git.openjdk.java.net/jdk17/pull/292

[jdk17] RFR: 8271489: (doc) Clarify Filter Factory example

2021-07-29 Thread Roger Riggs
Improve the clarity of comments in the ObjectInputFilter FilterInThread example. - Commit messages: - 8271489: (doc) Clarify Filter Factory example - 8270398: Enhance canonicalization - 8270404: Better canonicalization - Merge - Merge - 8263531: Remove unused buffer int - 82627

Re: FYI: new javadoc tag to document system properties

2019-01-30 Thread Roger Riggs
Hi, If a system property is defined and specified as supported then it needs a public declaration and specification as part of the public class or package documentation. Checking for and adding the tag will be a good way to reconfirm property definitions are in the right place. Would it be r

RFR 8214014 : Remove vestiges of gopher: protocol proxy support

2018-11-28 Thread Roger Riggs
Please review the removal of some left over references to the gopher protocol related to proxies. Most are related to properties or setting up proxies (for gopher). Please check in javax.print that the inclusion of the gopher protocol is no longer needed. Webrev:   http://cr.openjdk.java.net/

Re: Reviews in plain text?

2015-12-23 Thread Roger Riggs
Hi, Each webrev includes the text patch, follow the jdk.patch link in the header. Webrev is the normal mechanism for code reviews and provides several different views of the original and modifications. Roger On 12/23/15 8:50 AM, Alexey Ivanov wrote: Hi Rajeev, Could you please create co

RFR 80044460: Cleanup new Boolean and single character strings

2014-05-30 Thread roger riggs
A quick sanity check please for these cleanup changes to remove uses of new Boolean and using chars instead of single character strings contributed by Otávio Gonçalves de Santana. These changes update multiple classes in the client repo. webrev: http://cr.openjdk.java.net/~rriggs/webrev-804446

Re: RFR Doclint cleanup of javax.swing

2013-11-08 Thread roger riggs
ut properly received approvals. Note that the change is in awt+swing team repository. Sorry about that! Thanks, -yan On 11/08/2013 02:02 AM, roger riggs wrote: This changeset addresses the warnings and errors of doclint and improves the quality of the generated html. No spec or implementati

Re: RFR Doclint cleanup of javax.swing

2013-11-08 Thread roger riggs
f" May be it is better to use an uniform style for all cases. Thanks, Alexandr. On 11/8/2013 2:02 AM, roger riggs wrote: This changeset addresses the warnings and errors of doclint and improves the quality of the generated html. No spec or implementation is changed by this changeset Th

RFR Doclint cleanup of javax.swing

2013-11-07 Thread roger riggs
This changeset addresses the warnings and errors of doclint and improves the quality of the generated html. No spec or implementation is changed by this changeset The changes address issues including html syntax, accessibility issues, and improper html tag use. Refer to the error log attached to