Re: [9] Review request for 8081478: [TESTBUG] Test javax/swing/plaf/synth/SynthButtonUI/6276188/bug6276188.java fails for OEL 7 only

+1 -yan On 04/19/2017 08:27 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8081478 webrev: http://cr.openjdk.java.net/~ssadetsky/8081478/webrev.00/ Delay was added to ensure that window is shown to take it final location. --Semyo

Re: [9] Review request for 8142534: [TEST_BUG] Test javax/swing/JMenu/8072900/WrongSelectionOnMouseOver.java fails for Ubuntu 15.10

+1 -yan On 04/11/2017 09:25 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8142534 webrev: http://cr.openjdk.java.net/~ssadetsky/8142534/webrev.00/ In Ubuntu starting version 15 the current active windows gets an external transluc

Re: [9] Review Request: 8177766 [TEST_BUG] JPopupMenu tests fails intermittently

Looks fine. -yan On 03/29/2017 03:46 PM, Sergey Bylokhov wrote: Hello, Please review the fix for jdk9. The problem is that these tests shows popup menu and expects that some specific menuitems will be selected after keyboard navigation. But some other test in the javax/swing/JPopupMenu/** mo

Re: [9] RFR JDK-8174717: [TEST_BUG] javax/swing/text/html/StyleSheet/bug4936917.java

+1 -yan On 02/13/2017 10:58 AM, Prasanta Sadhukhan wrote: Hi All, Please review a simple fix for an issue where the tests fails due to lack of delay before checking for robot output value. Bug: https://bugs.openjdk.java.net/browse/JDK-8174717 webrev: http://cr.openjdk.java.net/~psadhukhan/8174

Re: [9] RFR JDK-8174720: [TEST_BUG] add :open to a @modules annotation for bug7089914.java

+1 -yan On 02/13/2017 10:58 AM, Prasanta Sadhukhan wrote: Hi All, Please review a simple fix to add "open" to module to aid jigsaw accessibility. Bug: https://bugs.openjdk.java.net/browse/JDK-8174720 webrev: http://cr.openjdk.java.net/~psadhukhan/8174720/webrev.00/ Regards Prasanta

Re: [9] RFR JDK-7190595: Nimbus: Test6657026 fails

Tested it: it works well (pass consistently with patched build failing consistently with b151). So, +1 -yan On 01/24/2017 05:16 PM, Prasanta Sadhukhan wrote: Hi All, Please review a fix for an issue where it is seen javax/swing/plaf/basic/BasicSplitPaneUI/Test6657026.java fails reporting "Sha

Re: [9] RFR: JDK-8172012: [TEST_BUG] delays needed in javax/swing/JTree/4633594/bug4633594.java

+1 On 01/13/2017 01:48 PM, Prasanta Sadhukhan wrote: Hi All, Bug: https://bugs.openjdk.java.net/browse/JDK-8172012 The issue of not having a delay between robot events is already addressed by adding autodelay and has been approved in closed crucible review. This webrev addresses moving the clo

Re: [9] RFR JDK-8172558: [PIT][TEST_BUG] Bad filename for javax/swing/JTable/8133919/DrawGridLinesTest.java

It's fine and necessary fix but it should be done in the integration repository, not in client. Otherwise, the bug would stay in master for 2 next builds and prevent jtreg starting at all. +1 -yan On 01/12/2017 10:04 AM, Prasanta Sadhukhan wrote: Hi All, Please review the name change for this

Re: [9] Review request for 8160441: [PIT][TEST_BUG][macosx] javax/swing/JComboBox/8041909/ActionListenerExceptionTest.java

+1 (I personally never add test bug numbers: it is in commit message anyway) -yan On 12/07/2016 03:57 PM, Alexander Popov wrote: Hello, review my changes please. Webrev: http://cr.openjdk.java.net/~yan/8160441/webrev.00/ Issue: https://bugs.openjdk.java.net/browse/JDK-8160441 This is a test

Re: [9] Review request for JDK-8159906: [TEST_BUG] javax/swing/JDialog/Transparency/TransparencyTest.java

Fine with me. -yan On 12/05/2016 03:08 PM, Maksim Khramov wrote: Hello, webrev updated: http://cr.openjdk.java.net/~yan/8159906/webrev.01/ Added bugid DlgPos variable marked as volatile. Thanks, Maksim. On 02.12.2016 18:01, Prasanta Sad

Re: [9] Review request for 8167284: [TESTBUG] [PIT] possible regression: javax/swing/JRadioButton/FocusTraversal/FocusTraversal.java

+1 -yan On 11/25/2016 05:29 PM, Maksim Khramov wrote: Hello, please review this request... Webrev: http://cr.openjdk.java.net/~yan/8167284/webrev.00/ Issue: https://bugs.openjdk.java.net/browse/JDK-8167284 Test bug. The behavior of trans

Re: 8168540: [TEST_BUG] On Unity, need a delay before screenshot taking to avoid animation

Oh yes, this fix does help. My system is not particularly slow but it is dual-screen, Ubuntu 16.10 -- timing may differ. Approved. Thanks, -yan On 10/27/2016 11:34 AM, Avik Niyogi wrote: It did not fail on my system but it probably failed for slow systems in testing environment. Similar cases

Re: Swing Dev>[9] Review Request JDK-8163160 [PIT][TEST_BUG] Some issues in java/awt/image/multiresolution/MultiResolutionIcon/IconTest.java

Chamyal wrote: Hello Yuri, I have attached a snapshot of button in JBS. The button icon border is Yellow. https://bugs.openjdk.java.net/browse/JDK-8163160 Regards, Rajeev Chamyal -Original Message- From: Yuri Nesterenko Sent: 19 August 2016 16:38 To: Rajeev Chamyal; Sergey Bylokhov

Re: Swing Dev>[9] Review Request JDK-8163160 [PIT][TEST_BUG] Some issues in java/awt/image/multiresolution/MultiResolutionIcon/IconTest.java

Hi Rajeev, I tried this version of the test on two Ubuntu 16.04 systems with Unity and a promoted b132. Now, the Launcher icon is blue with yellow border around it -- but the icon on the frame with label "Test" is blue with gray border. I think you should either change instructions even more or l

Re: [9] Review request for 8160986 Bad rendering of Swing UI controls with Metal L&F on HiDPI display

You mean probably that the first test would not compile since it is "public class bug8160986 " in bug8031573.java ?:-) -yan On 07/27/2016 12:08 AM, Phil Race wrote: Since I noticed it right away, I am sure lots of others will soon enough. -phil. On 07/25/2016 02:19 PM, Sergey Bylokhov wrote:

Re: 8160438: [PIT][macosx] [TEST_BUG] javax/swing/plaf/nimbus/8057791/bug8057791.java fails

Sadetsky mailto:semyon.sadet...@oracle.com>> wrote: On 7/7/2016 6:30 PM, Yuri Nesterenko wrote: On 07/07/2016 06:15 PM, Semyon Sadetsky wrote: On 7/7/2016 5:58 PM, Yuri Nesterenko wrote: On 07/07/2016 05:35 PM, Yuri Nesterenko wrote: On 07/07/2016 05:04 PM, Semyon Sadetsky wrote:

Re: 8160438: [PIT][macosx] [TEST_BUG] javax/swing/plaf/nimbus/8057791/bug8057791.java fails

On 07/07/2016 06:15 PM, Semyon Sadetsky wrote: On 7/7/2016 5:58 PM, Yuri Nesterenko wrote: On 07/07/2016 05:35 PM, Yuri Nesterenko wrote: On 07/07/2016 05:04 PM, Semyon Sadetsky wrote: On 07.07.2016 16:35, Avik Niyogi wrote: Hi Semyon, Thank you for the review comment. In Mac OS X

Re: 8160438: [PIT][macosx] [TEST_BUG] javax/swing/plaf/nimbus/8057791/bug8057791.java fails

On 07/07/2016 05:35 PM, Yuri Nesterenko wrote: On 07/07/2016 05:04 PM, Semyon Sadetsky wrote: On 07.07.2016 16:35, Avik Niyogi wrote: Hi Semyon, Thank you for the review comment. In Mac OS X, *System Preferences > Displays > Colors > Display Profile* section, the default value

Re: 8160438: [PIT][macosx] [TEST_BUG] javax/swing/plaf/nimbus/8057791/bug8057791.java fails

On 07/07/2016 05:04 PM, Semyon Sadetsky wrote: On 07.07.2016 16:35, Avik Niyogi wrote: Hi Semyon, Thank you for the review comment. In Mac OS X, *System Preferences > Displays > Colors > Display Profile* section, the default value is *Color LCD*. This causes a failure in some test cases whi

Re: [9] Review Request: 8159899 [TEST_BUG] Timeout in tests when OOM should be generated

+1 -yan On 06/27/2016 06:25 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk9. Some of our tests fails with timeout when they tries to generate OOM. This occur on the systems which have huge number of memory. In the fix I added "-xm" option to minimize the available amount of m

Re: [9] Review request for 8156128: Tests for [AWT/Swing] Conditional support for GTK 3 on Linux

s should not be described in a specification but in case there will be questions, there would be the answer. Thank you, -yan --Semyon On 5/5/2016 5:23 PM, Yuri Nesterenko wrote: Colleagues, could you please review the tests for the new jdk.gtk.version property? Webrev is http://cr.openjdk.j

Re: [9] Review request for 8156128: Tests for [AWT/Swing] Conditional support for GTK 3 on Linux

t. -phil. On 05/05/2016 07:23 AM, Yuri Nesterenko wrote: Colleagues, could you please review the tests for the new jdk.gtk.version property? Webrev is http://cr.openjdk.java.net/~yan/8156128/webrev.00/ CR is https://bugs.openjdk.java.net/browse/JDK-8156128 A couple of interesting scenarios would

[9] Review request for 8156128: Tests for [AWT/Swing] Conditional support for GTK 3 on Linux

Colleagues, could you please review the tests for the new jdk.gtk.version property? Webrev is http://cr.openjdk.java.net/~yan/8156128/webrev.00/ CR is https://bugs.openjdk.java.net/browse/JDK-8156128 A couple of interesting scenarios would require some system preparation (read: hacks) and are n

Re: [9] Review request for 8153276: [TEST_BUG] javax/swing/JFileChooser/ShellFolderQueries/ShellFolderQueriesTest.java

Case().contains("windows") ? Then you neither need jtreg to run it, nor internal API. I agree. See the updated webrev: http://cr.openjdk.java.net/~ssadetsky/8153276/webrev.01/ --Semyon -phil. On 4/13/16, 11:44 AM, Sergey Bylokhov wrote: +1 On 13.04.16 17:17, Yuri Nesterenko wrote: Lo

Re: [9] Review request for 8153276: [TEST_BUG] javax/swing/JFileChooser/ShellFolderQueries/ShellFolderQueriesTest.java

Looks good to me. -yan On 04/13/2016 05:07 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8153276 webrev: http://cr.openjdk.java.net/~ssadetsky/8153276/webrev.00/ Internal API usage sun.awt.OSInfo was replaced by jdk.testlibrary.OS

Re: [9] Review Request for several test bugs: 8150535, 8151033, 8151037 etc.

on from WM directly and is more reliable. --Semyon On 3/24/2016 6:12 PM, Yuri Nesterenko wrote: Sergey, I'm sorry, filing JDK-8152693, I found an error in that version. A new one is http://cr.openjdk.java.net/~yan/8150535/webrev.02 The spawned processes were provided with addExports. Sh

Re: [9] Review Request for several test bugs: 8150535, 8151033, 8151037 etc.

Sergey, I'm sorry, filing JDK-8152693, I found an error in that version. A new one is http://cr.openjdk.java.net/~yan/8150535/webrev.02 The spawned processes were provided with addExports. Shame on me! -yan On 03/24/2016 05:34 PM, Sergey Bylokhov wrote: cc swing-dev On 24.03.16 17:17,

Re: [9] Review Request: 8151857 [TEST_BUG] bug6544309.java fails intermittently

Looks fine. -yan On 03/15/2016 03:28 AM, Sergey Bylokhov wrote: Hello, Please review the small fix for jdk9. The test javax/swing/JPopupMenu/6544309/bug6544309.java fails if executed in a batch via jtreg. The problem is that this test shows popup menu and expects that some specific menuitems w

Re: [9] Review Request: 8080948 [TEST_BUG]Few test cases are failing due to use of getPeer()

The fix looks fine to me. Thanks, -yan On 09/01/2015 04:30 PM, Sergey Bylokhov wrote: Hello. Please review the small fix for jdk9. I hope this is a last issue related to peer and @modules. The one test is updated to use an accessors, correct @modules tag was added. + small cleanup. All other t

Re: java.awt.AWTKeyStroke.registerSubclass(Class subclass) method usage.

Alexander, perhaps you should post this question to i18n-dev as well. Indeed, I think the only real life code using this might be some Java IM or similar tool. Thanks, -yan On 07/27/2015 04:48 PM, Alexander Scherbatiy wrote: Hello, The class KeyStroke has been added to the javax.swing packag

[9] Review Request for 8130430: [TEST_BUG] remove unnecessary internal calls from javax/swing/JRadioButton/8075609/bug8075609.java

Colleagues, please review this test fix; webrev: http://cr.openjdk.java.net/~yan/8130430/webrev.00/ CR: https://bugs.openjdk.java.net/browse/JDK-8130430 Removed some calls of internal API and a couple of typos fixed in a single test. Thanks, -yan

Re: [9] Review Request for 8129940: JRadioButton does not honor non-standard FocusTraversalKeys

Hi friends, as to bug8075609.java, cound you look at my request [9] Review Request for 8130125: [TEST_BUG] add @modules to the several client tests unaffected by the automated bulk update there it is fixed, I guess! -yan On 07/02/2015 03:53 PM, Semyon Sadetsky wrote: Hi Alexander, 1. It

Re: RFR: JDK-8076468 Add @modules to tests in jdk_desktop test group

Hi Alexander, the fix looks OK to me. Thanks, -yan On 06/22/2015 06:44 PM, Alexander Kulyakhtin wrote: Hi, Could you, please, review the test-only changes for the JDK-8076468 CR: JDK-8076468 "Add @modules to the tests in jdk_desktop test group" Webrev: http://cr.openjdk.java.net/~akulyakh/80

Re: RFR: JDK-8076468: Add @modules to jtreg jdk_desktop tests to take into account the new modular architecture

Hi Alexander(s), I have some problems not with this change but with the routine itself. As I understand, this change is automatically generated. The generator script is imperfect. For instance, it cannot catch dependencies in places like javax/swing/RepaintManager/6608456/bug6608456.java where t

Re: [9] Review Request: JDK-8079428 [TEST_BUG] Test javax/swing/plaf/windows/6921687/bug6921687.java fails

I guess the @build instruction here adds some degree of uncertainty: jtreg may not be able to determine which class to run. -yan On 05/06/2015 04:45 PM, Alexey Ivanov wrote: Hello, I faced this problem too, and only with JDK 9. If there's no @run tag in the java file, the main method of the te

Re: [9] Review Request for 8076315: move 4 manual functional swing tests to regression suite

-EDT thread. 31.03.15 16:33, Yuri Nesterenko wrote: Colleagues, please review this 4 manual tests to be moved to jdk/test/javax/swing from internal Swing functional suite: Webrev: http://cr.openjdk.java.net/~yan/8076315/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8076315 Tests proved

[9] Review Request for 8076315: move 4 manual functional swing tests to regression suite

Colleagues, please review this 4 manual tests to be moved to jdk/test/javax/swing from internal Swing functional suite: Webrev: http://cr.openjdk.java.net/~yan/8076315/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8076315 Tests proved on Linux (Xfce, Gnome 3), Windows 8.1, OS X. In th

Re: [9] Review Request for 8074092: Newly introduced unnecessary dependencies on internal API in client regtests

with @library /javax/swing/regtesthelper @library /lib/testlibrary Library path is concatenated to the directory in which TEST.ROOT is located. Andrei Eremeev On 03/04/2015 04:28 PM, Yuri Nesterenko wrote: Hi! Please review this fix for several regression tests. Webrev: http://cr.openjdk.java.net

Re: [9] Review Request: 8074028 Remove API references to java.awt.peer

On 03/04/2015 04:35 PM, Sergey Bylokhov wrote: On 04.03.2015 15:51, Alan Bateman wrote: On 04/03/2015 12:37, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 9. There are a number of public API whichreference the unsupported java.awt.peer interfaces. public java.awt.Component.getPee

[9] Review Request for 8074092: Newly introduced unnecessary dependencies on internal API in client regtests

Hi! Please review this fix for several regression tests. Webrev: http://cr.openjdk.java.net/~yan/8074092/webrev.00 CR: https://bugs.openjdk.java.net/browse/JDK-8074092 In bug8062561.java test an error message also changed. Verified on 3 platforms. Thanks, -yan

Re: [9] Review Request for 8063107: Change open swing regression tests to avoid sun.awt.SunToolkit.realSync, part 2

Thank you guys! I'm pushing. -yan On 11/21/2014 03:46 PM, Petr Pchelko wrote: Hello, Yuri. The fix looks good to me too. With best regards. Petr. On Nov 21, 2014, at 2:34 PM, Alexander Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 11/21/2014 2:26 PM,

[9] Review Request for 8063107: Change open swing regression tests to avoid sun.awt.SunToolkit.realSync, part 2

Colleagues, please review yet another modularization-related test fix. http://cr.openjdk.java.net/~yan/8063107/webrev.00/ pre-move state of the closed tests: http://cr.openjdk.java.net/~yan/8063107/webrev.diff.00 This batch contains some 109 Swing tests, several of them ported from closed repos

[9] Review Request for 8063106: Change open swing regression tests to avoid sun.awt.SunToolkit.realSync, part 1

Colleagues, this is Swing part of the change: a first batch of 35 regression tests (or rather 34 tests and a helper) modified to eliminate internal references (mostly to realSync but not only). Several closed tests moved in the open. By mistake, the removal part (webrev.00.diff) was included also

Re: [9] Review Request: JDK-8058805 Fix type in client-related package for tray.policy file missing in java/awt/TrayIcon/SecurityCheck/NoPermissionTest

://bugs.openjdk.java.net/browse/JDK-8058805 Please review further . Regards, Pooja On 10/15/2014 1:06 PM, Yuri Nesterenko wrote: Hi Pooja, perhaps it would be better to have _something_ in this policy file, for instance a comment. Thanks, -yan On 09/30/2014 05:46 PM, pooja chopra wrote: Hello All, Gentle reminder

Re: [9] Review Request: JDK-8058805 Fix type in client-related package for tray.policy file missing in java/awt/TrayIcon/SecurityCheck/NoPermissionTest

Hi Pooja, perhaps it would be better to have _something_ in this policy file, for instance a comment. Thanks, -yan On 09/30/2014 05:46 PM, pooja chopra wrote: Hello All, Gentle reminder . Please review below fix . Regards, Pooja On 9/19/2014 5:04 PM, pooja chopra wrote: |Hello, | || |Please

Re: [9] Review request for 8058726: Update regtests using sun.awt.OSInfo, part 1

Great, thank you! -yan On 09/18/2014 04:30 PM, Alexander Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 9/18/2014 2:48 PM, Yuri Nesterenko wrote: Colleagues, please review this change in tests only: http://cr.openjdk.java.net/~yan/8058726/webrev.00 and http

[9] Review request for 8058726: Update regtests using sun.awt.OSInfo, part 1

Colleagues, please review this change in tests only: http://cr.openjdk.java.net/~yan/8058726/webrev.00 and http://cr.openjdk.java.net/~yan/8058726/webrev.diff.00 for a bug https://bugs.openjdk.java.net/browse/JDK-8058726 Thanks, -yan

Re: [9] Review Request for 8056991: Provide OSInfo functionality to regression tests

Thank you Alexander! I hope I may push it with your single review: the change is in test area and seems virtually harmless. Cheers, -yan On 09/15/2014 03:13 PM, Alexander Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 9/15/2014 3:00 PM, Yuri Nesterenko wrote: On

Re: [9] Review Request for 8056991: Provide OSInfo functionality to regression tests

se in Swing classes. I'm retaining it because (1) no harm in it and (2) this way, it would be much simpler to maintain a duplicate of sun.awt.OSInfo in case of a change. -yan Thanks, Alexandr. On 9/15/2014 11:35 AM, Yuri Nesterenko wrote: Dear friends, one more weekly reminder! Withou

[9] Review Request for 8056991: Provide OSInfo functionality to regression tests

Dear friends, one more weekly reminder! Without this (or similar) fix applied, we cannot start changes of ~60 regtests, and time is short. Cheers, -yan On 09/08/2014 01:09 PM, Yuri Nesterenko wrote: Weekly reminder! Cheers, -yan On 09/01/2014 12:44 PM, Yuri Nesterenko wrote: Colleagues

[9] Review Request for 8056991: Provide OSInfo functionality to regression tests

Weekly reminder! Cheers, -yan On 09/01/2014 12:44 PM, Yuri Nesterenko wrote: Colleagues, please review this minimal change to fix https://bugs.openjdk.java.net/browse/JDK-8056991 http://cr.openjdk.java.net/~yan/8056991/webrev.00 In the webrev there is an example of a test refactored. We

[9] Review Request for 8056991: Provide OSInfo functionality to regression tests

Colleagues, please review this minimal change to fix https://bugs.openjdk.java.net/browse/JDK-8056991 http://cr.openjdk.java.net/~yan/8056991/webrev.00 In the webrev there is an example of a test refactored. We need to clean up regression tests from internal dependencies. One of them, dependen

Review request: JDK-8042105: Fix some doclint issues in javax.swing.text.html classes

Hi colleagues, could you please review a change http://cr.openjdk.java.net/~yan/8042105/webrev.00/ for a corresp. bug https://bugs.openjdk.java.net/browse/JDK-8042105 ? All changes are in javax.swing.text.html classes. Here, we fixed some of the issues reported by a doclint doclet of javadoc.

Re: [8] Review Request: 8029264 [doclint] more doclint and tidy cleanup

Thank you guys! -yan On 12/05/2013 05:20 PM, sergey malenkov wrote: The fix look OK for me too. SAM On 04.12.2013 18:45, Alexander Scherbatiy wrote: The fix looks good for me. Thanks, Alexandr. On 12/4/2013 6:24 PM, Yuri Nesterenko wrote: Colleagues, Please review another

Re: [8] Review Request: 8029264 [doclint] more doclint and tidy cleanup

t is better to use the literal tag here. RowFilter.java - * columns are < 0. + * columns are < 0. The literal tag can be used here also. Thanks, Alexandr. On 12/4/2013 11:47 AM, Yuri Nesterenko wrote: One more time! Please take a look. Mailing list is a lousy tool fo

Re: [8] Review Request: 8029264 [doclint] more doclint and tidy cleanup

the {@code L&F}). It seems that it is better to use the literal tag here. RowFilter.java - * columns are < 0. + * columns are < 0. The literal tag can be used here also. Thanks, Alexandr. On 12/4/2013 11:47 AM, Yuri Nesterenko wrote: One more time! Please take a

Re: [8] Review Request: 8029264 [doclint] more doclint and tidy cleanup

One more time! Please take a look. Mailing list is a lousy tool for review requests like this. Thanks, -yan On 12/02/2013 06:07 PM, Yuri Nesterenko wrote: Colleagues, please review this yet another cleanup request. They will never end but then again, they are easy to review. Here'

[8] Review Request: 8029264 [doclint] more doclint and tidy cleanup

Colleagues, please review this yet another cleanup request. They will never end but then again, they are easy to review. Here's the webrev: http://cr.openjdk.java.net/~yan/8029264/webrev.00 Bug is: https://bugs.openjdk.java.net/browse/JDK-8029264 My routine was: increase number of allowed warn

Re: RFR Doclint cleanup of javax.swing

oups/awt/> on openjdk does not provide the link to the awt forest. And I'm not sure I'm up to the testing requirements on all platforms/all tests. Thanks, Roger On 11/8/2013 6:46 AM, Yuri Nesterenko wrote: Hi Roger, I'm afraid you'll have to merge with D.Ginzburg's change

Re: RFR Doclint cleanup of javax.swing

Hi Roger, I'm afraid you'll have to merge with D.Ginzburg's change http://hg.openjdk.java.net/jdk8/awt/jdk/rev/b8eb21e93fa7 He was someway late to push it but properly received approvals. Note that the change is in awt+swing team repository. Sorry about that! Thanks, -yan On 11/08/2013 02:02

Re: [8] Review request for 8025249: [javadoc] fix some javadoc errors in javax/swing/

OK with me, and we already looked at it. -yan On 09/26/2013 05:50 PM, taras ledkov wrote: Hello, Could you please review the fix for the following bug: https://bugs.openjdk.java.net/browse/JDK-8025249 webrev corresponding: http://cr.openjdk.java.net/~alexsch/taras-ledkov/8025249/webrev.00/ Th

Re: [8] Review request for 8025070: [javadoc] fix some javadoc errors in javax/swing/

OK with me. Build with this fix seems ok in respect to doclint for these files. -yan On 09/26/2013 12:36 PM, taras ledkov wrote: Hello, Could you please review the fix for the following bug: https://bugs.openjdk.java.net/browse/JDK-8025249 webrev corresponding: http://cr.openjdk.java.net/~alex

Re: [8] Review request for JDK-8025117: [cleanup] Eliminate doclint errors in javax/swing/text classes

Please review the second version of this request. Alexander, excuse me. Here go additional two files, some 3 or 4 lines of changes, not included by my colleagues in their other requests. Webrev: http://cr.openjdk.java.net/~yan/jdk-8025117/webrev-01 Thanks, -yan On 09/23/2013 01:39 PM, Yuri

[8] Review request for JDK-8025230: [cleanup] some more javadoc formatting fixes for swing

Hello, there's more of the same, javadoc doclint error fixes for some 23 more swing classes. Bug https://bugs.openjdk.java.net/browse/JDK-8025230 Webrev http://cr.openjdk.java.net/~yan/jdk-8025230/webrev-00/ No changes in formatted content, again. Thanks, -yan

[8] Review request for JDK-8025117: [cleanup] Eliminate doclint errors in javax/swing/text classes

Hello, could please review this javadoc fix? https://bugs.openjdk.java.net/browse/JDK-8025117 Objective is, as stated, to get rid of javadoc doclint error messages. No changes in specifications; no visible formatting changes, even. Webrev: http://cr.openjdk.java.net/~yan/jdk-8025117/ Thanks,

Re: [8] Review request for 7104594 [macosx] Test closed/javax/swing/JFrame/4962534/bug4962534 expects Metal L&F by default

Looks OK to me. -yan On 12/18/2012 11:20 AM, Konstantin Shefov wrote: REMINDER On 28-Nov-12 20:39, Konstantin Shefov wrote: Could you please look at this test fix? Webrev: http://cr.openjdk.java.net/~kshefov/7104594/webrev.01/ (already approved by Alexander Scherbatiy) On 22-Nov-12 18:04, An

Re: [8] Review request for 7124242 [macosx] Test doesn't work because of the frame round corners in the LaF -- approved

OK. -yan On 11/22/2012 03:29 PM, Konstantin Shefov wrote: Could you please look at this test fix? Webrev: http://cr.openjdk.java.net/~kshefov/7124242/webrev.00/ On 16-Nov-12 17:38, Alexander Scherbatiy wrote: The fix looks good for me. Could you also create an issue in the awt subcatego

hg: jdk7/swing/langtools: 34 new changesets

Changeset: 8a03f3c7d160 Author:jjg Date: 2009-08-12 07:14 -0700 URL: http://hg.openjdk.java.net/jdk7/swing/langtools/rev/8a03f3c7d160 6870706: langtools launcher issues Reviewed-by: mcimadamore ! make/build.xml ! src/share/bin/launcher.sh-template Changeset: 71680973d8ec Author:

hg: jdk7/swing/jdk: 59 new changesets

Changeset: 1ff977b938e5 Author:sherman Date: 2009-08-13 10:50 -0700 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/1ff977b938e5 6840246: Lightweight implementation of String.split for simple use case Summary: Added a fastpath for simple use case Reviewed-by: alanb, martin ! src

hg: jdk7/swing/jaxws: 2 new changesets

Changeset: 4c990aa99bc0 Author:xdono Date: 2009-09-03 10:52 -0700 URL: http://hg.openjdk.java.net/jdk7/swing/jaxws/rev/4c990aa99bc0 Added tag jdk7-b71 for changeset 03314cf56a72 ! .hgtags Changeset: d79f0d601c2b Author:xdono Date: 2009-09-17 13:46 -0700 URL: http://

hg: jdk7/swing/jaxp: 2 new changesets

Changeset: 37c805b6156f Author:xdono Date: 2009-09-03 10:52 -0700 URL: http://hg.openjdk.java.net/jdk7/swing/jaxp/rev/37c805b6156f Added tag jdk7-b71 for changeset ff94d8ce0dad ! .hgtags Changeset: 93dfa6e0fe76 Author:xdono Date: 2009-09-17 13:46 -0700 URL: http://h

hg: jdk7/swing/hotspot: 74 new changesets

Changeset: f753dffae23e Author:trims Date: 2009-08-13 17:47 -0700 URL: http://hg.openjdk.java.net/jdk7/swing/hotspot/rev/f753dffae23e 6871765: Bump the HS16 build number to 08 Summary: Update the HS16 build number to 08 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 6a9390

hg: jdk7/swing/corba: 5 new changesets

Changeset: 8001ba2bf10d Author:andrew Date: 2009-08-20 01:28 +0100 URL: http://hg.openjdk.java.net/jdk7/swing/corba/rev/8001ba2bf10d 6873059: Explicitly use -source 6 -target 6 when compiling with the boot jdk javac Summary: The bootstrap javac currently uses the default source and

hg: jdk7/swing: 5 new changesets

Changeset: d8b49b53d8cf Author:wetmore Date: 2009-08-14 17:29 -0700 URL: http://hg.openjdk.java.net/jdk7/swing/rev/d8b49b53d8cf 6872177: JCE framework and provider builds broken following -target 7 changes Reviewed-by: ohair ! make/Defs-internal.gmk Changeset: 4c36e9853dda Author:

hg: jdk7/swing/langtools: 33 new changesets

Changeset: 4ac89259512f Author:xdono Date: 2009-08-13 12:11 -0700 URL: http://hg.openjdk.java.net/jdk7/swing/langtools/rev/4ac89259512f Added tag jdk7-b69 for changeset ce9bcdcb7859 ! .hgtags Changeset: 777a3efad0d5 Author:jjg Date: 2009-07-28 10:36 -0700 URL: http:

hg: jdk7/swing/jdk: 95 new changesets

Changeset: 7e491e39ea0f Author:tbell Date: 2009-08-06 17:16 -0700 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/7e491e39ea0f 6865853: Additional code changes needed to build deploy using WXP SP2 and Visual Studio 2008 Reviewed-by: ohair ! src/windows/native/sun/jkernel/kernel

hg: jdk7/swing/jaxp: 12 new changesets

Changeset: 8287833daabc Author:xdono Date: 2009-08-13 12:11 -0700 URL: http://hg.openjdk.java.net/jdk7/swing/jaxp/rev/8287833daabc Added tag jdk7-b69 for changeset a4ab0d6ded63 ! .hgtags Changeset: 1687f5192ce7 Author:asaha Date: 2009-06-22 13:56 -0700 URL: http://h

hg: jdk7/swing/hotspot: 5 new changesets

Changeset: 5021b9893d0a Author:xdono Date: 2009-08-13 12:11 -0700 URL: http://hg.openjdk.java.net/jdk7/swing/hotspot/rev/5021b9893d0a Added tag jdk7-b69 for changeset 54fd4d923296 ! .hgtags Changeset: 185d256992c3 Author:asaha Date: 2009-08-07 11:31 -0700 URL: http:

hg: jdk7/swing/corba: 5 new changesets

Changeset: 07b3e9ba5085 Author:xdono Date: 2009-08-13 12:11 -0700 URL: http://hg.openjdk.java.net/jdk7/swing/corba/rev/07b3e9ba5085 Added tag jdk7-b69 for changeset 8120d308ec4e ! .hgtags Changeset: f3f572ea0cf2 Author:asaha Date: 2009-08-07 11:31 -0700 URL: http://

hg: jdk7/swing: 5 new changesets

Changeset: 51a71c2c4b80 Author:xdono Date: 2009-08-13 12:11 -0700 URL: http://hg.openjdk.java.net/jdk7/swing/rev/51a71c2c4b80 Added tag jdk7-b69 for changeset 82e6c820c51a ! .hgtags Changeset: 4cad5a3f5038 Author:asaha Date: 2009-08-07 11:31 -0700 URL: http://hg.ope

hg: jdk7/swing/langtools: 14 new changesets

Changeset: 14b1a8ede954 Author:xdono Date: 2009-07-28 12:12 -0700 URL: http://hg.openjdk.java.net/jdk7/swing/langtools/rev/14b1a8ede954 6862919: Update copyright year Summary: Update copyright for files that have been modified in 2009, up to 07/09 Reviewed-by: tbell, ohair ! src/sh

hg: jdk7/swing/jdk: 39 new changesets

Changeset: 8eddead6a701 Author:yhuang Date: 2009-07-02 20:17 -0700 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/8eddead6a701 6606396: Notepad and Stylepad demos don't run in Japanese locale. Reviewed-by: peytoia, ogino ! src/share/demo/jfc/Notepad/resources/Notepad_ja.propert

hg: jdk7/swing/jaxws: 6 new changesets

Changeset: faa13cd4d6cd Author:xdono Date: 2009-07-28 12:12 -0700 URL: http://hg.openjdk.java.net/jdk7/swing/jaxws/rev/faa13cd4d6cd 6862919: Update copyright year Summary: Update copyright for files that have been modified in 2009, up to 07/09 Reviewed-by: tbell, ohair ! make/Makef

hg: jdk7/swing/jaxp: 6 new changesets

Changeset: a033af8d824a Author:xdono Date: 2009-07-28 12:12 -0700 URL: http://hg.openjdk.java.net/jdk7/swing/jaxp/rev/a033af8d824a 6862919: Update copyright year Summary: Update copyright for files that have been modified in 2009, up to 07/09 Reviewed-by: tbell, ohair ! make/build.

hg: jdk7/swing/hotspot: 25 new changesets

Changeset: bd02caa94611 Author:xdono Date: 2009-07-28 12:12 -0700 URL: http://hg.openjdk.java.net/jdk7/swing/hotspot/rev/bd02caa94611 6862919: Update copyright year Summary: Update copyright for files that have been modified in 2009, up to 07/09 Reviewed-by: tbell, ohair ! agent/sr

hg: jdk7/swing/corba: 6 new changesets

Changeset: a12ea7c7b497 Author:xdono Date: 2009-07-28 12:12 -0700 URL: http://hg.openjdk.java.net/jdk7/swing/corba/rev/a12ea7c7b497 6862919: Update copyright year Summary: Update copyright for files that have been modified in 2009, up to 07/09 Reviewed-by: tbell, ohair ! make/Makef

hg: jdk7/swing: 6 new changesets

Changeset: c4523c6f8204 Author:xdono Date: 2009-07-28 12:12 -0700 URL: http://hg.openjdk.java.net/jdk7/swing/rev/c4523c6f8204 6862919: Update copyright year Summary: Update copyright for files that have been modified in 2009, up to 07/09 Reviewed-by: tbell, ohair ! make/deploy-rule

hg: jdk7/swing/langtools: 3 new changesets

Changeset: 7e0056ded28c Author:xdono Date: 2009-07-13 14:48 -0700 URL: http://hg.openjdk.java.net/jdk7/swing/langtools/rev/7e0056ded28c Added tag jdk7-b64 for changeset d8f23a81d46f ! .hgtags Changeset: 634f519d6f9a Author:xdono Date: 2009-07-16 10:53 -0700 URL: htt

hg: jdk7/swing/jdk: 34 new changesets

Changeset: 382a27aa78d3 Author:xdono Date: 2009-07-13 14:47 -0700 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/382a27aa78d3 Added tag jdk7-b64 for changeset a50217eb3ee1 ! .hgtags Changeset: 6ec0174d4f36 Author:xdono Date: 2009-07-16 10:53 -0700 URL: http://hg

hg: jdk7/swing/jaxws: 3 new changesets

Changeset: aa22a1be5866 Author:xdono Date: 2009-07-13 14:47 -0700 URL: http://hg.openjdk.java.net/jdk7/swing/jaxws/rev/aa22a1be5866 Added tag jdk7-b64 for changeset aaa25dfd3de6 ! .hgtags Changeset: fa8712c099ed Author:xdono Date: 2009-07-16 10:53 -0700 URL: http://

hg: jdk7/swing/jaxp: 3 new changesets

Changeset: 008c662e0ee9 Author:xdono Date: 2009-07-13 14:47 -0700 URL: http://hg.openjdk.java.net/jdk7/swing/jaxp/rev/008c662e0ee9 Added tag jdk7-b64 for changeset a10eec7a1edf ! .hgtags Changeset: 22f9d5d5b5fe Author:xdono Date: 2009-07-16 10:53 -0700 URL: http://h

hg: jdk7/swing/hotspot: 28 new changesets

Changeset: 92b5fbbe8477 Author:xdono Date: 2009-07-13 14:47 -0700 URL: http://hg.openjdk.java.net/jdk7/swing/hotspot/rev/92b5fbbe8477 Added tag jdk7-b64 for changeset ba36394eb84b ! .hgtags Changeset: 45c4b1fe45e4 Author:trims Date: 2009-07-10 19:10 -0700 URL: http:

hg: jdk7/swing/corba: 3 new changesets

Changeset: 97fd9b42f5c2 Author:xdono Date: 2009-07-13 14:47 -0700 URL: http://hg.openjdk.java.net/jdk7/swing/corba/rev/97fd9b42f5c2 Added tag jdk7-b64 for changeset 047dd27fddb6 ! .hgtags Changeset: a821e059a961 Author:xdono Date: 2009-07-16 10:53 -0700 URL: http://

hg: jdk7/swing: 7 new changesets

Changeset: d92b13b3c138 Author:xdono Date: 2009-07-13 14:47 -0700 URL: http://hg.openjdk.java.net/jdk7/swing/rev/d92b13b3c138 Added tag jdk7-b64 for changeset 269c1ec4435d ! .hgtags Changeset: 8ca3d95b1ea3 Author:xdono Date: 2009-06-22 10:13 -0700 URL: http://hg.ope

hg: jdk7/swing/langtools: 24 new changesets

Changeset: 5c2c81120555 Author:xdono Date: 2009-06-25 12:10 -0700 URL: http://hg.openjdk.java.net/jdk7/swing/langtools/rev/5c2c81120555 Added tag jdk7-b62 for changeset 6855e5aa3348 ! .hgtags Changeset: 619c768ad104 Author:xdono Date: 2009-07-02 11:11 -0700 URL: htt

hg: jdk7/swing/jdk: 78 new changesets

Changeset: 8905d218cd0d Author:xdono Date: 2009-06-25 12:10 -0700 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/8905d218cd0d Added tag jdk7-b62 for changeset 12e11fab9a83 ! .hgtags Changeset: 9cf4ef04d9a7 Author:prr Date: 2009-05-06 14:14 -0700 URL: http://hg.o

hg: jdk7/swing/jaxws: 2 new changesets

Changeset: b8a6e883c0a6 Author:xdono Date: 2009-06-25 12:09 -0700 URL: http://hg.openjdk.java.net/jdk7/swing/jaxws/rev/b8a6e883c0a6 Added tag jdk7-b62 for changeset 75c801c13ea1 ! .hgtags Changeset: aaa25dfd3de6 Author:xdono Date: 2009-07-02 11:10 -0700 URL: http://

hg: jdk7/swing/jaxp: 2 new changesets

Changeset: ae449e9c04c1 Author:xdono Date: 2009-06-25 12:09 -0700 URL: http://hg.openjdk.java.net/jdk7/swing/jaxp/rev/ae449e9c04c1 Added tag jdk7-b62 for changeset a97dd57a6260 ! .hgtags Changeset: a10eec7a1edf Author:xdono Date: 2009-07-02 11:10 -0700 URL: http://h

hg: jdk7/swing/hotspot: 11 new changesets

Changeset: 8754a3c37762 Author:xdono Date: 2009-06-25 12:09 -0700 URL: http://hg.openjdk.java.net/jdk7/swing/hotspot/rev/8754a3c37762 Added tag jdk7-b62 for changeset a88386380bda ! .hgtags Changeset: 821269eca479 Author:ysr Date: 2009-06-11 12:40 -0700 URL: http://

hg: jdk7/swing/corba: 9 new changesets

Changeset: d20e45cd539f Author:xdono Date: 2009-06-25 12:09 -0700 URL: http://hg.openjdk.java.net/jdk7/swing/corba/rev/d20e45cd539f Added tag jdk7-b62 for changeset 65b66117dbd7 ! .hgtags Changeset: b3ad991d9534 Author:xdono Date: 2009-07-02 11:10 -0700 URL: http://

  1   2   >