Re: [12] JDK-6849922: java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.html fails

2018-11-14 Thread Shashidhara Veerabhadraiah
Thank you Krishna and Sergey for the review. -Original Message- From: Sergey Bylokhov Sent: Thursday, November 15, 2018 3:13 AM To: Shashidhara Veerabhadraiah ; Krishna Addepalli ; swing-dev@openjdk.java.net; awt-...@openjdk.java.net Subject: Re: [12] JDK-6849922: java/awt/Choice

Re: [12] JDK-6849922: java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.html fails

2018-11-14 Thread Sergey Bylokhov
Looks fine. -- Best regards, Sergey.

Re: [12] JDK-6849922: java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.html fails

2018-11-08 Thread Shashidhara Veerabhadraiah
@openjdk.java.net; awt-...@openjdk.java.net Subject: Re: [12] JDK-6849922: java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.html fails Hi, Shashi. A few notes: - I just found that you replaced the Applet by the JFrame. The fist is a AWT component which could be used on any threads, the

Re: [12] JDK-6849922: java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.html fails

2018-11-06 Thread Sergey Bylokhov
call with delay. You may choose to add delay in addition to waitForIdle. 3. Minor nit: replace () -> createAndShowGUI() with method reference. Thanks, Krishna -Original Message- From: Shashidhara Veerabhadraiah Sent: Wednesday, October 31, 2018 3:34 PM To: swing-dev@openjdk.java.net;

Re: [12] JDK-6849922: java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.html fails

2018-11-04 Thread shashidhara . veerabhadraiah
849922: java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.html fails Hi All, Please review test fix for the below bug. Bug: https://bugs.openjdk.java.net/browse/JDK-6849922 Webrev: http://cr.openjdk.java.net/~sveerabhadra/6849922/webrev.02/ Fix: As the initial bug analysis said in the

Re: [12] JDK-6849922: java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.html fails

2018-10-31 Thread Sergey Bylokhov
ober 31, 2018 3:34 PM To: swing-dev@openjdk.java.net; awt-...@openjdk.java.net Subject: [12] JDK-6849922: java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.html fails Hi All, Please review test fix for the below bug. Bug: https://bugs.openjdk.java.net/browse/JDK-6849922

Re: [12] JDK-6849922: java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.html fails

2018-10-31 Thread Krishna Addepalli
ginal Message- From: Shashidhara Veerabhadraiah Sent: Wednesday, October 31, 2018 3:34 PM To: swing-dev@openjdk.java.net; awt-...@openjdk.java.net Subject: [12] JDK-6849922: java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.html fails Hi All, Please review test fix for the below bug

[12] JDK-6849922: java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.html fails

2018-10-31 Thread shashidhara . veerabhadraiah
Hi All, Please review test fix for the below bug. Bug: https://bugs.openjdk.java.net/browse/JDK-6849922 Webrev: http://cr.openjdk.java.net/~sveerabhadra/6849922/webrev.02/ Fix: As the initial bug analysis said in the bug comments, it is a timing issue where in the choice menu remains opened ev