Ok. +1
-phil.
On 3/27/19, 10:01 PM, Prasanta Sadhukhan wrote:
Nothing specific. It was there in reproducer test in JBS and also to
make sure the test can be run in standalone mode and not only via jtreg.
Regards
Prasanta
On 27-Mar-19 9:33 PM, Phil Race wrote:
The product code change looks fin
Nothing specific. It was there in reproducer test in JBS and also to
make sure the test can be run in standalone mode and not only via jtreg.
Regards
Prasanta
On 27-Mar-19 9:33 PM, Phil Race wrote:
The product code change looks fine. I didn't examine the test
super-closely but
I am curious why
Looks fine.
On 26/03/2019 22:25, Prasanta Sadhukhan wrote:
OK. Modified webrev
http://cr.openjdk.java.net/~psadhukhan/8212904/webrev.2/
Regards
Prasanta
On 27-Mar-19 2:25 AM, Sergey Bylokhov wrote:
Hi, Prasanta.
The "textArea.getHeight()" should be called on EDT, since this is a swing
compo
The product code change looks fine. I didn't examine the test
super-closely but
I am curious why you used System.setProperty("sun.java2d.uiScale", "1.25" )
instead of setting it on the command line ?
-phil.
On 3/26/19 10:25 PM, Prasanta Sadhukhan wrote:
OK. Modified webrev
http://cr.openjdk.j
OK. Modified webrev
http://cr.openjdk.java.net/~psadhukhan/8212904/webrev.2/
Regards
Prasanta
On 27-Mar-19 2:25 AM, Sergey Bylokhov wrote:
Hi, Prasanta.
The "textArea.getHeight()" should be called on EDT, since this is a
swing component.
On 25/03/2019 22:01, Prasanta Sadhukhan wrote:
Thanks
Hi, Prasanta.
The "textArea.getHeight()" should be called on EDT, since this is a swing
component.
On 25/03/2019 22:01, Prasanta Sadhukhan wrote:
Thanks Sergey for the pointer. Modified test to be automated in the webrev
http://cr.openjdk.java.net/~psadhukhan/8212904/webrev.1/
Regards
Prasan
Thanks Sergey for the pointer. Modified test to be automated in the webrev
http://cr.openjdk.java.net/~psadhukhan/8212904/webrev.1/
Regards
Prasanta
On 26-Mar-19 12:02 AM, Sergey Bylokhov wrote:
On 25/03/2019 02:05, Prasanta Sadhukhan wrote:
Thanks Sergey for the pointer. But horizontal scrollb
On 25/03/2019 02:05, Prasanta Sadhukhan wrote:
Thanks Sergey for the pointer. But horizontal scrollbar is not visible for both
correct and broken wrap if scrollbar policy is set to
HORIZONTAL_SCROLLBAR_AS_NEEDED.
Also, the textArea.getHeight() is same for both textArea.setWrapStyleWord( true
)
On 23-Mar-19 5:02 AM, Sergey Bylokhov wrote:
On 21/03/2019 22:34, Prasanta Sadhukhan wrote:
Thanks for your review. textarea.getLineCount() returns same number
for both correct and broken wrap so it cannot be used for test
automation...
Then probably it can be checked by the visibility of t
On 21/03/2019 22:34, Prasanta Sadhukhan wrote:
Thanks for your review. textarea.getLineCount() returns same number for both
correct and broken wrap so it cannot be used for test automation...
Then probably it can be checked by the visibility of the horizontal scroll bar?
If you set the scrollb
Hi Sergey,
Thanks for your review. textarea.getLineCount() returns same number for
both correct and broken wrap so it cannot be used for test automation...
Regards
Prasanta
On 21-Mar-19 4:24 AM, Sergey Bylokhov wrote:
Hi, Prasanta.
The change looks fine, but probably the test can be automate
Hi, Prasanta.
The change looks fine, but probably the test can be automated? I guess when "wrap" works
properly you should get more lines in the text area, than in case of broken "wrap"?
On 19/03/2019 00:03, Prasanta Sadhukhan wrote:
Hi All,
Please review a fix for an issue where it is seen t
Hi All,
Please review a fix for an issue where it is seen that
line wrapping of JTextArea doen't work correctly if you set
wrapStyleWord = true and you use a UI scale (either by setting
"sun.java2d.uiScale" or by setting display scale of Windows)
It is a regression of JDK-8132119: Provide pub
13 matches
Mail list logo
