Re: [8] Review request for 8023392: Swing text components printed with spaces between chars

2013-09-05 Thread Alexander Potochkin
Hello Anton Looks good alexp Hello, here is the new webrev (including manual regression test and proposed changes): http://cr.openjdk.java.net/~dmarkov/8023392/webrev.01/ . Could you please review it? Thanks! Anton. On 26.08

Re: [8] Review request for 8023392: Swing text components printed with spaces between chars

2013-08-27 Thread Alexandr Scherbatiy
The fix looks good for me. Thanks, Alexandr. 26.08.2013 20:46, anton nashatyrev пишет: Hello, here is the new webrev (including manual regression test and proposed changes): http://cr.openjdk.java.net/~dmarkov/8023392/webrev.01/

Re: [8] Review request for 8023392: Swing text components printed with spaces between chars

2013-08-26 Thread anton nashatyrev
Hello, here is the new webrev (including manual regression test and proposed changes): http://cr.openjdk.java.net/~dmarkov/8023392/webrev.01/ . Could you please review it? Thanks! Anton. On 26.08.2013 17:27, Alexander Scherbatiy

Re: [8] Review request for 8023392: Swing text components printed with spaces between chars

2013-08-26 Thread Alexander Scherbatiy
On 8/26/2013 4:41 PM, anton nashatyrev wrote: Hello Alexander, On 26.08.2013 16:05, Alexander Scherbatiy wrote: I see that SwingUtilities2.drawString(..) and SwingUtilities2.drawChars(...) are used a lot in the Swing but the issue is only about printing. Could removing trailing spaces in t

Re: [8] Review request for 8023392: Swing text components printed with spaces between chars

2013-08-26 Thread anton nashatyrev
Hello Alexander, On 26.08.2013 16:05, Alexander Scherbatiy wrote: I see that SwingUtilities2.drawString(..) and SwingUtilities2.drawChars(...) are used a lot in the Swing but the issue is only about printing. Could removing trailing spaces in these methods affect other non-printed componen

Re: [8] Review request for 8023392: Swing text components printed with spaces between chars

2013-08-26 Thread Alexander Scherbatiy
I see that SwingUtilities2.drawString(..) and SwingUtilities2.drawChars(...) are used a lot in the Swing but the issue is only about printing. Could removing trailing spaces in these methods affect other non-printed components? Is it possible to add a test for the fix? Thanks, Al

[8] Review request for 8023392: Swing text components printed with spaces between chars

2013-08-22 Thread anton nashatyrev
Hello, could you please review the following fix: fix: http://cr.openjdk.java.net/~vkarnauk/8023392/jdk8/webrev.00/ bug: http://bugs.sun.com/view_bug.do?bug_id=80223392 (the bug is still not replicated here, so internal link m