Re: [9] Fix for JDK-6567433 : JComponent.updateUI() may create StackOverflowError

2016-07-12 Thread Alexandr Scherbatiy
: Friday, July 08, 2016 10:32 AM To: Andrej Golovnin Cc: Rajeev Chamyal; Alexander Scherbatiy; swing-dev@openjdk.java.net Subject: RE: [9] Fix for JDK-6567433 : JComponent.updateUI() may create StackOverflowError Hi Andrej, Thanks for your suggestion. I have made the 'updateInProgress

Re: [9] Fix for JDK-6567433 : JComponent.updateUI() may create StackOverflowError

2016-07-12 Thread Andrej Golovnin
Chamyal; Alexander Scherbatiy; swing-dev@openjdk.java.net > Subject: RE: [9] Fix for JDK-6567433 : JComponent.updateUI() may create > StackOverflowError > > Hi Andrej, > > Thanks for your suggestion. > > I have made the 'updateInProgress' member of these classes

Re: [9] Fix for JDK-6567433 : JComponent.updateUI() may create StackOverflowError

2016-07-12 Thread Ajit Ghaisas
: Rajeev Chamyal; Alexander Scherbatiy; swing-dev@openjdk.java.net Subject: Re: [9] Fix for JDK-6567433 : JComponent.updateUI() may create StackOverflowError Hi Ajit, one more thing that I have just noticed: /** * Flag to indicate UI update is in progress */ private boolean updateInProgress

Re: [9] Fix for JDK-6567433 : JComponent.updateUI() may create StackOverflowError

2016-07-07 Thread Andrej Golovnin
Hi Ajit, one more thing that I have just noticed: /** * Flag to indicate UI update is in progress */ private boolean updateInProgress; I think the field must be transient. In Swing every component is serializable. When updateInProgress is set to true and you serialize/deserialize the

Re: [9] Fix for JDK-6567433 : JComponent.updateUI() may create StackOverflowError

2016-07-07 Thread Ajit Ghaisas
; swing-dev@openjdk.java.net Subject: RE: [9] Fix for JDK-6567433 : JComponent.updateUI() may create StackOverflowError Hello Ajit, The fix looks fine to me. Regarding test: JTable and JTree tests exceed 80 char limit. Regards, Rajeev Chamyal From: Alexandr Scherbatiy Sent: 07 July

Re: [9] Fix for JDK-6567433 : JComponent.updateUI() may create StackOverflowError

2016-07-07 Thread Rajeev Chamyal
k.java.net/~aghaisas/6567433/webrev.01/ Regards, Ajit From: Alexandr Scherbatiy Sent: Tuesday, July 05, 2016 5:55 PM To: Ajit Ghaisas; Rajeev Chamyal; HYPERLINK "mailto:swing-dev@openjdk.java.net"swing-dev@openjdk.java.net Subject: Re: [9] Fix for JDK-6567433 : JComponent.u

Re: [9] Fix for JDK-6567433 : JComponent.updateUI() may create StackOverflowError

2016-07-07 Thread Alexandr Scherbatiy
rbatiy *Sent:* Tuesday, July 05, 2016 5:55 PM *To:* Ajit Ghaisas; Rajeev Chamyal; swing-dev@openjdk.java.net *Subject:* Re: [9] Fix for JDK-6567433 : JComponent.updateUI() may create StackOverflowError On 7/5/2016 2:51 PM, Ajit Ghaisas wrote: Hi, Bug : https://bugs.openjdk.ja

Re: [9] Fix for JDK-6567433 : JComponent.updateUI() may create StackOverflowError

2016-07-07 Thread Ajit Ghaisas
-6567433 : JComponent.updateUI() may create StackOverflowError On 7/5/2016 2:51 PM, Ajit Ghaisas wrote: Hi, Bug : https://bugs.openjdk.java.net/browse/JDK-6567433 Calling updateUI() on JList, JComboBox and JTableHeader can create StackOverflowErrors. For example

Re: [9] Fix for JDK-6567433 : JComponent.updateUI() may create StackOverflowError

2016-07-05 Thread Alexandr Scherbatiy
On 7/5/2016 2:51 PM, Ajit Ghaisas wrote: Hi, Bug : https://bugs.openjdk.java.net/browse/JDK-6567433 Calling updateUI() on JList, JComboBox and JTableHeader can create StackOverflowErrors. For example - JList.updateUI() invokes updateUI() on its Cellrenderer via

[9] Fix for JDK-6567433 : JComponent.updateUI() may create StackOverflowError

2016-07-05 Thread Ajit Ghaisas
Hi, Bug : https://bugs.openjdk.java.net/browse/JDK-6567433 Calling updateUI() on JList, JComboBox and JTableHeader can create StackOverflowErrors. For example - JList.updateUI() invokes updateUI() on its Cellrenderer via SwingUtilities.updateComponentTreeUI(). If