Re: [9] JDK-8169897: [PIT] javax/swing/plaf/basic/BasicGraphicsUtils/8132119/bug8132119.java fails

2017-05-09 Thread Alexandr Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 5/5/2017 7:56 AM, Prasanta Sadhukhan wrote: I have updated the fix to calculate "xx" (the x coordinate along which background changes willbe calculated from top to bottom of bufferedimage) to point to centre of "O" so that background change can c

Re: [9] JDK-8169897: [PIT] javax/swing/plaf/basic/BasicGraphicsUtils/8132119/bug8132119.java fails

2017-05-04 Thread Prasanta Sadhukhan
I have updated the fix to calculate "xx" (the x coordinate along which background changes willbe calculated from top to bottom of bufferedimage) to point to centre of "O" so that background change can clearly demarcate between O and underline. I also have increased the font size a bit to make su

Re: [9] JDK-8169897: [PIT] javax/swing/plaf/basic/BasicGraphicsUtils/8132119/bug8132119.java fails

2017-03-15 Thread Philip Race
This test sounds flaky and changing the font is clearly the wrong fix. -phil. On 3/14/17, 11:21 PM, Prasanta Sadhukhan wrote: On 3/14/2017 6:48 PM, Alexandr Scherbatiy wrote: On 3/14/2017 3:37 PM, Philip Race wrote: I am not sure why the test went to the trouble of looking for Arial. If the

Re: [9] JDK-8169897: [PIT] javax/swing/plaf/basic/BasicGraphicsUtils/8132119/bug8132119.java fails

2017-03-14 Thread Prasanta Sadhukhan
On 3/14/2017 6:48 PM, Alexandr Scherbatiy wrote: On 3/14/2017 3:37 PM, Philip Race wrote: I am not sure why the test went to the trouble of looking for Arial. If there was a good reason (Alexander ??) an alternative is to initialise The test tries to calculate number of intersection with le

Re: [9] JDK-8169897: [PIT] javax/swing/plaf/basic/BasicGraphicsUtils/8132119/bug8132119.java fails

2017-03-14 Thread Alexandr Scherbatiy
On 3/14/2017 3:37 PM, Philip Race wrote: I am not sure why the test went to the trouble of looking for Arial. If there was a good reason (Alexander ??) an alternative is to initialise The test tries to calculate number of intersection with letter O and its underline. It is sensitive to the pos

Re: [9] JDK-8169897: [PIT] javax/swing/plaf/basic/BasicGraphicsUtils/8132119/bug8132119.java fails

2017-03-14 Thread Philip Race
I am not sure why the test went to the trouble of looking for Arial. If there was a good reason (Alexander ??) an alternative is to initialise String fontName = "Serif". although swapping out Arial for Serif is a very odd choice. Arial is a Sans Serif font and Serif fonts are not usually used in

[9] JDK-8169897: [PIT] javax/swing/plaf/basic/BasicGraphicsUtils/8132119/bug8132119.java fails

2017-03-14 Thread Prasanta Sadhukhan
Hi All, Please review a testbug fix where the testcase is failing in linux because it is not able to find "Arial" font and tries to use the font found in 0th index of getAvailableFontFamilyNames() which is "Abyssinica SIL". Bug: https://bugs.openjdk.java.net/browse/JDK-8169897 webrev: http://