Re: [9] RFR JDK-8159068:The rendering of JTable is broken

2016-06-27 Thread Rajeev Chamyal
Looks good to me.   Regards, Rajeev Chamyal   From: Alexandr Scherbatiy Sent: 24 June 2016 17:01 To: Prasanta Sadhukhan; Rajeev Chamyal; swing-dev@openjdk.java.net Subject: Re: [9] RFR JDK-8159068:The rendering of JTable is broken   The fix looks good to me. Thanks, Alexandr. On 6/24

Re: [9] RFR JDK-8159068:The rendering of JTable is broken

2016-06-24 Thread Alexandr Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 6/24/2016 12:37 PM, Prasanta Sadhukhan wrote: On 6/24/2016 1:41 PM, Alexandr Scherbatiy wrote: On 6/24/2016 10:04 AM, Prasanta Sadhukhan wrote: Hi Alexandr, Thanks for your suggestion. Have modified as per the comment to decide based on sele

Re: [9] RFR JDK-8159068:The rendering of JTable is broken

2016-06-24 Thread Prasanta Sadhukhan
On 6/24/2016 1:41 PM, Alexandr Scherbatiy wrote: On 6/24/2016 10:04 AM, Prasanta Sadhukhan wrote: Hi Alexandr, Thanks for your suggestion. Have modified as per the comment to decide based on selected row. 8081491 testcase and SwingSet2 JTa

Re: [9] RFR JDK-8159068:The rendering of JTable is broken

2016-06-24 Thread Alexandr Scherbatiy
On 6/24/2016 10:04 AM, Prasanta Sadhukhan wrote: Hi Alexandr, Thanks for your suggestion. Have modified as per the comment to decide based on selected row. 8081491 testcase and SwingSet2 JTable demo works. Please review modified webrev: http

Re: [9] RFR JDK-8159068:The rendering of JTable is broken

2016-06-24 Thread Prasanta Sadhukhan
Hi Alexandr, Thanks for your suggestion. Have modified as per the comment to decide based on selected row. 8081491 testcase and SwingSet2 JTable demo works. Please review modified webrev: http://cr.openjdk.java.net/~psadhukhan/8159068/webrev.

Re: [9] RFR JDK-8159068:The rendering of JTable is broken

2016-06-23 Thread Alexandr Scherbatiy
On 6/23/2016 9:53 AM, Prasanta Sadhukhan wrote: On 6/23/2016 12:10 PM, Alexandr Scherbatiy wrote: On 6/21/2016 2:57 PM, Prasanta Sadhukhan wrote: On 6/21/2016 5:16 PM, Alexandr Scherbatiy wrote: On 6/21/2016 1:58 PM, Prasanta Sadhukhan wrote: On 6/21/2016 4:14 PM, Alexandr Scherbatiy wrot

Re: [9] RFR JDK-8159068:The rendering of JTable is broken

2016-06-22 Thread Prasanta Sadhukhan
On 6/23/2016 12:10 PM, Alexandr Scherbatiy wrote: On 6/21/2016 2:57 PM, Prasanta Sadhukhan wrote: On 6/21/2016 5:16 PM, Alexandr Scherbatiy wrote: On 6/21/2016 1:58 PM, Prasanta Sadhukhan wrote: On 6/21/2016 4:14 PM, Alexandr Scherbatiy wrote: On 6/20/2016 8:10 AM, prasanta sadhukhan wrot

Re: [9] RFR JDK-8159068:The rendering of JTable is broken

2016-06-22 Thread Alexandr Scherbatiy
On 6/21/2016 2:57 PM, Prasanta Sadhukhan wrote: On 6/21/2016 5:16 PM, Alexandr Scherbatiy wrote: On 6/21/2016 1:58 PM, Prasanta Sadhukhan wrote: On 6/21/2016 4:14 PM, Alexandr Scherbatiy wrote: On 6/20/2016 8:10 AM, prasanta sadhukhan wrote: Gentle reminder for review!! Regards Prasanta O

Re: [9] RFR JDK-8159068:The rendering of JTable is broken

2016-06-21 Thread Prasanta Sadhukhan
On 6/21/2016 5:16 PM, Alexandr Scherbatiy wrote: On 6/21/2016 1:58 PM, Prasanta Sadhukhan wrote: On 6/21/2016 4:14 PM, Alexandr Scherbatiy wrote: On 6/20/2016 8:10 AM, prasanta sadhukhan wrote: Gentle reminder for review!! Regards Prasanta On 6/13/2016 4:31 PM, prasanta sadhukhan wrote:

Re: [9] RFR JDK-8159068:The rendering of JTable is broken

2016-06-21 Thread Alexandr Scherbatiy
On 6/21/2016 1:58 PM, Prasanta Sadhukhan wrote: On 6/21/2016 4:14 PM, Alexandr Scherbatiy wrote: On 6/20/2016 8:10 AM, prasanta sadhukhan wrote: Gentle reminder for review!! Regards Prasanta On 6/13/2016 4:31 PM, prasanta sadhukhan wrote: On 6/13/2016 12:51 PM, prasanta sadhukhan wrote: H

Re: [9] RFR JDK-8159068:The rendering of JTable is broken

2016-06-21 Thread Prasanta Sadhukhan
On 6/21/2016 4:14 PM, Alexandr Scherbatiy wrote: On 6/20/2016 8:10 AM, prasanta sadhukhan wrote: Gentle reminder for review!! Regards Prasanta On 6/13/2016 4:31 PM, prasanta sadhukhan wrote: On 6/13/2016 12:51 PM, prasanta sadhukhan wrote: Hi All, Please review a fix for jdk9 where it was

Re: [9] RFR JDK-8159068:The rendering of JTable is broken

2016-06-21 Thread Alexandr Scherbatiy
On 6/20/2016 8:10 AM, prasanta sadhukhan wrote: Gentle reminder for review!! Regards Prasanta On 6/13/2016 4:31 PM, prasanta sadhukhan wrote: On 6/13/2016 12:51 PM, prasanta sadhukhan wrote: Hi All, Please review a fix for jdk9 where it was seen that if we try to select some rows in a JTabl

Re: [9] RFR JDK-8159068:The rendering of JTable is broken

2016-06-19 Thread prasanta sadhukhan
Gentle reminder for review!! Regards Prasanta On 6/13/2016 4:31 PM, prasanta sadhukhan wrote: On 6/13/2016 12:51 PM, prasanta sadhukhan wrote: Hi All, Please review a fix for jdk9 where it was seen that if we try to select some rows in a JTable, the text painted in the rows goes missing.

Re: [9] RFR JDK-8159068:The rendering of JTable is broken

2016-06-14 Thread prasanta sadhukhan
Gentle reminder for review. Regards Prasanta On 6/13/2016 4:31 PM, prasanta sadhukhan wrote: On 6/13/2016 12:51 PM, prasanta sadhukhan wrote: Hi All, Please review a fix for jdk9 where it was seen that if we try to select some rows in a JTable, the text painted in the rows goes missing.

Re: [9] RFR JDK-8159068:The rendering of JTable is broken

2016-06-13 Thread prasanta sadhukhan
On 6/13/2016 12:51 PM, prasanta sadhukhan wrote: Hi All, Please review a fix for jdk9 where it was seen that if we try to select some rows in a JTable, the text painted in the rows goes missing. Bug: https://bugs.openjdk.java.net/browse/JDK-8159068 webrev: http://cr.openjdk.java.net/~psadh

[9] RFR JDK-8159068:The rendering of JTable is broken

2016-06-13 Thread prasanta sadhukhan
Hi All, Please review a fix for jdk9 where it was seen that if we try to select some rows in a JTable, the text painted in the rows goes missing. Bug: https://bugs.openjdk.java.net/browse/JDK-8159068 webrev: http://cr.openjdk.java.net/~psadhukhan/8159068/webrev.00/ The issue was rMax value w