Re: [9] Review Request: 8055326 Fix typos in client-related packages

2014-09-15 Thread Phil Race
approved. -phil. On 9/10/2014 5:11 AM, Sergey Bylokhov wrote: Hi, Phil. It seems both changes are unnecessary: http://cr.openjdk.java.net/~serb/8055326/webrev.01 On 21.08.2014 22:04, Phil Race wrote: Was the additional spce on the 2nd line intended here ? --- old/src/java.desktop/share/clas

Re: [9] Review Request: 8055326 Fix typos in client-related packages

2014-09-15 Thread Alexander Zvegintsev
Hello Sergey, The fix looks good to me in general, but I have a few comments: It would be nice to add @Override annotation to java.awt.Window.adjustDescendantsOnParent() --- old/src/java.desktop/share/classes/java/awt/Component.java 2014-09-10 15:11:22.601342000 +0400 +++ new/src/java.deskt

Re: [9] Review Request: 8055326 Fix typos in client-related packages

2014-09-15 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 9/10/2014 4:11 PM, Sergey Bylokhov wrote: Hi, Phil. It seems both changes are unnecessary: http://cr.openjdk.java.net/~serb/8055326/webrev.01 On 21.08.2014 22:04, Phil Race wrote: Was the additional spce on the 2nd line intended here ? --

Re: [9] Review Request: 8055326 Fix typos in client-related packages

2014-09-10 Thread Sergey Bylokhov
Hi, Phil. It seems both changes are unnecessary: http://cr.openjdk.java.net/~serb/8055326/webrev.01 On 21.08.2014 22:04, Phil Race wrote: Was the additional spce on the 2nd line intended here ? --- old/src/java.desktop/share/classes/java/awt/ContainerOrderFocusTraversalPolicy.java 2014-08-21