I verified that this doesn't break JavaFX Swing interop (specifically
Drag and Drop), so it looks fine to me.
-- Kevin
Sergey Bylokhov wrote:
The new version of the fix:
http://cr.openjdk.java.net/~serb/8074028/webrev.06
Font.getPeer() was renamed to Font.getFontPeer().
On 04.03.2015 15:51,
Looks fine (I just looked at the getFontPeer() this time around.
Pls remember to do a CCC before pushing this !
-phil.
On 03/05/2015 04:51 AM, Sergey Bylokhov wrote:
The new version of the fix:
http://cr.openjdk.java.net/~serb/8074028/webrev.06
Font.getPeer() was renamed to Font.getFontPeer().
Thanks for the check, Kevin!
Anton.
On 06/03/15 02:13, Kevin Rushforth wrote:
I verified that this doesn't break JavaFX Swing interop (specifically
Drag and Drop), so it looks fine to me.
-- Kevin
Sergey Bylokhov wrote:
The new version of the fix:
http://cr.openjdk.java.net/~serb/8074028/w
Hi Sergey,
Looks good to me.
Thanks,
Anton.
On 04/03/15 15:37, Sergey Bylokhov wrote:
Hello.
Please review the fix for jdk 9.
There are a number of public API whichreference the unsupported
java.awt.peer interfaces.
public java.awt.Component.getPeer() @deprecated 1.1
public java.awt.Font.ge
On 05/03/2015 12:51, Sergey Bylokhov wrote:
The new version of the fix:
http://cr.openjdk.java.net/~serb/8074028/webrev.06
Font.getPeer() was renamed to Font.getFontPeer().
This part looks good to me. I assume someone working in this area will
give the rest of the changes a thorough review.
-
The new version of the fix:
http://cr.openjdk.java.net/~serb/8074028/webrev.06
Font.getPeer() was renamed to Font.getFontPeer().
On 04.03.2015 15:51, Alan Bateman wrote:
On 04/03/2015 12:37, Sergey Bylokhov wrote:
Hello.
Please review the fix for jdk 9.
There are a number of public API whichre
Looks good to me. I like some of the clean up like :
-if (getPeer() == null) {
+if (!isDisplayable()) {
which is the same as we've told other folks to do ..
I was initially surprised at just using the field "peer" as it might
be null, but getPeer() just returned "peer" anyway, s
On 04/03/15 15:37, Sergey Bylokhov wrote:
http://cr.openjdk.java.net/~serb/8074028/webrev.05/src/java.desktop/share/classes/java/awt/MenuComponent.java.sdiff.html
What's the point of ComponentPeer peer = this.peer; ?
Why not just use peer as in other places in this file?
Thanks,
Vadim
On 03/04/2015 04:35 PM, Sergey Bylokhov wrote:
On 04.03.2015 15:51, Alan Bateman wrote:
On 04/03/2015 12:37, Sergey Bylokhov wrote:
Hello.
Please review the fix for jdk 9.
There are a number of public API whichreference the unsupported
java.awt.peer interfaces.
public java.awt.Component.getPee
On 04/03/2015 12:37, Sergey Bylokhov wrote:
Hello.
Please review the fix for jdk 9.
There are a number of public API whichreference the unsupported
java.awt.peer interfaces.
public java.awt.Component.getPeer() @deprecated 1.1
public java.awt.Font.getPeer() @deprecated 1.1
public java.awt.MenuC
On 04.03.2015 15:51, Alan Bateman wrote:
On 04/03/2015 12:37, Sergey Bylokhov wrote:
Hello.
Please review the fix for jdk 9.
There are a number of public API whichreference the unsupported
java.awt.peer interfaces.
public java.awt.Component.getPeer() @deprecated 1.1
public java.awt.Font.getPe
Hello.
Please review the fix for jdk 9.
There are a number of public API whichreference the unsupported
java.awt.peer interfaces.
public java.awt.Component.getPeer() @deprecated 1.1
public java.awt.Font.getPeer() @deprecated 1.1
public java.awt.MenuComponent.getPeer() @deprecated 1.1
There is
12 matches
Mail list logo
