Re: [9] Review request for 8044371: setOneTouchExpandable functionality of JSplitPane will reduce vertical Scrollbar

2014-07-03 Thread Alexander Potochkin
Hello Anton Looks good alexp On 6/24/2014 8:31 PM, anton nashatyrev wrote: Hello, could you please review the following fix: fix: http://cr.openjdk.java.net/~anashaty/8044371/9/webrev.00/ bug: https://bugs.openjdk.java.net/bro

Re: [9] Review request for 8044371: setOneTouchExpandable functionality of JSplitPane will reduce vertical Scrollbar

2014-07-02 Thread anton nashatyrev
Hi Alexander, thanks for review! is there another volunteer? Thanks! Anton. On 25.06.2014 18:23, Alexander Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 6/25/2014 5:36 PM, anton nashatyrev wrote: Hi Alexander, this works on the current testcase. What m

Re: [9] Review request for 8044371: setOneTouchExpandable functionality of JSplitPane will reduce vertical Scrollbar

2014-06-25 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 6/25/2014 5:36 PM, anton nashatyrev wrote: Hi Alexander, this works on the current testcase. What makes me more confident is that before the fix JDK-4502121 a negative dimension was also possible and the methods you mentioned migh

Re: [9] Review request for 8044371: setOneTouchExpandable functionality of JSplitPane will reduce vertical Scrollbar

2014-06-25 Thread anton nashatyrev
Hi Alexander, this works on the current testcase. What makes me more confident is that before the fix JDK-4502121 a negative dimension was also possible and the methods you mentioned might be called with such values. It seems the class didn't changed dramatically since that time. Tha

Re: [9] Review request for 8044371: setOneTouchExpandable functionality of JSplitPane will reduce vertical Scrollbar

2014-06-25 Thread Alexander Scherbatiy
Removing isEmpty variable checking logic leads that some methods (adjustForVSB(...), viewport.toViewCoordinates(...)) could use a rectangle with negative sizes. Do these methods work properly in this case? Thanks, Alexandr. On 6/24/2014 8:31 PM, anton nashatyrev wrote: Hello, could

[9] Review request for 8044371: setOneTouchExpandable functionality of JSplitPane will reduce vertical Scrollbar

2014-06-24 Thread anton nashatyrev
Hello, could you please review the following fix: fix: http://cr.openjdk.java.net/~anashaty/8044371/9/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8044371 Problem: After the ScrollPane which is scrolled to the bo