On 02.06.16 18:46, Semyon Sadetsky wrote:
On 6/2/2016 12:45 PM, Sergey Bylokhov wrote:
There is a tiny typo in the specification:
34 * {@code InputVerifier} and, using {@code> JComponent}'s
Is ">" inside {@code } necessary here?
yes it is typo.
Don't you mind if I remove this upon the push
On 6/2/2016 12:45 PM, Sergey Bylokhov wrote:
There is a tiny typo in the specification:
34 * {@code InputVerifier} and, using {@code> JComponent}'s
Is ">" inside {@code } necessary here?
yes it is typo.
Don't you mind if I remove this upon the push to avoid a new review
iteration?
The fix looks good to me.
Thanks,
Alexandr.
On 6/1/2016 7:46 PM, Philip Race wrote:
+1
-phil.
On 6/1/16, 12:18 AM, Semyon Sadetsky wrote:
Please the corrected webrev:
http://cr.openjdk.java.net/~ssadetsky/8154431/webrev.03/
Also the CCC request was updated.
--Semyon
On 5/31/2016
+1
-phil.
On 6/1/16, 12:18 AM, Semyon Sadetsky wrote:
Please the corrected webrev:
http://cr.openjdk.java.net/~ssadetsky/8154431/webrev.03/
Also the CCC request was updated.
--Semyon
On 5/31/2016 10:23 PM, Phil Race wrote:
The {@code InputVerifier} also provides possibility to validate
Please the corrected webrev:
http://cr.openjdk.java.net/~ssadetsky/8154431/webrev.03/
Also the CCC request was updated.
--Semyon
On 5/31/2016 10:23 PM, Phil Race wrote:
The {@code InputVerifier} also provides possibility to validate
against "provides the possibility" "the target of the focus
Hi,
If the design stays as proposed with separate verify() and
verifyTarget() calls, it needs to be carefully explained how these
must be co-ordinated by Swing + the app.
The class doc should be augmented with an example showing how to do
source+target verification.
As I previously noted (so
On 5/11/2016 12:17 AM, Phil Race wrote:
On 04/22/2016 01:11 AM, Semyon Sadetsky wrote:
Forget to attach the link:
http://cr.openjdk.java.net/~ssadetsky/8154431/webrev.01/
--Semyon
On 4/22/2016 11:08 AM, Semyon Sadetsky wrote:
Please review the updated webrev:
32 * need to ensure that
On 04/22/2016 01:11 AM, Semyon Sadetsky wrote:
Forget to attach the link:
http://cr.openjdk.java.net/~ssadetsky/8154431/webrev.01/
--Semyon
On 4/22/2016 11:08 AM, Semyon Sadetsky wrote:
Please review the updated webrev:
32 * need to ensure that the components are in valid state before
Forget to attach the link:
http://cr.openjdk.java.net/~ssadetsky/8154431/webrev.01/
--Semyon
On 4/22/2016 11:08 AM, Semyon Sadetsky wrote:
Please review the updated webrev:
The fix is updated according to the reviewers comments:
- the test was updated to check the target object and year typo
Please review the updated webrev:
The fix is updated according to the reviewers comments:
- the test was updated to check the target object and year typo was updated
- new shouldYieldFocus() javadoc improved
- @depricated documentation is added to the old shouldYieldFocus()
- Swing component
On 4/19/2016 10:41 PM, Phil Race wrote:
On 04/19/2016 11:05 AM, Semyon Sadetsky wrote:
On 4/19/2016 7:47 PM, Phil Race wrote:
Hi,
You are deprecating shouldYieldFocus(JComponent) and yet this class
directly uses it.
Is this deprecation really the right thing to do ?
Why is this not correct?
On 04/19/2016 11:05 AM, Semyon Sadetsky wrote:
On 4/19/2016 7:47 PM, Phil Race wrote:
Hi,
You are deprecating shouldYieldFocus(JComponent) and yet this class
directly uses it.
Is this deprecation really the right thing to do ?
Why is this not correct? There are plenty examples in JDK:
On 4/20/2016 12:11 AM, Phil Race wrote:
PS I see the class doc talks about shouldYieldFocus() being called,
so I don't understand the inter-relationship of that and verify(), but
it makes me no more sure that deprecating that method is right.
I deprecated shouldYieldFocus(JCopmponent) and added
PS I see the class doc talks about shouldYieldFocus() being called,
so I don't understand the inter-relationship of that and verify(), but
it makes me no more sure that deprecating that method is right.
I think perhaps verify() is all that the app is supposed to have over-ridden
and the comments
On 4/19/2016 7:47 PM, Phil Race wrote:
Hi,
You are deprecating shouldYieldFocus(JComponent) and yet this class
directly uses it.
Is this deprecation really the right thing to do ?
Why is this not correct? There are plenty examples in JDK:
Component#setVisible() & Component#show(),
Hi,
You are deprecating shouldYieldFocus(JComponent) and yet this class
directly uses it.
Is this deprecation really the right thing to do ?
The new over-loaded shouldYieldFocus() is perhaps not much more than a
utility.
And the doc says "calls verify(input)" which seems odd since you do
Hello,
Please review fix for JDK9:
bug: https://bugs.openjdk.java.net/browse/JDK-8154431
webrev: http://cr.openjdk.java.net/~ssadetsky/8154431/webrev.00/
The thing is the Swing validation doesn't allow to validate state of the
target component of input focus transfer operation.
To support that
17 matches
Mail list logo
