Re: [9] Review request for 8157065: There is no the focus border on the selected tab.

2016-10-05 Thread Semyon Sadetsky
On 10/4/2016 7:18 PM, Alexandr Scherbatiy wrote: On 10/3/2016 12:20 PM, Semyon Sadetsky wrote: On 9/21/2016 11:23 PM, Alexandr Scherbatiy wrote: On 9/20/2016 10:40 AM, Semyon Sadetsky wrote: On 9/20/2016 12:00 AM, Alexandr Scherbatiy wrote: On 9/14/2016 11:51 AM, Semyon Sadetsky wrote: On

Re: [9] Review request for 8157065: There is no the focus border on the selected tab.

2016-10-03 Thread Semyon Sadetsky
On 9/21/2016 11:23 PM, Alexandr Scherbatiy wrote: On 9/20/2016 10:40 AM, Semyon Sadetsky wrote: On 9/20/2016 12:00 AM, Alexandr Scherbatiy wrote: On 9/14/2016 11:51 AM, Semyon Sadetsky wrote: On 9/13/2016 9:03 PM, Alexandr Scherbatiy wrote: On 9/13/2016 8:49 PM, Semyon Sadetsky wrote: On

Re: [9] Review request for 8157065: There is no the focus border on the selected tab.

2016-09-21 Thread Alexandr Scherbatiy
On 9/20/2016 10:40 AM, Semyon Sadetsky wrote: On 9/20/2016 12:00 AM, Alexandr Scherbatiy wrote: On 9/14/2016 11:51 AM, Semyon Sadetsky wrote: On 9/13/2016 9:03 PM, Alexandr Scherbatiy wrote: On 9/13/2016 8:49 PM, Semyon Sadetsky wrote: On 9/13/2016 8:46 PM, Alexandr Scherbatiy wrote: On

Re: [9] Review request for 8157065: There is no the focus border on the selected tab.

2016-09-20 Thread Semyon Sadetsky
On 9/20/2016 12:00 AM, Alexandr Scherbatiy wrote: On 9/14/2016 11:51 AM, Semyon Sadetsky wrote: On 9/13/2016 9:03 PM, Alexandr Scherbatiy wrote: On 9/13/2016 8:49 PM, Semyon Sadetsky wrote: On 9/13/2016 8:46 PM, Alexandr Scherbatiy wrote: On 9/13/2016 8:34 PM, Semyon Sadetsky wrote: On

Re: [9] Review request for 8157065: There is no the focus border on the selected tab.

2016-09-19 Thread Alexandr Scherbatiy
On 9/14/2016 11:51 AM, Semyon Sadetsky wrote: On 9/13/2016 9:03 PM, Alexandr Scherbatiy wrote: On 9/13/2016 8:49 PM, Semyon Sadetsky wrote: On 9/13/2016 8:46 PM, Alexandr Scherbatiy wrote: On 9/13/2016 8:34 PM, Semyon Sadetsky wrote: On 9/13/2016 8:25 PM, Alexandr Scherbatiy wrote: On

Re: [9] Review request for 8157065: There is no the focus border on the selected tab.

2016-09-13 Thread Alexandr Scherbatiy
On 9/13/2016 8:49 PM, Semyon Sadetsky wrote: On 9/13/2016 8:46 PM, Alexandr Scherbatiy wrote: On 9/13/2016 8:34 PM, Semyon Sadetsky wrote: On 9/13/2016 8:25 PM, Alexandr Scherbatiy wrote: On 9/13/2016 7:38 PM, Semyon Sadetsky wrote: On 9/13/2016 7:21 PM, Alexandr Scherbatiy wrote: On

Re: [9] Review request for 8157065: There is no the focus border on the selected tab.

2016-09-13 Thread Semyon Sadetsky
On 9/13/2016 8:46 PM, Alexandr Scherbatiy wrote: On 9/13/2016 8:34 PM, Semyon Sadetsky wrote: On 9/13/2016 8:25 PM, Alexandr Scherbatiy wrote: On 9/13/2016 7:38 PM, Semyon Sadetsky wrote: On 9/13/2016 7:21 PM, Alexandr Scherbatiy wrote: On 9/12/2016 10:42 PM, Semyon Sadetsky wrote:

Re: [9] Review request for 8157065: There is no the focus border on the selected tab.

2016-09-13 Thread Alexandr Scherbatiy
On 9/13/2016 8:34 PM, Semyon Sadetsky wrote: On 9/13/2016 8:25 PM, Alexandr Scherbatiy wrote: On 9/13/2016 7:38 PM, Semyon Sadetsky wrote: On 9/13/2016 7:21 PM, Alexandr Scherbatiy wrote: On 9/12/2016 10:42 PM, Semyon Sadetsky wrote: On 9/12/2016 9:48 PM, Alexandr Scherbatiy wrote: On

Re: [9] Review request for 8157065: There is no the focus border on the selected tab.

2016-09-13 Thread Semyon Sadetsky
On 9/13/2016 8:25 PM, Alexandr Scherbatiy wrote: On 9/13/2016 7:38 PM, Semyon Sadetsky wrote: On 9/13/2016 7:21 PM, Alexandr Scherbatiy wrote: On 9/12/2016 10:42 PM, Semyon Sadetsky wrote: On 9/12/2016 9:48 PM, Alexandr Scherbatiy wrote: On 9/12/2016 7:52 PM, Semyon Sadetsky wrote: On

Re: [9] Review request for 8157065: There is no the focus border on the selected tab.

2016-09-13 Thread Alexandr Scherbatiy
On 9/13/2016 7:38 PM, Semyon Sadetsky wrote: On 9/13/2016 7:21 PM, Alexandr Scherbatiy wrote: On 9/12/2016 10:42 PM, Semyon Sadetsky wrote: On 9/12/2016 9:48 PM, Alexandr Scherbatiy wrote: On 9/12/2016 7:52 PM, Semyon Sadetsky wrote: On 9/12/2016 6:50 PM, Alexandr Scherbatiy wrote: On

Re: [9] Review request for 8157065: There is no the focus border on the selected tab.

2016-09-13 Thread Semyon Sadetsky
On 9/13/2016 7:21 PM, Alexandr Scherbatiy wrote: On 9/12/2016 10:42 PM, Semyon Sadetsky wrote: On 9/12/2016 9:48 PM, Alexandr Scherbatiy wrote: On 9/12/2016 7:52 PM, Semyon Sadetsky wrote: On 9/12/2016 6:50 PM, Alexandr Scherbatiy wrote: On 9/12/2016 6:42 PM, Semyon Sadetsky wrote:

Re: [9] Review request for 8157065: There is no the focus border on the selected tab.

2016-09-13 Thread Alexandr Scherbatiy
On 9/12/2016 10:42 PM, Semyon Sadetsky wrote: On 9/12/2016 9:48 PM, Alexandr Scherbatiy wrote: On 9/12/2016 7:52 PM, Semyon Sadetsky wrote: On 9/12/2016 6:50 PM, Alexandr Scherbatiy wrote: On 9/12/2016 6:42 PM, Semyon Sadetsky wrote: GTKPainter does not implement a lot of methods which can

Re: [9] Review request for 8157065: There is no the focus border on the selected tab.

2016-09-12 Thread Semyon Sadetsky
On 9/12/2016 9:48 PM, Alexandr Scherbatiy wrote: On 9/12/2016 7:52 PM, Semyon Sadetsky wrote: On 9/12/2016 6:50 PM, Alexandr Scherbatiy wrote: On 9/12/2016 6:42 PM, Semyon Sadetsky wrote: GTKPainter does not implement a lot of methods which can be accessed by public API. Could you, please,

Re: [9] Review request for 8157065: There is no the focus border on the selected tab.

2016-09-12 Thread Alexandr Scherbatiy
On 9/12/2016 7:52 PM, Semyon Sadetsky wrote: On 9/12/2016 6:50 PM, Alexandr Scherbatiy wrote: On 9/12/2016 6:42 PM, Semyon Sadetsky wrote: GTKPainter does not implement a lot of methods which can be accessed by public API. Could you, please, explain, why this specific method is more

Re: [9] Review request for 8157065: There is no the focus border on the selected tab.

2016-09-12 Thread Semyon Sadetsky
On 9/12/2016 6:50 PM, Alexandr Scherbatiy wrote: On 9/12/2016 6:42 PM, Semyon Sadetsky wrote: GTKPainter does not implement a lot of methods which can be accessed by public API. Could you, please, explain, why this specific method is more important than, for example,

Re: [9] Review request for 8157065: There is no the focus border on the selected tab.

2016-09-12 Thread Alexandr Scherbatiy
On 9/12/2016 6:42 PM, Semyon Sadetsky wrote: GTKPainter does not implement a lot of methods which can be accessed by public API. Could you, please, explain, why this specific method is more important than, for example, paintToolBarContentBackground() or paintToggleButtonBorder(), or all other

Re: [9] Review request for 8157065: There is no the focus border on the selected tab.

2016-09-12 Thread Semyon Sadetsky
GTKPainter does not implement a lot of methods which can be accessed by public API. Could you, please, explain, why this specific method is more important than, for example, paintToolBarContentBackground() or paintToggleButtonBorder(), or all other unimplemented? In general, how do you

Re: [9] Review request for 8157065: There is no the focus border on the selected tab.

2016-09-12 Thread Alexandr Scherbatiy
The paintTabbedPaneTabBorder() without orientation should be implemented as well because it can be accessed by public API. Thanks, Alexandr. On 6/3/2016 10:54 PM, Semyon Sadetsky wrote: On 6/3/2016 10:34 PM, Sergey Bylokhov wrote: On 03.06.16 22:21, Semyon Sadetsky wrote: What reason? Why

Re: [9] Review request for 8157065: There is no the focus border on the selected tab.

2016-06-03 Thread Semyon Sadetsky
On 6/3/2016 10:34 PM, Sergey Bylokhov wrote: On 03.06.16 22:21, Semyon Sadetsky wrote: What reason? Why it is not public? since I provided the code example where these methods are accessed by the user? GTK toollkit painting sequence is very different. What does it mean "different"? Even in

Re: [9] Review request for 8157065: There is no the focus border on the selected tab.

2016-06-03 Thread Sergey Bylokhov
On 03.06.16 22:21, Semyon Sadetsky wrote: What reason? Why it is not public? since I provided the code example where these methods are accessed by the user? GTK toollkit painting sequence is very different. What does it mean "different"? Even in this fix you implement one of the method

Re: [9] Review request for 8157065: There is no the focus border on the selected tab.

2016-06-03 Thread Semyon Sadetsky
On 6/3/2016 10:10 PM, Sergey Bylokhov wrote: On 03.06.16 20:50, Semyon Sadetsky wrote: I did not understand what you meant under "extension" term (inheritance?). It is not true that the method has the same spec. extension - mean that this method provide an additional

Re: [9] Review request for 8157065: There is no the focus border on the selected tab.

2016-06-03 Thread Sergey Bylokhov
On 03.06.16 20:50, Semyon Sadetsky wrote: I did not understand what you meant under "extension" term (inheritance?). It is not true that the method has the same spec. extension - mean that this method provide an additional functionality(orientation) to the first method. Actually the spec

Re: [9] Review request for 8157065: There is no the focus border on the selected tab.

2016-06-03 Thread Sergey Bylokhov
On 03.06.16 18:57, Semyon Sadetsky wrote: This is a public API, and it will be strange if two overloaded methods behave differently. I did not get it. Could you provide an example? Something like this: JButton jb = new JButton(); SynthUI ui = (SynthUI) jb.getUI(); SynthContext context =

Re: [9] Review request for 8157065: There is no the focus border on the selected tab.

2016-06-03 Thread Semyon Sadetsky
On 6/3/2016 6:39 PM, Sergey Bylokhov wrote: On 03.06.16 18:20, Semyon Sadetsky wrote: I do not say that we should implement all methods but we need to be consistent, if one version of paintTabbedPaneTabBorder is implemented then the second should be implemented too. This conclusion need to be

Re: [9] Review request for 8157065: There is no the focus border on the selected tab.

2016-06-03 Thread Sergey Bylokhov
On 03.06.16 18:20, Semyon Sadetsky wrote: I do not say that we should implement all methods but we need to be consistent, if one version of paintTabbedPaneTabBorder is implemented then the second should be implemented too. This conclusion need to be proven because there other methods of the GTK

Re: [9] Review request for 8157065: There is no the focus border on the selected tab.

2016-06-03 Thread Semyon Sadetsky
On 6/3/2016 2:41 PM, Sergey Bylokhov wrote: On 03.06.16 10:33, Semyon Sadetsky wrote: Nimbus painter implements a lot of methods that GTK LnF painter does not. GTK LnF painter only implements methods which are required to paint the native UI element, because the painting approach used in GTK

Re: [9] Review request for 8157065: There is no the focus border on the selected tab.

2016-06-03 Thread Sergey Bylokhov
On 03.06.16 10:33, Semyon Sadetsky wrote: Nimbus painter implements a lot of methods that GTK LnF painter does not. GTK LnF painter only implements methods which are required to paint the native UI element, because the painting approach used in GTK toolkit is far different from Synth's painting

Re: [9] Review request for 8157065: There is no the focus border on the selected tab.

2016-06-03 Thread Semyon Sadetsky
On 6/2/2016 9:09 PM, Sergey Bylokhov wrote: On 02.06.16 19:29, Semyon Sadetsky wrote: Should we implement paintTabbedPaneTabBorder() w/o orientation falg also? It is not used in GTK LnF. But this painter extends the public SynthPainter, which can be used by the application. The Nimbus l

Re: [9] Review request for 8157065: There is no the focus border on the selected tab.

2016-06-02 Thread Sergey Bylokhov
On 02.06.16 19:29, Semyon Sadetsky wrote: Should we implement paintTabbedPaneTabBorder() w/o orientation falg also? It is not used in GTK LnF. But this painter extends the public SynthPainter, which can be used by the application. The Nimbus l which extends it implements both methods. --

Re: [9] Review request for 8157065: There is no the focus border on the selected tab.

2016-06-02 Thread Semyon Sadetsky
On 6/2/2016 6:53 PM, Sergey Bylokhov wrote: On 02.06.16 18:43, Semyon Sadetsky wrote: GTK LnF draws focus only when a default tab header is used. If custom tab renderer is installed the input focus is not shown. The fix implements the omitted scenario. Should we implement

Re: [9] Review request for 8157065: There is no the focus border on the selected tab.

2016-06-02 Thread Sergey Bylokhov
On 02.06.16 18:43, Semyon Sadetsky wrote: GTK LnF draws focus only when a default tab header is used. If custom tab renderer is installed the input focus is not shown. The fix implements the omitted scenario. Should we implement paintTabbedPaneTabBorder() w/o orientation falg also? -- Best

[9] Review request for 8157065: There is no the focus border on the selected tab.

2016-06-02 Thread Semyon Sadetsky
Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8157065 webrev: http://cr.openjdk.java.net/~ssadetsky/8157065/webrev.00/ GTK LnF draws focus only when a default tab header is used. If custom tab renderer is installed the input focus is not shown. The fix