Re: [9] Review request for 8158566 Provide a Swing property to not close toggle menu items on mouse click

2016-06-27 Thread Phil Race
On 06/27/2016 04:42 AM, Semyon Sadetsky wrote: I left the suggested phrase as: "* Note: some {@code L&F}s may ignore this property. All built-in L&Fs inherit this behaviour." "L&Fs" produces compilation error because the "&" is a prefix for special symbols codes. You need to replace it wi

Re: [9] Review request for 8158566 Provide a Swing property to not close toggle menu items on mouse click

2016-06-27 Thread Semyon Sadetsky
On 6/27/2016 12:47 PM, Alexander Scherbatiy wrote: On 27/06/16 10:56, Semyon Sadetsky wrote: On 6/24/2016 3:33 PM, Alexandr Scherbatiy wrote: Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8158566/webrev.02 On 6/20/2016 10:55 PM, Phil Race wrote: 59 * Some times

Re: [9] Review request for 8158566 Provide a Swing property to not close toggle menu items on mouse click

2016-06-27 Thread Alexander Scherbatiy
On 27/06/16 10:56, Semyon Sadetsky wrote: On 6/24/2016 3:33 PM, Alexandr Scherbatiy wrote: Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8158566/webrev.02 On 6/20/2016 10:55 PM, Phil Race wrote: 59 * Some times it is required to select several check box menu items

Re: [9] Review request for 8158566 Provide a Swing property to not close toggle menu items on mouse click

2016-06-26 Thread Semyon Sadetsky
On 6/24/2016 3:33 PM, Alexandr Scherbatiy wrote: Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8158566/webrev.02 On 6/20/2016 10:55 PM, Phil Race wrote: 59 * Some times it is required to select several check box menu items from a button 60 * group. In this case

Re: [9] Review request for 8158566 Provide a Swing property to not close toggle menu items on mouse click

2016-06-24 Thread Philip Race
+1 .. please file a CCC. -phil. On 6/24/16, 5:33 AM, Alexandr Scherbatiy wrote: Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8158566/webrev.02 On 6/20/2016 10:55 PM, Phil Race wrote: 59 * Some times it is required to select several check box menu items from a but

Re: [9] Review request for 8158566 Provide a Swing property to not close toggle menu items on mouse click

2016-06-24 Thread Alexandr Scherbatiy
Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8158566/webrev.02 On 6/20/2016 10:55 PM, Phil Race wrote: 59 * Some times it is required to select several check box menu items from a button 60 * group. In this case it is useful that clicking on one check box menu i

Re: [9] Review request for 8158566 Provide a Swing property to not close toggle menu items on mouse click

2016-06-20 Thread Phil Race
59 * Some times it is required to select several check box menu items from a button 60 * group. In this case it is useful that clicking on one check box menu item 61 * does not close the menu. Such behavior can be controlled by the Look and Feel 62 * property named {@code "CheckBoxM

Re: [9] Review request for 8158566 Provide a Swing property to not close toggle menu items on mouse click

2016-06-20 Thread Alexandr Scherbatiy
Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8158566/webrev.01/ The documentation is added to the JCheckBoxMenuItem and JRadioButtonMenuItem classes. Thanks, Alexandr. On 6/19/2016 9:05 PM, Philip Race wrote: So how does one know of the existence of this p

Re: [9] Review request for 8158566 Provide a Swing property to not close toggle menu items on mouse click

2016-06-19 Thread Philip Race
So how does one know of the existence of this property ? There seems to be a documentation/specification element missing here. Perhaps if you query the supported properties on the component it is returned, but you still need documentation to explain how it is used/interpreted. If it is not docum

[9] Review request for 8158566 Provide a Swing property to not close toggle menu items on mouse click

2016-06-14 Thread Alexandr Scherbatiy
Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8158566 webrev: http://cr.openjdk.java.net/~alexsch/8158566/webrev.00 The proposed "RadioButtonMenuItem.closeOnMouseClick" and "CheckBoxMenuItem.closeOnMouseClick" properties allows to control JRadioButtonMen