+1
--Semyon
On 20.09.2016 03:31, Sergey Bylokhov wrote:
Looks fine.
On 15.09.16 12:31, Alexandr Scherbatiy wrote:
Hello,
Could you review the updated fix:
http://cr.openjdk.java.net/~alexsch/8165234/webrev.02
The closeOnMouseClick property is renamed to doNotCloseOnMouseClick
wi
Looks fine.
On 15.09.16 12:31, Alexandr Scherbatiy wrote:
Hello,
Could you review the updated fix:
http://cr.openjdk.java.net/~alexsch/8165234/webrev.02
The closeOnMouseClick property is renamed to doNotCloseOnMouseClick
with the default false value.
The client property is queried
Hello,
Could you review the updated fix:
http://cr.openjdk.java.net/~alexsch/8165234/webrev.02
The closeOnMouseClick property is renamed to doNotCloseOnMouseClick
with the default false value.
The client property is queried in the first place. If it is not set
the L&F property val
Hi, Alexandr.
I think we should double check how we operate on this property in case
of custom L&F. Our code relies that this property is set to "true" by
default. And if the custom look&feel, which knows nothing about it will
be in use, then the code in SwingUtilities2 returns false. Is it exp
Could you review the updated fix:
http://cr.openjdk.java.net/~alexsch/8165234/webrev.01
On 9/2/2016 9:59 PM, Phil Race wrote:
Seems fine except for a grammatical issue in the javadoc
{@code true}. Setting the property to {@code false} either to
{@literal L&F}
I think you mean ".. either
Seems fine except for a grammatical issue in the javadoc
{@code true}. Setting the property to {@code false} either to {@literal L&F}
I think you mean ".. either on the ..."
-phil.
On 09/02/2016 05:30 AM, Alexandr Scherbatiy wrote:
Hello,
Could you review the fix:
bug: https://bugs.openj
Hello,
Could you review the fix:
bug: https://bugs.openjdk.java.net/browse/JDK-8165234
webrev: http://cr.openjdk.java.net/~alexsch/8165234/webrev.00
The fix JDK-8158566 adds "CheckBoxMenuItem.closeOnMouseClick" and
"RadioButtonMenuItem.closeOnMouseClick" properties
that control toogle
