The fix looks good to me.
Thanks,
Alexandr.
On 5/16/2016 6:49 PM, Sergey Bylokhov wrote:
Looks fine.
On 11.05.16 11:40, Rajeev Chamyal wrote:
Hello Sergey,
Please review the updated webrev.
http://cr.openjdk.java.net/~rchamyal/8152981/webrev.02/
- The empty catch block "catch
Looks fine.
On 11.05.16 11:40, Rajeev Chamyal wrote:
Hello Sergey,
Please review the updated webrev.
http://cr.openjdk.java.net/~rchamyal/8152981/webrev.02/
- The empty catch block "catch (Exception e) {}, it will be better to
re-throw an exception.
Updated the catch code to throw
Hello Sergey,
Please review the updated webrev.
http://cr.openjdk.java.net/~rchamyal/8152981/webrev.02/
- The empty catch block "catch (Exception e) {}, it will be better to
re-throw an exception.
Updated the catch code to throw exception.
-
The code change looks fine, a few notes about the test:
- The empty catch block "catch (Exception e) {}, it will be better to
re-throw an exception.
- "frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE)" can cause a
test failure in some jtreg modes(see JDK-8154365)
- Is it necessary to
Hello Sergey,
Please review the updated webrev.
http://cr.openjdk.java.net/~rchamyal/8152981/webrev.01/
Update: Added the check Icon install code in installDefaults to a private
method. Calling same method on propertychange.
Regards,
Rajeev Chamyal
-Original Message-
From: Sergey
Hi, Rajeev.
Is it necessary to reinstall UI for the component from the UI itself,
probably it will be possible to reconfigure the current one?
On 03.05.16 15:08, Rajeev Chamyal wrote:
Hello All,
Please review the below webrev.
Bug: https://bugs.openjdk.java.net/browse/JDK-8152981
The fix looks good to me.
Thanks,
Alexandr,
On 5/3/2016 3:08 PM, Rajeev Chamyal wrote:
Hello All,
Please review the below webrev.
Bug: https://bugs.openjdk.java.net/browse/JDK-8152981
Webrev : http://cr.openjdk.java.net/~rchamyal/8152981/webrev.00/
