Re: [OpenJDK 2D-Dev] [10] Review Request: 8187399 Different problems in the javadoc's links in java.desktop package

2017-10-24 Thread Brian Burkhalter
To be truly picky, the current moniker for “Apple Unix” is “macOS” [1]. Brian [1] https://en.wikipedia.org/wiki/MacOS On Sep 15, 2017, at 12:34 PM, Phil Race wrote: > 771 * @implNote Please note that for Mac OS, notifications

Re: [OpenJDK 2D-Dev] [10] Review Request: 8187399 Different problems in the javadoc's links in java.desktop package

2017-10-13 Thread Alexander Zvegintsev
+1 Thanks, Alexander. On 16/09/2017 07:16, Sergey Bylokhov wrote: That's of course a stylistic issue, but I think that the keywords(not necessary a java) look better when they are highlighted. Depending from the style it can look like this: http://cr.openjdk.java.net/~serb/8187399/img.png

Re: [OpenJDK 2D-Dev] [10] Review Request: 8187399 Different problems in the javadoc's links in java.desktop package

2017-10-13 Thread Alexander Zvegintsev
+1 Thanks, Alexander. On 14/09/2017 04:09, Sergey Bylokhov wrote: Hello, Please review the fix for jdk10. Some of the tidy warnings were fixed. Report is here: http://cr.openjdk.java.net/~jjg/doc-report/jdk-by-module/java.desktop/report.html Description:  - java/awt/Desktop.java: the

Re: [OpenJDK 2D-Dev] [10] Review Request: 8187399 Different problems in the javadoc's links in java.desktop package

2017-09-15 Thread Sergey Bylokhov
That's of course a stylistic issue, but I think that the keywords(not necessary a java) look better when they are highlighted. Depending from the style it can look like this: http://cr.openjdk.java.net/~serb/8187399/img.png Here is an updated webrev:

Re: [OpenJDK 2D-Dev] [10] Review Request: 8187399 Different problems in the javadoc's links in java.desktop package

2017-09-15 Thread Alan Snyder
It’s also not English, which not using @code would make it look like... > On Sep 15, 2017, at 12:34 PM, Phil Race wrote: > > 771 * @implNote Please note that for Mac OS, notifications > 772 * are only sent if the Java app is a bundled application, > 773

Re: [OpenJDK 2D-Dev] [10] Review Request: 8187399 Different problems in the javadoc's links in java.desktop package

2017-09-15 Thread Phil Race
771 * @implNote Please note that for Mac OS, notifications 772 * are only sent if the Java app is a bundled application, 773 * with a {@code CFBundleDocumentTypes} array present in its 774 * Info.plist. Should we be using {@code ..} for CFBundleDocumentTypes. It is not Java