Re: RfR JDK-8055831 Open Source Java Access Bridge

2015-03-26 Thread Magnus Ihse Bursie
On 2015-03-25 15:44, Pete Brunet wrote: On 3/25/15 3:01 AM, Erik Joelsson wrote: Hello Peter, The new source layout and Lib-jdk.accessibility.gmk look much better. Thanks! Regarding the .def files, I was mistaken and missed that they were referenced in the LDFLAGS, they were indeed used in th

Re: RfR JDK-8055831 Open Source Java Access Bridge

2015-03-25 Thread Phil Race
On 3/25/2015 10:58 AM, Pete Brunet wrote: Thanks Phil, On 3/25/15 11:26 AM, Phil Race wrote: AWTEventMonitor.java has a bunch of deprecated methods. If you don't have time now (I expect you don't) then it can be revisited later. Open sourcing is different than binary compatibility. These were

Re: RfR JDK-8055831 Open Source Java Access Bridge

2015-03-25 Thread Pete Brunet
Thanks Phil, On 3/25/15 11:26 AM, Phil Race wrote: > AWTEventMonitor.java has a bunch of deprecated methods. > If you don't have time now (I expect you don't) then it can be > revisited later. Open sourcing is different than binary compatibility. These were deprecated via CCC 8007499. > > The chan

Re: RfR JDK-8055831 Open Source Java Access Bridge

2015-03-25 Thread Phil Race
AWTEventMonitor.java has a bunch of deprecated methods. If you don't have time now (I expect you don't) then it can be revisited later. Open sourcing is different than binary compatibility. The change jdk/make/copy/Copy-java.gmk suggests that accessbridge is the only reason the closed version of

Re: RfR JDK-8055831 Open Source Java Access Bridge

2015-03-25 Thread Mandy Chung
On 3/24/2015 2:36 PM, Pete Brunet wrote: Here's the latest patch: http://cr.openjdk.java.net/~ptbrunet/JDK-8055831/webrev.01/ The modules.xml change looks fine. Mandy

Re: RfR JDK-8055831 Open Source Java Access Bridge

2015-03-25 Thread Pete Brunet
Hi Sergey, Which methods are you referring to? -Pete On 3/25/15 10:16 AM, Sergey Bylokhov wrote: > The fix looks fine. > But it is interesting, do we have an option to remove all deprecated > methods during this opening? or can we do it later? or we cannot? > > 25.03.15 17:44, Pete Brunet wrote:

Re: RfR JDK-8055831 Open Source Java Access Bridge

2015-03-25 Thread Sergey Bylokhov
The fix looks fine. But it is interesting, do we have an option to remove all deprecated methods during this opening? or can we do it later? or we cannot? 25.03.15 17:44, Pete Brunet wrote: On 3/25/15 3:01 AM, Erik Joelsson wrote: Hello Peter, The new source layout and Lib-jdk.accessibility

Re: RfR JDK-8055831 Open Source Java Access Bridge

2015-03-25 Thread Pete Brunet
On 3/25/15 3:01 AM, Erik Joelsson wrote: > Hello Peter, > > The new source layout and Lib-jdk.accessibility.gmk look much better. > Thanks! > > Regarding the .def files, I was mistaken and missed that they were > referenced in the LDFLAGS, they were indeed used in the build so no > reason to remo

Re: RfR JDK-8055831 Open Source Java Access Bridge

2015-03-25 Thread Erik Joelsson
Hello Peter, The new source layout and Lib-jdk.accessibility.gmk look much better. Thanks! Regarding the .def files, I was mistaken and missed that they were referenced in the LDFLAGS, they were indeed used in the build so no reason to remove them. /Erik On 2015-03-24 22:36, Pete Brunet w

Re: RfR JDK-8055831 Open Source Java Access Bridge

2015-03-24 Thread Pete Brunet
Here's the latest patch: http://cr.openjdk.java.net/~ptbrunet/JDK-8055831/webrev.01/ The changes are: - restructured the native libraries from one directory to several directories on a per DLL/EXE basis - that impacted jdk/make/lib/Lib-jdk.accessibility.gmk - removed the source for the Ferret and

Re: RfR JDK-8055831 Open Source Java Access Bridge

2015-03-23 Thread Pete Brunet
I posted this to awt-dev and build-dev Friday and it was suggested that I also post it to swing-dev. On 3/20/15 11:33 PM, Pete Brunet wrote: > Please review the following patch which will add the code of the Java > Access Bridge (JAB) and related Java Accessibility Utilities to OpenJDK. > > This c