Re: 8138771: java.awt.image.AbstractMultiResolutionImage needs customized spec for methods of Image which it implements

The fix looks good to me. Thanks, Alexandr. On 10/31/2016 9:31 PM, Jim Graham wrote: Looks good. +1 ...jim On 10/30/16 11:53 PM, Avik Niyogi wrote: Hi All, Please review the proposed specification for JDK9 including inputs from reviewer reviews. *cr.openjdk.java.net/~aniyogi/813877

Re: 8138771: java.awt.image.AbstractMultiResolutionImage needs customized spec for methods of Image which it implements

Looks good. +1 ...jim On 10/30/16 11:53 PM, Avik Niyogi wrote: Hi All, Please review the proposed specification for JDK9 including inputs from reviewer reviews. *cr.openjdk.java.net/~aniyogi/8138771/webrev.05/* Thank yo

Re: 8138771: java.awt.image.AbstractMultiResolutionImage needs customized spec for methods of Image which it implements

Hi All, Please review the proposed specification for JDK9 including inputs from reviewer reviews. cr.openjdk.java.net/~aniyogi/8138771/webrev.05/ Thank you in advance. With Regards, Avik Niyogi > On 28-Oct-2016, at 1:18 am, Jim Graham wro

Re: 8138771: java.awt.image.AbstractMultiResolutionImage needs customized spec for methods of Image which it implements

Hi Avik, My suggestion about adding a word "the" was not taken and a couple of other changes were made to the @return statements which are not optimal. Let's reset and use the following @return statements for each of the methods (to mirror the way these are described in the Image base class):

Re: 8138771: java.awt.image.AbstractMultiResolutionImage needs customized spec for methods of Image which it implements

Hi All, Please review the proposed specification for JDK9 including inputs from reviewer reviews. http://cr.openjdk.java.net/~aniyogi/8138771/webrev.04/ Thank you in advance. With Regards, Avik Niyogi > On 27-Oct-2016, at 2:33 am, Jim Gr

Re: 8138771: java.awt.image.AbstractMultiResolutionImage needs customized spec for methods of Image which it implements

The "@return" tags should not start with "returns" in the text. Also, in the @return for getProperty(), insert a word "the" as "the property of the base image"... ...jim On 10/26/16 12:36 AM, Avik Niyogi wrote: Hi All, Please review the proposed specification for JDK9

8138771: java.awt.image.AbstractMultiResolutionImage needs customized spec for methods of Image which it implements

Hi All, Please review the proposed specification for JDK9 including inputs from reviver reviews. cr.openjdk.java.net/~aniyogi/8138771/webrev.03/ Thank you in advance. With Regards, Avik Niyogi

Re: 8138771: java.awt.image.AbstractMultiResolutionImage needs customized spec for methods of Image which it implements

I agree that the @return tags need to be filled in. In the first descriptive sentence of the delegation methods, note that "{@code getBaseImage()}" is a reference to a function and not an object, so it sounds like the methods are implemented as "return getBaseImage()" which is not valid because

Re: 8138771: java.awt.image.AbstractMultiResolutionImage needs customized spec for methods of Image which it implements

On 8/30/2016 12:17 PM, Avik Niyogi wrote: Hi All, Please review the proposed specification for JDK9 including inputs from reviewer reviews. *http://cr.openjdk.java.net/~aniyogi/8138771/webrev.02/* I believe the @return tag should

Re: 8138771: java.awt.image.AbstractMultiResolutionImage needs customized spec for methods of Image which it implements

Hi All, Please review the proposed specification for JDK9 including inputs from reviewer reviews. http://cr.openjdk.java.net/~aniyogi/8138771/webrev.02/ Thank you in advance. With Regards, Avik Niyogi > On 29-Aug-2016, at 5:55 pm, Alexa

8138771: java.awt.image.AbstractMultiResolutionImage needs customized spec for methods of Image which it implements

+ awt-dev > On 22-Aug-2016, at 12:28 pm, Avik Niyogi wrote: > > Hi All, > > Kindly review the proposed specifications for JDK9. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8138771 > > > Webrev: http://cr.openjdk.java.net/~aniyogi/813

8138771: java.awt.image.AbstractMultiResolutionImage needs customized spec for methods of Image which it implements

Hi All, Kindly review the proposed specifications for JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-8138771 Webrev: http://cr.openjdk.java.net/~aniyogi/8138771/webrev.00/ Issue: