Re: 8172509: [TEST_BUG] [macosx] Failure of the new test java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java

2017-01-19 Thread Alexandr Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 1/18/2017 8:39 PM, Sergey Bylokhov wrote: 17 янв. 2017 г., в 23:44, Avik Niyogi > написал(а): On 17-Jan-2017, at 9:23 pm, Sergey Bylokhov mailto:sergey.bylok...@oracle.com>> wrote: Hi, Avik. In Nimbus and Aqu

Re: 8172509: [TEST_BUG] [macosx] Failure of the new test java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java

2017-01-18 Thread Sergey Bylokhov
> 17 янв. 2017 г., в 23:44, Avik Niyogi написал(а): > > >> On 17-Jan-2017, at 9:23 pm, Sergey Bylokhov > > wrote: >> >> Hi, Avik. >>> >>> In Nimbus and Aqua LAF, for focus traversal, keybindings do not existing >>> only arrow keys would work within ungroupe

Re: 8172509: [TEST_BUG] [macosx] Failure of the new test java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java

2017-01-17 Thread Avik Niyogi
> On 17-Jan-2017, at 9:23 pm, Sergey Bylokhov > wrote: > > Hi, Avik. >> >> In Nimbus and Aqua LAF, for focus traversal, keybindings do not existing >> only arrow keys would work within ungrouped radio buttons but not within >> grouped radio button groups. Also, verified Aqua LAF with native

Re: 8172509: [TEST_BUG] [macosx] Failure of the new test java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java

2017-01-17 Thread Sergey Bylokhov
Hi, Avik. > > In Nimbus and Aqua LAF, for focus traversal, keybindings do not existing only > arrow keys would work within ungrouped radio buttons but not within grouped > radio button groups. Also, verified Aqua LAF with native application on > MacBook. So to test this focus traversal, it work

Re: 8172509: [TEST_BUG] [macosx] Failure of the new test java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java

2017-01-12 Thread Avik Niyogi
A gentle reminder, please review the code changes made. With Regards, Avik Niyogi > On 12-Jan-2017, at 10:02 am, Avik Niyogi wrote: > > In Nimbus and Aqua LAF, for focus traversal, keybindings do not existing only > arrow keys would work within ungrouped radio buttons but not within grouped >

Re: 8172509: [TEST_BUG] [macosx] Failure of the new test java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java

2017-01-11 Thread Avik Niyogi
In Nimbus and Aqua LAF, for focus traversal, keybindings do not existing only arrow keys would work within ungrouped radio buttons but not within grouped radio button groups. Also, verified Aqua LAF with native application on MacBook. So to test this focus traversal, it works only in LAF which d

Re: 8172509: [TEST_BUG] [macosx] Failure of the new test java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java

2017-01-11 Thread Alexandr Scherbatiy
On 1/11/2017 2:01 PM, Avik Niyogi wrote: Hi All, I have addressed the inputs received in the following update. Please review the same for JDK 9. http://cr.openjdk.java.net/~aniyogi/8172509/webrev.01/ With Regards, Avik Niyogi On 11-Ja

Re: 8172509: [TEST_BUG] [macosx] Failure of the new test java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java

2017-01-11 Thread Avik Niyogi
Hi All, I have addressed the inputs received in the following update. Please review the same for JDK 9. http://cr.openjdk.java.net/~aniyogi/8172509/webrev.01/ With Regards, Avik Niyogi > On 11-Jan-2017, at 4:22 pm, Prasanta Sadhukhan > w

Re: 8172509: [TEST_BUG] [macosx] Failure of the new test java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java

2017-01-11 Thread Prasanta Sadhukhan
I guess we need to throw the exception if changing LaF fails instead of silently consuming it!! Regards Prasanta On 1/11/2017 2:16 PM, Avik Niyogi wrote: Hi All, Kindly review the proposed fix for JDK9. *Bug: https://bugs.openjdk.java.net/browse/JDK-8172509* * * *Webrev: http://cr.openjdk.jav

8172509: [TEST_BUG] [macosx] Failure of the new test java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java

2017-01-11 Thread Avik Niyogi
Hi All, Kindly review the proposed fix for JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-8172509 Webrev: http://cr.openjdk.java.net/~aniyogi/8172509/webrev.00/ Issue: The focus tr