Re: Code review request: 8026929: remove accelerators from policytool resources

2013-10-28 Thread Alexander Potochkin
Hello Leif Okay, I approve Thanks alexp On 10/22/2013 8:12 PM, Leif Samuelsson wrote: Hi Alexander, On 2013-10-22 04:25, Alexander Potochkin wrote: Hello Leif There was a special logic for keyStrokes on MacOS inPolicyTool.addMenuItem(), could you make sure that the new code correctly set

Re: Code review request: 8026929: remove accelerators from policytool resources

2013-10-24 Thread Alexander Scherbatiy
The fix looks good for me. It would be better to split long strings on several lines. Thanks, Alexandr. On 10/22/2013 8:12 PM, Leif Samuelsson wrote: Hi Alexander, On 2013-10-22 04:25, Alexander Potochkin wrote: Hello Leif There was a special logic for keyStrokes on MacOS inPolicy

Re: Code review request: 8026929: remove accelerators from policytool resources

2013-10-22 Thread Leif Samuelsson
Hi Alexander, On 2013-10-22 04:25, Alexander Potochkin wrote: Hello Leif There was a special logic for keyStrokes on MacOS inPolicyTool.addMenuItem(), could you make sure that the new code correctly set keyStrokes on MacOS? That logic is still there, but it was simplified. As long as the acce

Re: Code review request: 8026929: remove accelerators from policytool resources

2013-10-22 Thread Alexander Potochkin
Hello Leif There was a special logic for keyStrokes on MacOS inPolicyTool.addMenuItem(), could you make sure that the new code correctly set keyStrokes on MacOS? Thanks alexp Hi All, This is a small additional fix to PolicyTool to move the default accelerators for File->New/Open/Save from th

Code review request: 8026929: remove accelerators from policytool resources

2013-10-21 Thread Leif Samuelsson
Hi All, This is a small additional fix to PolicyTool to move the default accelerators for File->New/Open/Save from the resource bundle to hard coded values in PolicyTool.java. This is done to avoid confusing the translators about the difference between mnemonics and accelerators. Accelerators ar