Re: Questionable Rendering of Disabled Text

2017-11-20 Thread Michael Dardis
Hi Phil, Semyon, Didn't see this land originally. Thanks for the sponsorship. Will try and get this applied to downstream Ubuntu builds. Thanks Michael On 14 November 2017 at 08:20, Semyon Sadetsky wrote: > +1 > > --Semyon > > > On 11/09/2017 10:50 AM, Phil Race wrote: >> >> Protocol is that t

Re: Questionable Rendering of Disabled Text

2017-11-13 Thread Semyon Sadetsky
+1 --Semyon On 11/09/2017 10:50 AM, Phil Race wrote: Protocol is that there first be a bug report and then a "RFR" (request for review) is sent to the list referencing the bug + the fix I have filed https://bugs.openjdk.java.net/browse/JDK-8191041 and verified that it works. So we can perha

Re: Questionable Rendering of Disabled Text

2017-11-09 Thread Phil Race
No need this time but in future file it at http://bugreport.java.com/ ... those go into the same JIRA instance as JBS and just get moved after verification -phil. On 11/9/2017 1:35 PM, Michael D wrote: Hi Phil, Not an OpenJDk dev so unable to file bug reports or webrevs. Thanks for looking

Re: Questionable Rendering of Disabled Text

2017-11-09 Thread Michael D
Hi Phil, Not an OpenJDk dev so unable to file bug reports or webrevs. Thanks for looking at the patch and filing a report. Michael On Fri, 10 Nov 2017 at 05:52, Phil Race wrote: > Protocol is that there first be a bug report and then a "RFR" (request > for review) is sent > to the list refere

Re: Questionable Rendering of Disabled Text

2017-11-09 Thread Phil Race
Protocol is that there first be a bug report and then a "RFR" (request for review) is sent to the list referencing the bug + the fix I have filed https://bugs.openjdk.java.net/browse/JDK-8191041 and verified that it works. So we can perhaps short-circuit that this time .. but not next time ..

Re: Questionable Rendering of Disabled Text

2017-11-03 Thread Michael D
Apologies, noticed I broke the patch between testing and submission. Correct and re-tested version --- a/src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKGraphicsUtils.java +++ b/src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKGraphicsUtils.java @@ -47,34 +47,17 @@ c

Re: Questionable Rendering of Disabled Text

2017-11-03 Thread Michael D
My bad, Patch just looks like this (bit messy because of indent change). Thanks Michael --- a/src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKGraphicsUtils.java +++ b/src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKGraphicsUtils.java @@ -46,35 +46,17 @@ class GTKG

Re: Questionable Rendering of Disabled Text

2017-11-03 Thread Philip Race
Yes these mailing lists strip attachements So an in-line patch .. or send directly to one of us to host it for you on cr.openjdk.java.net. -phil. On 11/3/17, 12:34 PM, Sergey Bylokhov wrote: Hi, Michael. It seems that the attached patch was removed from the email, can you please provide a li

Re: Questionable Rendering of Disabled Text

2017-11-03 Thread Sergey Bylokhov
Hi, Michael. It seems that the attached patch was removed from the email, can you please provide a link to it or inline in email. Thank you. On 03/11/2017 03:09, Michael D wrote: On 3 November 2017 at 21:07, Michael D wrote: Hi All, Last couple of days I've been trying to root out this bug

Re: Questionable Rendering of Disabled Text

2017-11-03 Thread Michael D
On 3 November 2017 at 21:07, Michael D wrote: > Hi All, > > Last couple of days I've been trying to root out this bug - > https://bugs.launchpad.net/ubuntu/+source/openjdk-8/+bug/1729558 which > has resulted in poor looking rendering on my machine. > It turns out that the cause of this behavior is