Re: RFR(S): 8156020: 8145547 breaks AIX and and uses RTLD_NOLOAD incorrectly

2016-05-10 Thread Semyon Sadetsky
Hi Volker, I did not answer you because I was on leave. Thank you for your attention to the problem. It looks like that you found the issue we could not find. For some reason I thought that RTLD_NOLOAD and RTLD_LAZY flags are mutually excluded, and unfortunately the reviewers did not notice

Re: RFR(S): 8156020: 8145547 breaks AIX and and uses RTLD_NOLOAD incorrectly

2016-05-07 Thread Volker Simonis
Hi Phil, Sergey, @Sergey: thaks for the review Please see my other comments inline: On Sat, May 7, 2016 at 1:45 AM, Phil Race wrote: > On 05/06/2016 04:33 PM, Volker Simonis wrote: > > Hi Phil, > > Thanks for looking at this problem. > > On Saturday, May 7, 2016, Phil

Re: RFR(S): 8156020: 8145547 breaks AIX and and uses RTLD_NOLOAD incorrectly

2016-05-06 Thread Phil Race
On 05/06/2016 04:33 PM, Volker Simonis wrote: Hi Phil, Thanks for looking at this problem. On Saturday, May 7, 2016, Phil Race > wrote: Hi, I've confirmed that what was pushed was v5 and it should really have been v6. I

Re: RFR(S): 8156020: 8145547 breaks AIX and and uses RTLD_NOLOAD incorrectly

2016-05-06 Thread Volker Simonis
Hi Phil, Thanks for looking at this problem. On Saturday, May 7, 2016, Phil Race wrote: > Hi, > > I've confirmed that what was pushed was v5 and it should really have been > v6. > I can't say unequivocally that it would have built on AIX but > 1) It does not use

Re: RFR(S): 8156020: 8145547 breaks AIX and and uses RTLD_NOLOAD incorrectly

2016-05-06 Thread Sergey Bylokhov
Hi. I guess the version .5 was pushed because the .6 parse "/proc". On 07.05.16 1:56, Phil Race wrote: Hi, I've confirmed that what was pushed was v5 and it should really have been v6. I can't say unequivocally that it would have built on AIX but 1) It does not use RTLD_NOLOAD anywhere 2) all

Re: RFR(S): 8156020: 8145547 breaks AIX and and uses RTLD_NOLOAD incorrectly

2016-05-06 Thread Phil Race
Hi, I've confirmed that what was pushed was v5 and it should really have been v6. I can't say unequivocally that it would have built on AIX but 1) It does not use RTLD_NOLOAD anywhere 2) all calls to dlopen include RTLD_LAZY. Here is the delta - the patch that makes v5 into v6 and although it

Re: RFR(S): 8156020: 8145547 breaks AIX and and uses RTLD_NOLOAD incorrectly

2016-05-05 Thread Philip Race
Hi Volker, 1) adding awt-dev. Semyon did the review on swing but really it should always (and mainly!) have been awt. 2) Yes, this ought to be pushed to 9-client, specifically not 9-dev. Assuming it goes to 9-dev we may need to deal with conflicts. Also if it causes any kind of problem with

Re: RFR(S): 8156020: 8145547 breaks AIX and and uses RTLD_NOLOAD incorrectly

2016-05-05 Thread Sergey Bylokhov
Looks fine to me. On 04.05.16 21:32, Volker Simonis wrote: Hi, can somebody please review this small change which fixes the AIX build after change 8145547, but also fixes an incorrect usage pattern of RTLD_NOLOAD in 8145547: http://cr.openjdk.java.net/~simonis/webrevs/2016/8156020/