Re: RFR 8157339: Further stabilization for the SwingSet client sanity tests.

2016-05-24 Thread Alexander Kouznetsov
Hi Sergey, I'm wondering how strict this rule is. I'm ready to push it to jdk-dev but will leave it to you if it must go through the client. Best regards, Alexander Kouznetsov (408) 276-0387 On 5/24/2016 9:15 AM, Sergey Bylokhov wrote: usually all client related fixes goes to the client ws

Re: RFR 8157339: Further stabilization for the SwingSet client sanity tests.

2016-05-24 Thread Alexandre (Shura) Iline
Here it goes. http://cr.openjdk.java.net/~shurailine/8157339/webrev.02 Could any of you guys push it for me? Shura > On May 24, 2016, at 9:38 AM, Alexandre (Shura) Iline > wrote: > > >> On May 24, 2016, at 9:15 AM, Sergey Bylokhov

Re: RFR 8157339: Further stabilization for the SwingSet client sanity tests.

2016-05-24 Thread Alexandre (Shura) Iline
> On May 24, 2016, at 9:15 AM, Sergey Bylokhov > wrote: > > Looks fine. but why the diff is against the dev ws? usually all client > related fixes goes to the client ws first. Ah, this is my bad.I will re-generate this against the client repo. > It is interesting

Re: RFR 8157339: Further stabilization for the SwingSet client sanity tests.

2016-05-24 Thread Sergey Bylokhov
Looks fine. but why the diff is against the dev ws? usually all client related fixes goes to the client ws first. It is interesting how many times you run the test to confirm that they are stable?(I suppose it should be executed ±100 times). On 23.05.16 22:01, Alexander Kouznetsov wrote:

Re: RFR 8157339: Further stabilization for the SwingSet client sanity tests.

2016-05-24 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 23/05/16 22:52, Alexandre (Shura) Iline wrote: I have updated the web rev: http://cr.openjdk.java.net/~shurailine/8157339/webrev.01/ I imagine I need an approval from one of the

Re: RFR 8157339: Further stabilization for the SwingSet client sanity tests.

2016-05-20 Thread Alexander Kouznetsov
Shura, Great changes. I have several comments on them: * Seems like @key intermittent should be added to ButtonDemoScreenshotTest. * OptionPaneDemoTest.java: o Looks like the following line should be removed: 88 final String labelText = COMPONENT_R3; o And index 1 is

RFR 8157339: Further stabilization for the SwingSet client sanity tests.

2016-05-20 Thread Alexandre (Shura) Iline
Hi. Please take a look on the changes in: http://cr.openjdk.java.net/~shurailine/8157339/webrev.00/ I have gone through the code to discover potential instabilities. I was not changing the test logic much and mostly changed the code where I had to change it for stabilization reason. In some