Jason
From: Phil Race
Sent: Monday, March 9, 2020 1:48 PM
To: Jason Mehrens; Volodin, Vladislav
Cc: swing-dev@openjdk.java.net
Subject: Re: Remove System.out.println from ImageIcon.loadImage
I am not arguing the general case. I am addressing this case whe
is important for the JOptionPane to see as a signal not wait.
Jason
From: Philip Race
Sent: Sunday, March 8, 2020 5:56 PM
To: Volodin, Vladislav
Cc: Jason Mehrens; swing-dev@openjdk.java.net
Subject: Re: Remove System.out.println from ImageIcon.loadImage
1) That
net
Subject: Re: Remove System.out.println from ImageIcon.loadImage
1) That bug is still closed. Did you want it re-opened ? I've just done so.
BTW I don't know why, but it was closed less than 3 months ago
by an engineer from the hotspot team (!?) I have NO idea why
since there is no comment.
odin, Vladislav; Jason Mehrens
Cc: swing-dev@openjdk.java.net
Subject: Re: Remove System.out.println from
ImageIcon.loadImage
I guess there are no objections, probably the best way to fix
it is to drop the System.out.println and set interrupted flag.
On 1/16/20 7:05 am, Volodin, Vladislav wrot
for iOS <https://aka.ms/o0ukef>
*From:* Jason Mehrens
*Sent:* Tuesday, February 11, 2020 9:13:41 PM
*To:* Volodin, Vladislav
*Cc:* swing-dev@openjdk.java.net
*Subject:* Re: Remove System.out.println from
ImageIcon.loadImage
Vlad,
Yea that looks good.
Jason
nt: Freitag, 28. Februar 2020 02:47
To: Volodin, Vladislav
Cc: swing-dev@openjdk.java.net
Subject: Re: Remove System.out.println from ImageIcon.loadImage
Looks good to me.
From: Volodin, Vladislav
Sent: Saturday, February 22, 2020 4:38 AM
To: Jason Mehren
Looks good to me.
From: Volodin, Vladislav
Sent: Saturday, February 22, 2020 4:38 AM
To: Jason Mehrens
Cc: swing-dev@openjdk.java.net
Subject: Re: Remove System.out.println from ImageIcon.loadImage
Hello Jason and everyone else,
here is my webrev that
iOS<https://aka.ms/o0ukef>
From: Jason Mehrens
Sent: Tuesday, February 11, 2020 9:13:41 PM
To: Volodin, Vladislav
Cc: swing-dev@openjdk.java.net
Subject: Re: Remove System.out.println from ImageIcon.loadImage
Vlad,
Yea that looks good.
Vlad,
Yea that looks good.
Jason
From: Volodin, Vladislav
Sent: Wednesday, February 5, 2020 9:59 AM
To: Jason Mehrens
Cc: swing-dev@openjdk.java.net
Subject: RE: Remove System.out.println from ImageIcon.loadImage
Hi Jason,
thank you for your advice
-6421373 for this?
Thanks
Christoph
-Original Message-
From: swing-dev On Behalf Of
Volodin, Vladislav
Sent: Mittwoch, 5. Februar 2020 16:59
To: Jason Mehrens
Cc: swing-dev@openjdk.java.net
Subject: [CAUTION] Re: Remove System.out.println from
ImageIcon.loadImage
Hi Jason,
thank you
Vladislav
> Sent: Mittwoch, 5. Februar 2020 16:59
> To: Jason Mehrens
> Cc: swing-dev@openjdk.java.net
> Subject: [CAUTION] Re: Remove System.out.println from
> ImageIcon.loadImage
>
> Hi Jason,
>
> thank you for your advice. I have changed my code, now it simulat
mebody else can review my patch and submit it to
JDK.
Thanks,
Vlad
-Original Message-
From: Jason Mehrens
Sent: Mittwoch, 29. Januar 2020 17:55
To: Volodin, Vladislav
Cc: swing-dev@openjdk.java.net
Subject: Re: Remove System.out.println from ImageIcon.loadImage
1. Agreed.
2. I was j
f (!Thread.currentThread().isInterrupted()) {
throw new RuntimeException("Interrupt was swallowed");
}
}
}
===
From: Volodin, Vladislav
Sent: Wednesday, January 29, 2020 9:52 AM
To: Jason Mehrens
Cc: swing-dev@openjdk.java.net
Sub
2020 16:35
To: Volodin, Vladislav
Cc: swing-dev@openjdk.java.net
Subject: Re: Remove System.out.println from ImageIcon.loadImage
Bug in that last version:
Thread.currentThread().isInterrupted(); -> Thread.currentThread().interrupt();
===
protected void loadImage(Image image) {
Media
ted();
}
}
}
}
===
Jason
From: Volodin, Vladislav
Sent: Tuesday, January 28, 2020 4:02 PM
To: Jason Mehrens
Cc: swing-dev@openjdk.java.net
Subject: Re: Remove System.out.println from ImageIcon.loadImage
This is a valid point, becaus
();
}
}
}
}
===
Jason
From: Volodin, Vladislav
Sent: Tuesday, January 28, 2020 4:02 PM
To: Jason Mehrens
Cc: swing-dev@openjdk.java.net
Subject: Re: Remove System.out.println from ImageIcon.loadImage
This is a valid point, because I wasn’t sure
To: Jason Mehrens
> Cc: swing-dev@openjdk.java.net
> Subject: Re: Remove System.out.println from ImageIcon.loadImage
>
> Hi Jason,
>
> I am not sure about the loop, because I don’t know if we can trust results
> from mTracker.statusID at the moment when an exceptional case occu
reassert the interrupted state at the end of the
method.
Jason
From: Volodin, Vladislav
Sent: Tuesday, January 28, 2020 2:54 PM
To: Jason Mehrens
Cc: swing-dev@openjdk.java.net
Subject: Re: Remove System.out.println from ImageIcon.loadImage
Hi Jason,
I am
}
>}
> ===
>
> Jason
>
> From: swing-dev on behalf of Volodin,
> Vladislav
> Sent: Monday, January 27, 2020 11:11 AM
> To: Sergey Bylokhov
> Cc: swing-dev@openjdk.java.net
> Subject: Re: Remove System.out.pr
behalf of Volodin,
Vladislav
Sent: Monday, January 27, 2020 11:11 AM
To: Sergey Bylokhov
Cc: swing-dev@openjdk.java.net
Subject: Re: Remove System.out.println from ImageIcon.loadImage
Hello Sergey, and others,
here is the patch (made with "git diff") in the attachment. I have read that
21. Januar 2020 22:26
To: Volodin, Vladislav
Cc: Jason Mehrens ; swing-dev@openjdk.java.net
Subject: Re: Remove System.out.println from ImageIcon.loadImage
On 1/21/20 1:14 pm, Volodin, Vladislav wrote:
> Hi all,
>
> If I am not mistaken, this method is called from the constructor and o
when the image is loaded."
From: Sergey Bylokhov
Sent: Sunday, January 19, 2020 9:31 PM
To: Volodin, Vladislav; Jason Mehrens
Cc: swing-dev@openjdk.java.net
Subject: Re: Remove System.out.println from ImageIcon.loadImage
I guess there are no object
only when the image is loaded."
From: Sergey Bylokhov
Sent: Sunday, January 19, 2020 9:31 PM
To: Volodin, Vladislav; Jason Mehrens
Cc: swing-dev@openjdk.java.net
Subject: Re: Remove System.out.println from ImageIcon.loadImage
I guess there are no
y Bylokhov
Sent: Sunday, January 19, 2020 9:31 PM
To: Volodin, Vladislav; Jason Mehrens
Cc: swing-dev@openjdk.java.net
Subject: Re: Remove System.out.println from ImageIcon.loadImage
I guess there are no objections, probably the best way to fix
it is to drop the System.out.println and set interr
+1 for Sergey suggestion.
From: Sergey Bylokhov
Sent: Sunday, January 19, 2020 9:31 PM
To: Volodin, Vladislav; Jason Mehrens
Cc: swing-dev@openjdk.java.net
Subject: Re: Remove System.out.println from ImageIcon.loadImage
I guess there are no objections
I guess there are no objections, probably the best way to fix
it is to drop the System.out.println and set interrupted flag.
On 1/16/20 7:05 am, Volodin, Vladislav wrote:
If people in this distribution list agree, I can start working on a simple fix
and either remove the logging (System.out.pri
14. Januar 2020 21:59
To: Sergey Bylokhov ; swing-dev@openjdk.java.net
Subject: Re: Remove System.out.println from ImageIcon.loadImage
This was the bug id when I reported it:
https://bugs.openjdk.java.net/browse/JDK-6421373
Notice it was closed as will not fix. I think that is incorrect but, I
ary 5, 2020 7:33 AM
To: swing-dev@openjdk.java.net
Subject: Re: Remove System.out.println from ImageIcon.loadImage
Hi, Matthias.
I suggest to create a bug report for this issue:
https://bugs.java.com/bugdatabase
On 1/5/20 11:53 am, Matthias Perktold - ASA wrote:
> Hi all
Hi, Matthias.
I suggest to create a bug report for this issue:
https://bugs.java.com/bugdatabase
On 1/5/20 11:53 am, Matthias Perktold - ASA wrote:
Hi all,
In javax.swing.ImageIcon.loadImage(), there is a call to System.out.println()
when loading the Image has been interrupted.
In our system
Hi all,
In javax.swing.ImageIcon.loadImage(), there is a call to System.out.println()
when loading the Image has been interrupted.
In our system, this is a problem because redirect System.out to be displayed to
the user to make sure no errors remain unnoticed.
But in this case, the message doe
30 matches
Mail list logo