Re: Review Request JDK-8152419 JColorChooser throws Exception

2016-06-15 Thread Prem Balakrishnan
@openjdk.java.net Subject: RE: Review Request JDK-8152419 JColorChooser throws Exception Hello Prem, testResult variable is accessed in 2 different threads. It should be declared volatile. Regards, Rajeev Chamyal From: Alexandr Scherbatiy Sent: 10 June 2016 19:53 To: Prem

Re: Review Request JDK-8152419 JColorChooser throws Exception

2016-06-15 Thread Rajeev Chamyal
Scherbatiy Sent: Tuesday, May 31, 2016 4:04 PM To: Prem Balakrishnan; Sergey Bylokhov; HYPERLINK "mailto:swing-dev@openjdk.java.net"swing-dev@openjdk.java.net Subject: Re: Review Request JDK-8152419 JColorChooser throws Exception On 31/05/16 14:03, Prem Balakrishnan wrote: Hi

Re: Review Request JDK-8152419 JColorChooser throws Exception

2016-06-10 Thread Alexandr Scherbatiy
, Prem *From:*Alexander Scherbatiy *Sent:* Tuesday, May 31, 2016 4:04 PM *To:* Prem Balakrishnan; Sergey Bylokhov; swing-dev@openjdk.java.net *Subject:* Re: Review Request JDK-8152419 JColorChooser throws Exception On 31/05/16 14:03, Prem Balakrishnan wrote: Hi Alexander, Please

Re: Review Request JDK-8152419 JColorChooser throws Exception

2016-06-10 Thread Prem Balakrishnan
: Review Request JDK-8152419 JColorChooser throws Exception On 31/05/16 14:03, Prem Balakrishnan wrote: Hi Alexander, Please review the updated patch. http://cr.openjdk.java.net/~pkbalakr/8152419/webrev.01/ Math.max(getWidth() - this.insets.left - this.insets.right, getWidth()) can give

Re: Review Request JDK-8152419 JColorChooser throws Exception

2016-05-31 Thread Alexander Scherbatiy
from the paintComponent() method. Thanks, Alexandr. Regards, Prem *From:*Alexander Scherbatiy *Sent:* Monday, May 30, 2016 9:42 PM *To:* Prem Balakrishnan; Sergey Bylokhov; swing-dev@openjdk.java.net *Subject:* Re: Review Request JDK-8152419 JColorChooser throws Exception On 30/05/16 12:39

Re: Review Request JDK-8152419 JColorChooser throws Exception

2016-05-31 Thread Prem Balakrishnan
-8152419 JColorChooser throws Exception On 30/05/16 12:39, Prem Balakrishnan wrote: Hi, Please review fix for JDK9, Bug: https://bugs.openjdk.java.net/browse/JDK-8152419 Webrev: HYPERLINK "http://cr.openjdk.java.net/%7Epkbalakr/8152419/webrev.00/"http://cr.openjdk.java.net/~pkbala

Re: Review Request JDK-8152419 JColorChooser throws Exception

2016-05-30 Thread Alexander Scherbatiy
On 30/05/16 12:39, Prem Balakrishnan wrote: Hi*,* Please review fix for JDK9, *Bug:*https://bugs.openjdk.java.net/browse/JDK-8152419 *Webrev:*http://cr.openjdk.java.net/~pkbalakr/8152419/webrev.00/ *Issue:* JColorChooser throws

Review Request JDK-8152419 JColorChooser throws Exception

2016-05-30 Thread Prem Balakrishnan
Hi, Please review fix for JDK9, Bug: https://bugs.openjdk.java.net/browse/JDK-8152419 Webrev: http://cr.openjdk.java.net/~pkbalakr/8152419/webrev.00/ Issue: JColorChooser throws Exception(NegativeArraySizeException) Fix: Absolute value is passed while creating array.