Re: Review Request of 8137169 : [macosx] Incorrect minimal heigh of JTabbedPane with more tabs

Hi Sergey and Alexander, Please review the code changes done. With Regards, Avik Niyogi > On 28-Mar-2016, at 1:45 pm, Avik Niyogi wrote: > > A gentle reminder, Please review the code changes as presented below. > > With Regards, > Avik Niyogi >> On 24-Mar-2016, at 3:01

Re: Review Request of 8137169 : [macosx] Incorrect minimal heigh of JTabbedPane with more tabs

Looks good to me. Regards, Rajeev Chamyal From: Avik Niyogi Sent: 24 March 2016 12:54 To: Rajeev Chamyal; Alexander Scherbatiy; Sergey Bylokhov; swing-dev@openjdk.java.net Subject: Re: Review Request of 8137169 : [macosx] Incorrect minimal heigh of JTabbedPane with more tabs Hi

Re: Review Request of 8137169 : [macosx] Incorrect minimal heigh of JTabbedPane with more tabs

Hi All, Please review code changes as per inputs received. http://cr.openjdk.java.net/~aniyogi/8137169/webrev.03 As SCROLL_TAB_LAYOUT is the default layout for Aqua LAF, with implementation within the derived

Re: Review Request of 8137169 : [macosx] Incorrect minimal heigh of JTabbedPane with more tabs

Hello Avik, x variable on line 2195 is not used anywhere. Do we need for loop also? Regards, Rajeev Chamyal From: Avik Niyogi Sent: 24 March 2016 12:19 To: Alexander Scherbatiy Cc: Sergey Bylokhov; Rajeev Chamyal; swing-dev@openjdk.java.net Subject: Re: Review Request of 8137169 :

Re: Review Request of 8137169 : [macosx] Incorrect minimal heigh of JTabbedPane with more tabs

Hi All, Please review my code changes below as per the inputs received. http://cr.openjdk.java.net/~aniyogi/8137169/webrev.02/ As SCROLL_TAB_LAYOUT is the default layout for Aqua LAF, with implementation within the derived

Re: Review Request of 8137169 : [macosx] Incorrect minimal heigh of JTabbedPane with more tabs

On 23/03/16 14:07, Avik Niyogi wrote: On 23-Mar-2016, at 3:31 pm, Alexander Scherbatiy > wrote: On 21/03/16 09:19, Avik Niyogi wrote: Hi Alexander, I agree with what you said regarding the look and feel looking

Re: Review Request of 8137169 : [macosx] Incorrect minimal heigh of JTabbedPane with more tabs

> On 23-Mar-2016, at 3:31 pm, Alexander Scherbatiy > wrote: > > On 21/03/16 09:19, Avik Niyogi wrote: >> Hi Alexander, >> I agree with what you said regarding the look and feel looking different. >> But this bug arrises due to setting of TabbedPaneScrollLayout

Re: Review Request of 8137169 : [macosx] Incorrect minimal heigh of JTabbedPane with more tabs

On 21/03/16 09:19, Avik Niyogi wrote: Hi Alexander, I agree with what you said regarding the look and feel looking different. But this bug arrises due to setting of TabbedPaneScrollLayout only. If Scroll Layout is not meant for Aqua look and feel should not the setting of this parameter

Re: Review Request of 8137169 : [macosx] Incorrect minimal heigh of JTabbedPane with more tabs

Hi Alexander, With inputs (code) provided, it is not possible to accommodate the right methods for tabPlacement parameter. Also, since AquaTabbedPane is copied from BasicUI.java, this implementation if moved to TabbedPaneLayout, does not accommodate Awua related changes and hence, the redundant

Re: Review Request of 8137169 : [macosx] Incorrect minimal heigh of JTabbedPane with more tabs

Hi Alexander, I agree with what you said regarding the look and feel looking different. But this bug arrises due to setting of TabbedPaneScrollLayout only. If Scroll Layout is not meant for Aqua look and feel should not the setting of this parameter instead throw a helpful error saying this

Re: Review Request of 8137169 : [macosx] Incorrect minimal heigh of JTabbedPane with more tabs

It is not usually a good idea to have a duplicated code which should be updated every time in several places. Is it possible to move the methods used both in AquaTruncatingTabbedPaneLayout and AquaTruncatingTabbedScrollPaneLayout to TabbedPaneLayout with different names and then reused?

Re: Review Request of 8137169 : [macosx] Incorrect minimal heigh of JTabbedPane with more tabs

Hi Alexander, The issue only applies for ScrollingTabbedPane and hence this fix. With Regards, Avik Niyogi > On 16-Mar-2016, at 4:51 pm, Alexander Scherbatiy > wrote: > > > Does the same issue affects the AquaTabbedPaneContrastUI? > > Thanks, > Alexandr. > >

Re: Review Request of 8137169 : [macosx] Incorrect minimal heigh of JTabbedPane with more tabs

Hi Alexander, Thank you for the inputs. I agree with you and did feel the need for removing duplicate code as well. But as per an earlier review input, changes to the super call lay outing is not accepted. This was the only other feasible solution. Created redundant code in this process, but

Re: Review Request of 8137169 : [macosx] Incorrect minimal heigh of JTabbedPane with more tabs

I would think about something like: - public class TabbedPaneLayout implements LayoutManager { protected int basePreferredTabAreaWidth(final int tabPlacement, final int height) { // TabbedPaneLayout preferredTabAreaWidth implementation }

Re: Review Request of 8137169 : [macosx] Incorrect minimal heigh of JTabbedPane with more tabs

Hi All, Please review code changes done as with inputs provided. http://cr.openjdk.java.net/~aniyogi/8137169/webrev.01/ Also, albeit the title of issue mentioned is as above, the injection of issue occurs because

Re: Review Request of 8137169 : [macosx] Incorrect minimal heigh of JTabbedPane with more tabs

Hello Avik Let me make it clear I don't approve the proposed fix and ask you to do additional evaluation. Every LookAndFeel is different and it doesn't make much sense to compare Metal LaF with AquaLaf. The AquaLaf mimics the native MacOS controls and therefore look quite different from any

Re: Review Request of 8137169 : [macosx] Incorrect minimal heigh of JTabbedPane with more tabs

Hello Avik, Fix looks good to me. Can you please check if test case works on windows and linux. Regards, Rajeev Chamyal From: Avik Niyogi Sent: 29 February 2016 09:46 To: Sergey Bylokhov; Alexander Scherbatiy; Rajeev Chamyal; swing-dev@openjdk.java.net Subject: Re: Review Request

Re: Review Request of 8137169 : [macosx] Incorrect minimal heigh of JTabbedPane with more tabs

Gentle reminder. Please review this fix. > On 26-Feb-2016, at 10:39 am, Avik Niyogi wrote: > > The issue is with setting of TabbedPaneScrollLayout() for the option > JTabbedPane.SCROLL_TAB_LAYOUT as is enabled in the test code > and not TabbedPaneLayout() as which is

Re: Review Request of 8137169 : [macosx] Incorrect minimal heigh of JTabbedPane with more tabs

Hello Avik AquaTruncatingTabbedPaneLayout has a lot of code which is specific for the AquaTabbedPaneUI. I don't think setting the layout manager from the base class is the right solution here. If there is a problem with minimum size it should be fixed inside the AquaTabbedPaneUI Thanks

Review Request of 8137169 : [macosx] Incorrect minimal heigh of JTabbedPane with more tabs

Hi All, Kindly review the bug fix for JDK 9. Bug: https://bugs.openjdk.java.net/browse/JDK-8137169 Webrev: http://cr.openjdk.java.net/~aniyogi/8137169/webrev.00/ Issue: For Aqua Look,