Re: Review Request of 8146321: [macosx] JInternalFrame frame icon in wrong position on Mac L if icon is not ImageIcon

The fix looks good to me.   Regards, Rajeev Chamyal   From: Avik Niyogi Sent: 09 February 2016 11:43 To: Sergey Bylokhov; Alexandr Scherbatiy; Rajeev Chamyal Cc: swing-dev@openjdk.java.net Subject: Re: Review Request of 8146321: [macosx] JInternalFrame frame icon in wrong position on Mac L

Re: Review Request of 8146321: [macosx] JInternalFrame frame icon in wrong position on Mac L if icon is not ImageIcon

On 08.02.16 10:12, Avik Niyogi wrote: Hi Sergey, Please review webrev with changes as per the inputs provided: cr.openjdk.java.net/~aniyogi/8146321/webrev.06/ Looks fine. With Regards, Avik Niyogi On 08-Feb-2016, at 2:29 am, Sergey

Re: Review Request of 8146321: [macosx] JInternalFrame frame icon in wrong position on Mac L if icon is not ImageIcon

A gentle reminder. Please review webrev with changes as per the inputs provided: cr.openjdk.java.net/~aniyogi/8146321/webrev.06/ With Regards, Avik Niyogi > On 08-Feb-2016, at 12:42 pm, Avik Niyogi wrote: > > Hi

Re: Review Request of 8146321: [macosx] JInternalFrame frame icon in wrong position on Mac L if icon is not ImageIcon

Both updated methods have a typo, 0 will be returned if frame.getFrameIcon()==null: protected int getIconWidth(final JInternalFrame frame) { int width = 0; Icon icon = frame.getFrameIcon(); if (icon == null) { icon =

Re: Review Request of 8146321: [macosx] JInternalFrame frame icon in wrong position on Mac L if icon is not ImageIcon

Hi Sergey, Please review webrev with changes as per the inputs provided: cr.openjdk.java.net/~aniyogi/8146321/webrev.06/ With Regards, Avik Niyogi > On 08-Feb-2016, at 2:29 am, Sergey Bylokhov > wrote: > >

Re: Review Request of 8146321: [macosx] JInternalFrame frame icon in wrong position on Mac L if icon is not ImageIcon

The fix looks good to me. Thanks, Alexandr. On 2/3/2016 8:51 PM, Avik Niyogi wrote: Hi All, Please review the code changes made as per the inputs provided: http://cr.openjdk.java.net/~aniyogi/8146321/webrev.05/ With Regards,

Re: Review Request of 8146321: [macosx] JInternalFrame frame icon in wrong position on Mac L if icon is not ImageIcon

Hi All, Please review the code changes made as per the inputs provided: http://cr.openjdk.java.net/~aniyogi/8146321/webrev.04 With Regards, Avik Niyogi > On 02-Feb-2016, at 5:55 pm, Alexandr Scherbatiy >

Re: Review Request of 8146321: [macosx] JInternalFrame frame icon in wrong position on Mac L if icon is not ImageIcon

On 2/3/2016 12:47 AM, Avik Niyogi wrote: Hi All, Please review the code changes made as per the inputs provided: http://cr.openjdk.java.net/~aniyogi/8146321/webrev.04 326 g2.translate(0, 0); The translation to the zero

Re: Review Request of 8146321: [macosx] JInternalFrame frame icon in wrong position on Mac L if icon is not ImageIcon

On 02.02.16 15:25, Alexandr Scherbatiy wrote: The provided example should work with the check: "(icon instanceof Icon)" in the same way as with the check "(icon != null && (icon instanceof Icon))" because the used icon is not null and it implements Icon interface, should not it? Note

Re: Review Request of 8146321: [macosx] JInternalFrame frame icon in wrong position on Mac L if icon is not ImageIcon

Hi All, Please review the code changes made as per the inputs provided: http://cr.openjdk.java.net/~aniyogi/8146321/webrev.05/ With Regards, Avik Niyogi > On 03-Feb-2016, at 7:38 pm, Alexandr Scherbatiy >

Re: Review Request of 8146321: [macosx] JInternalFrame frame icon in wrong position on Mac L if icon is not ImageIcon

On 2/1/2016 11:25 PM, Avik Niyogi wrote: Hi All, Please review the code changes made as per inputs provided: cr.openjdk.java.net/~aniyogi/8146321/webrev.02 - is it possible to skip the ImageIcon parsing and handle it as others

Re: Review Request of 8146321: [macosx] JInternalFrame frame icon in wrong position on Mac L if icon is not ImageIcon

Hi Alexander, > On 02-Feb-2016, at 3:44 pm, Alexandr Scherbatiy > wrote: > > On 2/2/2016 1:50 AM, Avik Niyogi wrote: >> Hi All, >> Please review the code changes made as per the inputs provided: >> cr.openjdk.java.net/~aniyogi/8146321/webrev.03 >>

Re: Review Request of 8146321: [macosx] JInternalFrame frame icon in wrong position on Mac L if icon is not ImageIcon

On 2/2/2016 3:41 AM, Avik Niyogi wrote: Hi Alexander, On 02-Feb-2016, at 3:44 pm, Alexandr Scherbatiy > wrote: On 2/2/2016 1:50 AM, Avik Niyogi wrote: Hi All, Please review the code changes made as per the inputs

Re: Review Request of 8146321: [macosx] JInternalFrame frame icon in wrong position on Mac L if icon is not ImageIcon

Hi All, Please review the code changes made as per inputs provided: cr.openjdk.java.net/~aniyogi/8146321/webrev.02 With Regards, Avik Niyogi > On 20-Jan-2016, at 10:35 pm, Sergey Bylokhov > wrote: > > On

Re: Review Request of 8146321: [macosx] JInternalFrame frame icon in wrong position on Mac L if icon is not ImageIcon

On 20/01/16 18:43, Avik Niyogi wrote: if ((icon.getIconWidth() > sMaxIconWidth || icon.getIconHeight() > sMaxIconHeight)) { final Graphics2D g2 = (Graphics2D) g; final AffineTransform savedAT = g2.getTransform();

Re: Review Request of 8146321: [macosx] JInternalFrame frame icon in wrong position on Mac L if icon is not ImageIcon

On 1/20/2016 7:59 AM, Avik Niyogi wrote: Hi All, A gentle reminder, please review my code changes as in the webrev below in the mail trail. With Regards, Avik Niyogi On 18-Jan-2016, at 3:01 pm, Avik Niyogi > wrote: Hi Sergey, Please

Re: Review Request of 8146321: [macosx] JInternalFrame frame icon in wrong position on Mac L if icon is not ImageIcon

Hi All, A gentle reminder, please review my code changes as in the webrev below in the mail trail. With Regards, Avik Niyogi > On 18-Jan-2016, at 3:01 pm, Avik Niyogi wrote: > > Hi Sergey, > > Please review the webrev taking inputs as per the discussion before: >

Re: Review Request of 8146321: [macosx] JInternalFrame frame icon in wrong position on Mac L if icon is not ImageIcon

Hi Sergey, Please review the webrev taking inputs as per the discussion before: http://cr.openjdk.java.net/~aniyogi/8146321/webrev.01/ With Regards, Avik Niyogi > On 14-Jan-2016, at 12:55 pm, Avik Niyogi wrote: >

Re: Review Request of 8146321: [macosx] JInternalFrame frame icon in wrong position on Mac L if icon is not ImageIcon

Hi, Avik. In the fix you update getIconWidth() and getIconHeight, so now we take the Icon into account. but it seems if the Icon is bigger that the maximum size it will not be resided to 16x16, right? On 14/01/16 07:49, Avik Niyogi wrote: Hi All, Kindly review the bug fix for JDK 9. *Bug:*

Re: Review Request of 8146321: [macosx] JInternalFrame frame icon in wrong position on Mac L if icon is not ImageIcon

Hi Sergey, I have verified it with the test case as well. If a test case overrides these methods to imply a change with icons larger than 16x16 it will show that for ImageIcon and Icon as before. The resize of ImageIcon is only in case it has an image file that it will try to fit. I had a

Review Request of 8146321: [macosx] JInternalFrame frame icon in wrong position on Mac L if icon is not ImageIcon

Hi All, Kindly review the bug fix for JDK 9. Bug: https://bugs.openjdk.java.net/browse/JDK-8146321 Webrev: http://cr.openjdk.java.net/~aniyogi/8146321/webrev.00/ Issue: Under the Mac