Re: Review Request of 8148555: [macosx] An uncaught exception was raised entering Emoji into JTextArea

The fix looks good to me. Thanks, Alexandr. On 21/03/16 18:02, Sergey Bylokhov wrote: Looks fine then. On 18.03.16 8:46, Avik Niyogi wrote: Hi Sergey, I have tested the test cases as mentioned. 1) They are not related to the current fix 2) ScreenMenuBarInputTwice.java issue is not

Re: Review Request of 8148555: [macosx] An uncaught exception was raised entering Emoji into JTextArea

Looks fine then. On 18.03.16 8:46, Avik Niyogi wrote: Hi Sergey, I have tested the test cases as mentioned. 1) They are not related to the current fix 2) ScreenMenuBarInputTwice.java issue is not reproducible. 3) There is a test bug in ActionListenerCalledTwiceTest.java, hence a new test case

Re: Review Request of 8148555: [macosx] An uncaught exception was raised entering Emoji into JTextArea

Please take a look to my comment below before pushing this fix. On 14.03.16 16:18, Sergey Bylokhov wrote: Hi, Avik. Can you please take a look to these two tests before fixing this bug: TEST: javax/swing/JMenuItem/8139169/ScreenMenuBarInputTwice.java

Re: Review Request of 8148555: [macosx] An uncaught exception was raised entering Emoji into JTextArea

Hi Avik, Changes looks good to me. Regards, Manajit > On 21-Mar-2016, at 4:16 pm, Rajeev Chamyal wrote: > > Test code looks good to me. > > Regards, > Rajeev Chamyal > > From: Avik Niyogi > Sent: 21 March 2016 14:02 > To: Manajit Halder; Alexander Scherbatiy >

Re: Review Request of 8148555: [macosx] An uncaught exception was raised entering Emoji into JTextArea

Test code looks good to me.   Regards, Rajeev Chamyal   From: Avik Niyogi Sent: 21 March 2016 14:02 To: Manajit Halder; Alexander Scherbatiy Cc: swing-dev@openjdk.java.net; Rajeev Chamyal Subject: Re: Review Request of 8148555: [macosx] An uncaught exception was raised entering Emoji into

Re: Review Request of 8148555: [macosx] An uncaught exception was raised entering Emoji into JTextArea

Hi All, Please review the below code changes as per the inputs received. http://cr.openjdk.java.net/~aniyogi/8148555/webrev.01/ With Regards, Avik Niyogi > On 21-Mar-2016, at 12:45 pm, Rajeev Chamyal wrote: >

Re: Review Request of 8148555: [macosx] An uncaught exception was raised entering Emoji into JTextArea

Hello Avik,   I can’t comment on objective C code. As far as test is concerned below are my comments.   1)  UI should be created in Swing thread. 2)  Switch case in  actionPerformed should be refactored.   Regards, Rajeev Chamyal   From: Avik Niyogi Sent: 21 March 2016 12:20

Re: Review Request of 8148555: [macosx] An uncaught exception was raised entering Emoji into JTextArea

Hi Manajit, Please review the following code changes. With Regards, Avik Niyogi > On 21-Mar-2016, at 12:20 pm, Avik Niyogi wrote: > > Hi Rajeev, > Please review the following code changes. > > With Regards, > Avik Niyogi >> On 21-Mar-2016, at 12:17 pm, Avik Niyogi

Re: Review Request of 8148555: [macosx] An uncaught exception was raised entering Emoji into JTextArea

Hi Rajeev, Please review the following code changes. With Regards, Avik Niyogi > On 21-Mar-2016, at 12:17 pm, Avik Niyogi wrote: > > Hi Sergey, > > Please review the following code changes. > With Regards, > Avik Niyogi >> On 17-Mar-2016, at 7:03 pm, Alexander

Re: Review Request of 8148555: [macosx] An uncaught exception was raised entering Emoji into JTextArea

Hi Sergey, Please review the following code changes. With Regards, Avik Niyogi > On 17-Mar-2016, at 7:03 pm, Alexander Scherbatiy > wrote: > > > The fix looks good to me. > > Just a small note: it is better to remove comment "527 //" since it > does

Re: Review Request of 8148555: [macosx] An uncaught exception was raised entering Emoji into JTextArea

Hi Sergey, I have tested the test cases as mentioned. 1) They are not related to the current fix 2) ScreenMenuBarInputTwice.java issue is not reproducible. 3) There is a test bug in ActionListenerCalledTwiceTest.java, hence a new test case called ScreenMenuBarInputTwice.java was created to

Re: Review Request of 8148555: [macosx] An uncaught exception was raised entering Emoji into JTextArea

It can be made into a class method, but herein this case it is needed for that instance only and hence the need for instance method and referred with “self”. With Regards, Avik Niyogi > On 16-Mar-2016, at 11:55 pm, Alexander Scherbatiy > wrote: > > > Could the

Re: Review Request of 8148555: [macosx] An uncaught exception was raised entering Emoji into JTextArea

Could the -(NSMutableString *) parseString: method be declared as class method instead of instance? Thanks, Alexandr. On 14/03/16 17:18, Sergey Bylokhov wrote: Hi, Avik. Can you please take a look to these two tests before fixing this bug: TEST:

Re: Review Request of 8148555: [macosx] An uncaught exception was raised entering Emoji into JTextArea

The fix looks good to me. Just a small note: it is better to remove comment "527 //" since it does not have a description. Thanks, Alexandr. On 17/03/16 17:21, Avik Niyogi wrote: It can be made into a class method, but herein this case it is needed for that instance only and hence

Re: Review Request of 8148555: [macosx] An uncaught exception was raised entering Emoji into JTextArea

Hi, Avik. Can you please take a look to these two tests before fixing this bug: TEST: javax/swing/JMenuItem/8139169/ScreenMenuBarInputTwice.java -- TEST: javax/swing/JMenuItem/ActionListenerCalledTwice/ActionListenerCalledTwiceTest.java I

Review Request of 8148555: [macosx] An uncaught exception was raised entering Emoji into JTextArea

Hi All, Kindly review the bug fix for JDK 9. Bug: https://bugs.openjdk.java.net/browse/JDK-8148555 Webrev: http://cr.openjdk.java.net/~aniyogi/8148555/webrev.00/ Issue: Emoji