Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

2016-03-21 Thread Sergey Bylokhov
ds, Rajeev Chamyal *From:*Avik Niyogi *Sent:* 20 January 2016 12:23 *To:* Rajeev Chamyal; Alexander Scherbatiy; Sergey Bylokhov *Cc:*swing-dev@openjdk.java.net <mailto:swing-dev@openjdk.java.net><mailto:swing-dev@openjdk.java.net> *Subject:* Re: Review request for 8015

Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

2016-03-21 Thread Avik Niyogi
Jan-2016, at 4:30 pm, Alexander Scherbatiy >>>>>> <alexandr.scherba...@oracle.com <mailto:alexandr.scherba...@oracle.com> >>>>>> <mailto:alexandr.scherba...@oracle.com >>>>>> <mailto:alexandr.scherba...@oracle.com>>> wrote: >

Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

2016-03-20 Thread Avik Niyogi
r.scherba...@oracle.com >>>>> <mailto:alexandr.scherba...@oracle.com>>> wrote: >>>>> >>>>> >>>>> The fix looks good to me. >>>>> >>>>> Thanks, >>>>> Alexandr. >>>>

Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

2016-03-19 Thread Alexander Scherbatiy
ing-dev@openjdk.java.net <mailto:swing-dev@openjdk.java.net> *Subject:* Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call Hi All, Please review the code changes made as with inputs for the webr

Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

2016-03-19 Thread Sergey Bylokhov
penjdk.java.net> *Subject:* Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call Hi All, Please review the code changes made as with inputs for the webrev: http://cr.openjdk.java.net/~aniyogi/8015

Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

2016-01-20 Thread Avik Niyogi
t;> Alexandr. >>> >>> On 1/20/2016 12:47 PM, Rajeev Chamyal wrote: >>>> >>>> Looks good to me. >>>> >>>> Regards, >>>> >>>> Rajeev Chamyal >>>> >>>> *From:*Avik Niyogi >>&

Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

2016-01-20 Thread Avik Niyogi
ood to me. >> >> Regards, >> >> Rajeev Chamyal >> >> *From:*Avik Niyogi >> *Sent:* 20 January 2016 12:23 >> *To:* Rajeev Chamyal; Alexander Scherbatiy; Sergey Bylokhov >> *Cc:* swing-dev@openjdk.java.net >> *Subject:* Re: R

Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

2016-01-20 Thread Avik Niyogi
hamyal >>> >>> *From:*Avik Niyogi >>> *Sent:* 20 January 2016 12:23 >>> *To:* Rajeev Chamyal; Alexander Scherbatiy; Sergey Bylokhov >>> *Cc:* swing-dev@openjdk.java.net <mailto:swing-dev@openjdk.java.net> >>> *Subject:* Re: Review request for

Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

2016-01-20 Thread Sergey Bylokhov
*From:*Avik Niyogi *Sent:*20 January 2016 10:20 *To:*Rajeev Chamyal *Cc:*Alexander Scherbatiy; Sergey Bylokhov *Subject:*Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

2016-01-20 Thread Avik Niyogi
t; >>> *From:*Avik Niyogi >>> *Sent:* 20 January 2016 12:23 >>> *To:* Rajeev Chamyal; Alexander Scherbatiy; Sergey Bylokhov >>> *Cc:* swing-dev@openjdk.java.net >>> *Subject:* Re: Review request for 8015748: JProgressbar >>> with Aqua LaF i

Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

2016-01-20 Thread Alexander Scherbatiy
:* Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call Hi All, Please review the code changes made as with inputs for the webrev: http://cr.openjdk.java.net/~aniyogi/8015748/webrev.07/ <h

Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

2016-01-20 Thread Sergey Bylokhov
January 2016 12:23 *To:* Rajeev Chamyal; Alexander Scherbatiy; Sergey Bylokhov *Cc:* swing-dev@openjdk.java.net *Subject:* Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call Hi All, Please review the code

Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

2016-01-19 Thread Avik Niyogi
Hi All, A gentle reminder. Please review my code changes as mentioned in the webrev below as available in the link in the mail trail. With Regards, Avik Niyogi > On 18-Jan-2016, at 11:34 am, Avik Niyogi wrote: > > Hi All, Please find the changes as provided with

Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

2016-01-19 Thread Rajeev Chamyal
Bylokhov Subject: Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call Hi Rajeev and Sergey, A gentle reminder. Kindly request to complete the pending review of my code changes in the webrev: http

Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

2016-01-19 Thread Avik Niyogi
2016 10:20 > To: Rajeev Chamyal > Cc: Alexander Scherbatiy; Sergey Bylokhov > Subject: Re: Review request for 8015748: JProgressbar with Aqua > LaF ignores > JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) > call > > Hi Rajeev and Sergey, > &g

Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

2016-01-19 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 19/01/16 15:27, Avik Niyogi wrote: Hi All, A gentle reminder. Please review my code changes as mentioned in the webrev below as available in the link in the mail trail. With Regards, Avik Niyogi On 18-Jan-2016, at 11:34 am, Avik Niyogi

Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

2016-01-14 Thread Sergey Bylokhov
Probably I missed something but why we need two tests? Note that the manual test is not marked as manual, which means that it will be run during the regular run?(even if -a option is provided to jtreg). Please check your other review requests for this issue. moreover on my system

Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

2016-01-14 Thread Alexander Scherbatiy
On 1/14/2016 8:18 AM, Avik Niyogi wrote: Hi All, Please find changes as provided with incorporation of inputs: http://cr.openjdk.java.net/~aniyogi/8015748/webrev.04/ It is better to restore the graphics transform after the progress

Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

2016-01-14 Thread Avik Niyogi
Hi All, Please find the changes as provided with incorporation of inputs: http://cr.openjdk.java.net/~aniyogi/8015748/webrev.05/ With Regards, Avik Niyogi > On 14-Jan-2016, at 3:18 pm, Alexander Scherbatiy >

Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

2016-01-14 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 1/14/2016 1:11 PM, Avik Niyogi wrote: Hi All, Please find the changes as provided with incorporation of inputs: http://cr.openjdk.java.net/~aniyogi/8015748/webrev.05/ With

Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

2016-01-13 Thread Alexander Scherbatiy
On 1/13/2016 9:28 AM, Avik Niyogi wrote: Hi All, Please find changes as provided with incorporation of inputs: http://cr.openjdk.java.net/~aniyogi/8015748/webrev.03/ It looks like a string on a vertical progress bar with the right

Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

2016-01-13 Thread Avik Niyogi
Hi All, Please find changes as provided with incorporation of inputs: http://cr.openjdk.java.net/~aniyogi/8015748/webrev.04/ With Regards, Avik Niyogi > On 13-Jan-2016, at 7:02 pm, Alexander Scherbatiy >

Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

2016-01-12 Thread Avik Niyogi
Hi All, Please find changes as provided with incorporation of inputs: http://cr.openjdk.java.net/~aniyogi/8015748/webrev.03/ With Regards, Avik Niyogi > On 12-Jan-2016, at 11:49 pm, Alexander Scherbatiy >

Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

2016-01-12 Thread Avik Niyogi
Hi All, Please find the code changes in fix as with the inputs received for the same. http://cr.openjdk.java.net/~aniyogi/8015748/webrev.02/ With Regards, Avik Niyogi > On 11-Jan-2016, at 3:55 pm, Semyon Sadetsky

Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

2016-01-11 Thread Semyon Sadetsky
Hi Avik, Shouldn't the graphics transformation be restored before the paintString() call? It seems to me that left/right insets need to be swapped for right-to-left painting with mirroring graphics transformation. --Semyon On 1/5/2016 1:22 PM, Avik Niyogi wrote: Hi All, Please find

Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

2016-01-05 Thread Avik Niyogi
Hi All, Please find webrev with inputs as provided: http://cr.openjdk.java.net/~aniyogi/8015748/webrev.01/ With Regards, Avik Niyogi > On 23-Dec-2015, at 7:29 pm, Alexander Scherbatiy > wrote: > > > -

Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

2015-12-23 Thread Alexander Scherbatiy
  - please check that the progress bar string (progressBar.setString()/setStringPainted()) is painted correctly.   - is it possible to write an automated test for the fix?   Thanks,   Alexandr. On 12/21/2015 11:47 AM, Avik Niyogi wrote:

Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

2015-12-21 Thread Avik Niyogi
Hi All, Kindly review the bug fix for JDK 9. Bug: https://bugs.openjdk.java.net/browse/JDK-8015748 Webrev: http://cr.openjdk.java.net/~aniyogi/8015748/webrev.00/ Issue: The manual