Re: Review request for JDK-8078489 JSpinner using SpinnerNumberModel doesn't honor orientation flag

2015-12-24 Thread Sergey Bylokhov
://cr.openjdk.java.net/~rchamyal/8078489/webrev.01/ Regards, Rajeev Chamyal -Original Message- From: Sergey Bylokhov Sent: 23 December 2015 21:08 To: Rajeev Chamyal; Alexander Scherbatiy; Prasanta Sadhukhan; swing-dev@openjdk.java.net Subject: Re: Review request for JDK-8078489 JSpinner using

Re: Review request for JDK-8078489 JSpinner using SpinnerNumberModel doesn't honor orientation flag

2015-12-23 Thread Rajeev Chamyal
- From: Sergey Bylokhov Sent: 23 December 2015 21:08 To: Rajeev Chamyal; Alexander Scherbatiy; Prasanta Sadhukhan; swing-dev@openjdk.java.net Subject: Re: Review request for JDK-8078489 JSpinner using SpinnerNumberModel doesn't honor orientation flag Hi, Rajeev. A few notes: - the cast in th

Re: Review request for JDK-8078489 JSpinner using SpinnerNumberModel doesn't honor orientation flag

2015-12-23 Thread Sergey Bylokhov
Hi, Rajeev. A few notes: - the cast in the "if (o != (ComponentOrientation) e.getOldValue())" is not necessary. - Is it possible to cover all look and feels in the test? - Why the test is for osx only? On 22/12/15 12:54, Rajeev Chamyal wrote: Hello All, Please review the following fix for

Re: Review request for JDK-8078489 JSpinner using SpinnerNumberModel doesn't honor orientation flag

2015-12-23 Thread Alexander Scherbatiy
  The fix looks good to me.   Thanks,   Alexandr. On 12/22/2015 12:54 PM, Rajeev Chamyal wrote: Hello All,   Please review the following fix for Jdk9:   Bug: https://bugs.

Review request for JDK-8078489 JSpinner using SpinnerNumberModel doesn't honor orientation flag

2015-12-22 Thread Rajeev Chamyal
Hello All, Please review the following fix for Jdk9: Bug: https://bugs.openjdk.java.net/browse/JDK-8078489 Webrev: http://cr.openjdk.java.net/~rchamyal/8078489/webrev.00/ Issue: Jspinner text in Aqua LAF is not following Right to left component orientation. Cause: Code for JSpinner Co