Re: RfR: JDK-8071334, Investigate JAB changes required to support the version string change

2015-12-10 Thread Pete Brunet
On 12/10/15 3:17 AM, Alexander Scherbatiy wrote: > > The fix looks good to me. > > I have just a question about the commented roles like > AccessibleRole.STATUS_BAR in the AccessBridge. > Are there use cases where they can be used? This turns out to be an interesting question. All those roles

Re: RfR: JDK-8071334, Investigate JAB changes required to support the version string change

2015-12-10 Thread Pete Brunet
On 12/10/15 3:17 AM, Alexander Scherbatiy wrote: > > The fix looks good to me. > > I have just a question about the commented roles like > AccessibleRole.STATUS_BAR in the AccessBridge. > Are there use cases where they can be used? I will check with some ATVs (Assistive Technology Vendors). >

Re: RfR: JDK-8071334, Investigate JAB changes required to support the version string change

2015-12-10 Thread Alexander Scherbatiy
The fix looks good to me. I have just a question about the commented roles like AccessibleRole.STATUS_BAR in the AccessBridge. Are there use cases where they can be used? Thanks, Alexandr. On 12/10/2015 1:59 AM, Pete Brunet wrote: Please review this simple patch: http://cr.openjdk.java

Re: RfR: JDK-8071334, Investigate JAB changes required to support the version string change

2015-12-09 Thread Vivi An
Hi Pete, looks good to me. Thanks Vivi On 12/9/2015 2:59 PM, Pete Brunet wrote: Please review this simple patch: http://cr.openjdk.java.net/~ptbrunet/JDK-8071334/webrev.00/ There was some old "if JDK 1.4" code that was removed via this patch. There was no version string change impact; the JA

RfR: JDK-8071334, Investigate JAB changes required to support the version string change

2015-12-09 Thread Pete Brunet
Please review this simple patch: http://cr.openjdk.java.net/~ptbrunet/JDK-8071334/webrev.00/ There was some old "if JDK 1.4" code that was removed via this patch. There was no version string change impact; the JAB (Java Access Bridge) just passes the java.version property through via the JAB GetV