Re: RfR JDK-8145207 [macosx] JList, VO can't access non-visible list items

2016-07-19 Thread Anton Tarasov
Thanks, Pete! Keeping an eye on JDK-8160893 status as well, as we discussed. Regards, Anton. On 7/18/2016 11:47 PM, Pete Brunet wrote: Anton, If you'd like to check out the changeset I just pushed it. Pete On 7/18/16 3:25 PM, Pete Brunet wrote: JPRT ran OK. On 7/15/16 9:24 AM, Pete Brunet

Re: RfR JDK-8145207 [macosx] JList, VO can't access non-visible list items

2016-07-18 Thread Pete Brunet
Anton, If you'd like to check out the changeset I just pushed it. Pete On 7/18/16 3:25 PM, Pete Brunet wrote: > JPRT ran OK. > > On 7/15/16 9:24 AM, Pete Brunet wrote: >> On 7/15/16 8:42 AM, Alexandr Scherbatiy wrote: >>> On 7/15/2016 4:39 AM, Pete Brunet wrote: Hi Alexandr, Thanks very much

Re: RfR JDK-8145207 [macosx] JList, VO can't access non-visible list items

2016-07-18 Thread Pete Brunet
JPRT ran OK. On 7/15/16 9:24 AM, Pete Brunet wrote: > > On 7/15/16 8:42 AM, Alexandr Scherbatiy wrote: >> On 7/15/2016 4:39 AM, Pete Brunet wrote: >>> Hi Alexandr, Thanks very much for the review. I updated the webrev. >>> See >>> http://cr.openjdk.java.net/~ptbrunet/JDK-8145207/webrev.01/ >>

Re: RfR JDK-8145207 [macosx] JList, VO can't access non-visible list items

2016-07-15 Thread Pete Brunet
On 7/15/16 8:42 AM, Alexandr Scherbatiy wrote: > On 7/15/2016 4:39 AM, Pete Brunet wrote: >> Hi Alexandr, Thanks very much for the review. I updated the webrev. >> See >> http://cr.openjdk.java.net/~ptbrunet/JDK-8145207/webrev.01/ > The fix looks good to me. Thank you Alexandr. Looking for o

Re: RfR JDK-8145207 [macosx] JList, VO can't access non-visible list items

2016-07-15 Thread Alexandr Scherbatiy
On 7/15/2016 4:39 AM, Pete Brunet wrote: Hi Alexandr, Thanks very much for the review. I updated the webrev. See http://cr.openjdk.java.net/~ptbrunet/JDK-8145207/webrev.01/ The fix looks good to me. From your separate email you suggested the following in order to provide the AccessibleAct

Re: RfR JDK-8145207 [macosx] JList, VO can't access non-visible list items

2016-07-14 Thread Pete Brunet
Hi Alexandr, Thanks very much for the review. I updated the webrev. See http://cr.openjdk.java.net/~ptbrunet/JDK-8145207/webrev.01/ >From your separate email you suggested the following in order to provide the AccessibleAction interface without changing the public API of JList.AccessibleJList.Ac

Re: RfR JDK-8145207 [macosx] JList, VO can't access non-visible list items

2016-07-04 Thread Alexandr Scherbatiy
On 6/18/2016 5:31 AM, Pete Brunet wrote: Please review the following patch. Bug: https://bugs.openjdk.java.net/browse/JDK-8145207 Patch: http://cr.openjdk.java.net/~ptbrunet/JDK-8145207/webrev.00/ This fixes the following functionality that was not working with the JList of ListDemo of SwingSet

Re: RfR JDK-8145207 [macosx] JList, VO can't access non-visible list items

2016-06-24 Thread Anton Tarasov
Hi Pete, That’s a problem, yes. Though, even without that action functionality, JList becomes navigate-able with VO (am I right?) that is quite the difference to what it is now. So, if you don’t find any way to make it into jdk8, a partial fix would also be valuable. Thanks, Anton. > On 24

Re: RfR JDK-8145207 [macosx] JList, VO can't access non-visible list items

2016-06-23 Thread Pete Brunet
Hi Anton, The way it is I can't backport it because I changed the class signature of https://docs.oracle.com/javase/8/docs/api/javax/swing/JList.AccessibleJList.AccessibleJListChild.html by adding "implements AccessibleAction" and this will cause a JCK failure. Next week I'll see if there is any w

Re: RfR JDK-8145207 [macosx] JList, VO can't access non-visible list items

2016-06-23 Thread Anton Tarasov
Hi Pete, > On 22 Jun 2016, at 17:41, Pete Brunet wrote: > > Thanks Anton, I fixed the first two issues. For the last one did you try > VO+Shift+downarrow first to interact with the list? Now I did try it and it worked fine, thanks for letting me know. Please, share your thoughts on backporti

Re: RfR JDK-8145207 [macosx] JList, VO can't access non-visible list items

2016-06-22 Thread Pete Brunet
Thanks Anton, I fixed the first two issues. For the last one did you try VO+Shift+downarrow first to interact with the list? Pete On 6/22/16 4:28 AM, Anton Tarasov wrote: > Hi Pete, > > I went through the fix and found it looking fine to me, except for > these two minor issues: > > - JavaCompone

Re: RfR JDK-8145207 [macosx] JList, VO can't access non-visible list items

2016-06-22 Thread Anton Tarasov
Hi Pete, I went through the fix and found it looking fine to me, except for these two minor issues: - JavaComponentAccessibility.m In this chunk: +- (void)postSelectionChanged +{ +NSAccessibilityPostNotification(self, NSAccessibilitySelectedChildrenChangedNotification); +} AWT_ASSERT_APP

RfR JDK-8145207 [macosx] JList, VO can't access non-visible list items

2016-06-17 Thread Pete Brunet
Please review the following patch. Bug: https://bugs.openjdk.java.net/browse/JDK-8145207 Patch: http://cr.openjdk.java.net/~ptbrunet/JDK-8145207/webrev.00/ This fixes the following functionality that was not working with the JList of ListDemo of SwingSet2. - start VoiceOver - start SwingSet2 - st