Re: RfR JDK-8145735, Tests api/javax_swing/JTabbedPane/AccessibleJTabbedPane/* are failing

2016-01-14 Thread Vivi An
+1, Thanks Vivi On 1/14/2016 4:02 AM, Alexander Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 1/14/2016 12:06 AM, Pete Brunet wrote: How does this look? http://cr.openjdk.java.net/~ptbrunet/JDK-8145735/webrev.01/ Pete On 1/13/16 7:16 AM, Alexander Scherbatiy wrot

Re: RfR JDK-8145735, Tests api/javax_swing/JTabbedPane/AccessibleJTabbedPane/* are failing

2016-01-14 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 1/14/2016 12:06 AM, Pete Brunet wrote: How does this look? http://cr.openjdk.java.net/~ptbrunet/JDK-8145735/webrev.01/ Pete On 1/13/16 7:16 AM, Alexander Scherbatiy wrote: On 1/13/2016 1:12 AM, Pete Brunet wrote: Hi Alexandr, On 1/12/16

Re: RfR JDK-8145735, Tests api/javax_swing/JTabbedPane/AccessibleJTabbedPane/* are failing

2016-01-13 Thread Pete Brunet
How does this look? http://cr.openjdk.java.net/~ptbrunet/JDK-8145735/webrev.01/ Pete On 1/13/16 7:16 AM, Alexander Scherbatiy wrote: > On 1/13/2016 1:12 AM, Pete Brunet wrote: >> Hi Alexandr, >> >> On 1/12/16 1:03 PM, Alexander Scherbatiy wrote: >>> It seems that there still is the case when tab

Re: RfR JDK-8145735, Tests api/javax_swing/JTabbedPane/AccessibleJTabbedPane/* are failing

2016-01-13 Thread Alexander Scherbatiy
On 1/13/2016 1:12 AM, Pete Brunet wrote: Hi Alexandr, On 1/12/16 1:03 PM, Alexander Scherbatiy wrote: It seems that there still is the case when tab titles are empty string, tab components are null, components are not null and the correct index should be returned for the given page. In the cod

Re: RfR JDK-8145735, Tests api/javax_swing/JTabbedPane/AccessibleJTabbedPane/* are failing

2016-01-12 Thread Pete Brunet
Hi Alexandr, On 1/12/16 1:03 PM, Alexander Scherbatiy wrote: > > It seems that there still is the case when tab titles are empty > string, tab components are null, components are not null and the > correct index should be returned for the given page. In the code of the current webrev (webrev.00) i

Re: RfR JDK-8145735, Tests api/javax_swing/JTabbedPane/AccessibleJTabbedPane/* are failing

2016-01-12 Thread Alexander Scherbatiy
It seems that there still is the case when tab titles are empty string, tab components are null, components are not null and the correct index should be returned for the given page. May be it is better to replace searching the page index by tab component to by component? We already do this

RfR JDK-8145735, Tests api/javax_swing/JTabbedPane/AccessibleJTabbedPane/* are failing

2016-01-11 Thread Pete Brunet
Please review this patch: http://cr.openjdk.java.net/~ptbrunet/JDK-8145735/webrev.00/ The issue being resolved is that the JTabbedPane code can't solely rely on tabComponent when fetching the index in the parent component. tabComponent is optionally used and its presence indicates that the assoc