Re: Swing Dev [9] Review Request: 6573305 Animated icon is not visible by click on menu

2015-01-13 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 1/12/2015 9:11 PM, Sergey Bylokhov wrote: Hello. Please review a fix for jdk 9. When we paint some image on component we use this component as an observer, which will be called when the image should be repainted(in case of animated gif

Re: Swing Dev [9] Review Request: 6573305 Animated icon is not visible by click on menu

2015-01-13 Thread Alexander Zvegintsev
Hello Sergey, the fix looks good to me. Thanks, Alexander. On 01/12/2015 09:11 PM, Sergey Bylokhov wrote: Hello. Please review a fix for jdk 9. When we paint some image on component we use this component as an observer, which will be called when the image should be repainted(in case of

Swing Dev [9] Review Request: 6573305 Animated icon is not visible by click on menu

2015-01-12 Thread Sergey Bylokhov
Hello. Please review a fix for jdk 9. When we paint some image on component we use this component as an observer, which will be called when the image should be repainted(in case of animated gif for example). But our code in the AbstractButton.imageUpdate() will replace correct Icon to null if