Re: Swing Dev [9] Review Request: JDK-8079428 [TEST_BUG] Test javax/swing/plaf/windows/6921687/bug6921687.java fails

2015-05-08 Thread Jonathan Gibbons
There is no issue here and the tests that used to work with jtreg b05 didn't do what you thought they did. Just look at the .jtr file and see what jtreg actually did before. First, you need to realize that @build is a shorthand for @run build.The section on shorthands is in the very next

Re: Swing Dev [9] Review Request: JDK-8079428 [TEST_BUG] Test javax/swing/plaf/windows/6921687/bug6921687.java fails

2015-05-06 Thread pooja chopra
Hello, Please review a fix for issue: 8079428 [TEST_BUG] Test javax/swing/plaf/windows/6921687/bug6921687.java Test bug fix. https://bugs.openjdk.java.net/browse/JDK-8079428 The webrev is : http://cr.openjdk.java.net/~pchopra/8079428/webrev.00/ Thanks, Pooja

Re: Swing Dev [9] Review Request: JDK-8079428 [TEST_BUG] Test javax/swing/plaf/windows/6921687/bug6921687.java fails

2015-05-06 Thread Alexander Zvegintsev
Hello Pooja, the fix looks fine to me. Thanks, Alexander. On 05/06/2015 09:18 AM, pooja chopra wrote: Hello, Please review a fix for issue: 8079428 [TEST_BUG] Test javax/swing/plaf/windows/6921687/bug6921687.java Test bug fix. https://bugs.openjdk.java.net/browse/JDK-8079428 The webrev is :

Re: Swing Dev [9] Review Request: JDK-8079428 [TEST_BUG] Test javax/swing/plaf/windows/6921687/bug6921687.java fails

2015-05-06 Thread Sergey Bylokhov
Hello, It seems that this is a bug in the jtreg because according its specification: If no |@run| tags are present in a defining file, a default is assumed depending upon the file's filename extension File type Default Notes .java |@run main name| name is the name of the

Re: Swing Dev [9] Review Request: JDK-8079428 [TEST_BUG] Test javax/swing/plaf/windows/6921687/bug6921687.java fails

2015-05-06 Thread Yuri Nesterenko
I guess the @build instruction here adds some degree of uncertainty: jtreg may not be able to determine which class to run. -yan On 05/06/2015 04:45 PM, Alexey Ivanov wrote: Hello, I faced this problem too, and only with JDK 9. If there's no @run tag in the java file, the main method of the

Re: Swing Dev [9] Review Request: JDK-8079428 [TEST_BUG] Test javax/swing/plaf/windows/6921687/bug6921687.java fails

2015-05-06 Thread Alexey Ivanov
Hello, I faced this problem too, and only with JDK 9. If there's no @run tag in the java file, the main method of the test is not run. However in my case, the test reported success where I expected failure. Regards, Alexey On 06.05.2015 15:29, Sergey Bylokhov wrote: Hello, It seems that

Re: Swing Dev [9] Review Request: JDK-8079428 [TEST_BUG] Test javax/swing/plaf/windows/6921687/bug6921687.java fails

2015-05-06 Thread Alexander Scherbatiy
This is the known issue in jtreg: CODETOOLS-7901378 Test result error when @build used without @run main https://bugs.openjdk.java.net/browse/CODETOOLS-7901378 It is closed as not an issue but I would argue against it. It definitely worked in jtreg 4.1 fcs b05. Why tests which pass

Re: Swing Dev [9] Review Request: JDK-8079428 [TEST_BUG] Test javax/swing/plaf/windows/6921687/bug6921687.java fails

2015-05-06 Thread Sergey Bylokhov
After discussion we confirm that the problem in the tests. This fix looks fine. On 06.05.15 17:11, Alexander Scherbatiy wrote: This is the known issue in jtreg: CODETOOLS-7901378 Test result error when @build used without @run main https://bugs.openjdk.java.net/browse/CODETOOLS-7901378