Re: Swing Dev [9] Review request for 8068040 [macosx] Combo box consuming ENTER key events

2015-01-13 Thread Sergey Bylokhov
Hi, Alexander. The fix looks good. On 13.01.2015 17:06, Alexander Scherbatiy wrote: Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8068040/webrev.01/ The aquaEnterPressed is renamed to enterPressed in AquaComboBoxUI and AquaKeyBindings clases. Thanks, Alexandr.

Re: Swing Dev [9] Review request for 8068040 [macosx] Combo box consuming ENTER key events

2015-01-13 Thread Alexander Zvegintsev
Hello Alexander, the fix looks good to me. Thanks, Alexander. On 01/13/2015 06:10 PM, Sergey Bylokhov wrote: Hi, Alexander. The fix looks good. On 13.01.2015 17:06, Alexander Scherbatiy wrote: Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8068040/webrev.01/

Swing Dev [9] Review request for 8068040 [macosx] Combo box consuming ENTER key events

2015-01-12 Thread Alexander Scherbatiy
Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8068040 webrev: http://cr.openjdk.java.net/~alexsch/8068040/webrev.00 BasicComboBoxUI has a special workaround to forward the enter pressed event on the editable combo box to the default button. The