Re: Swing Dev JDK 9 RFR of JDK-8055059: JDK9b22 public API exposes package private classes, take 2

2015-01-12 Thread Sergey Bylokhov
Hi, Joe. The fix looks good. On 10.01.2015 3:23, Joseph D. Darcy wrote: Hello, The previously proposed fix for JDK-8055059: JDK9b22 public API exposes package private classes was rejected during code review: http://mail.openjdk.java.net/pipermail/swing-dev/2014-August/003829.html

Re: Swing Dev JDK 9 RFR of JDK-8055059: JDK9b22 public API exposes package private classes, take 2

2015-01-12 Thread Alexander Scherbatiy
The fix looks good to me. Could you formate the code to have a space between type cast (UndoPosRef) and the positions variable? 780 UndoPosRef ref = (UndoPosRef)positions.elementAt(counter); Thanks, Alexandr. On 1/10/2015 3:23 AM, Joseph D. Darcy wrote: Hello,

Re: Swing Dev JDK 9 RFR of JDK-8055059: JDK9b22 public API exposes package private classes, take 2

2015-01-12 Thread Phil Race
+1 -phil. On 1/12/2015 1:13 AM, Sergey Bylokhov wrote: Hi, Joe. The fix looks good. On 10.01.2015 3:23, Joseph D. Darcy wrote: Hello, The previously proposed fix for JDK-8055059: JDK9b22 public API exposes package private classes was rejected during code review:

Swing Dev JDK 9 RFR of JDK-8055059: JDK9b22 public API exposes package private classes, take 2

2015-01-09 Thread Joseph D. Darcy
Hello, The previously proposed fix for JDK-8055059: JDK9b22 public API exposes package private classes was rejected during code review: http://mail.openjdk.java.net/pipermail/swing-dev/2014-August/003829.html http://mail.openjdk.java.net/pipermail/swing-dev/2014-August/003830.html Here