Re: [9] Review request for 7094099: DropDown List of JComboBox detached

2014-02-17 Thread Alexander Scherbatiy
The fix looks good for me. Thanks, Alexandr. On 2/14/2014 7:27 PM, anton nashatyrev wrote: Hello, could you please review the following fix: fix: http://cr.openjdk.java.net/~anashaty/7094099/9/webrev.00/ bug: https://bu

Re: [9] Review request for 7094099: DropDown List of JComboBox detached

2014-02-17 Thread Sergey Bylokhov
The fix looks good. Not that null check in (o != null && o instanceof ChangeListener) is unnecessary. On 14.02.2014 20:12, anton nashatyrev wrote: Hi Sergey, The listener here is intended for the AppContext whole lifecycle and should not be removed until AppContext is disposed. Just p