Re: RFR: [9] [JDK-8081491] The case print incomplete.

2015-09-10 Thread Sergey Bylokhov
On 10.09.15 9:36, prasanta sadhukhan wrote: Please review the modified webrev which solves this artifacts. http://cr.openjdk.java.net/~psadhukhan/8081491/webrev.05/ What will happen if the table will be added to the jpanel and the jpanel will be added to JScrollPane? Will this configuration wo

Re: RFR: [9] [JDK-8081491] The case print incomplete.

2015-09-10 Thread prasanta sadhukhan
On 9/10/2015 3:42 PM, Sergey Bylokhov wrote: On 10.09.15 9:36, prasanta sadhukhan wrote: Please review the modified webrev which solves this artifacts. http://cr.openjdk.java.net/~psadhukhan/8081491/webrev.05/ What will happen if the table will be added to the jpanel and the jpanel will be

Re: RFR: [9] [JDK-8081491] The case print incomplete.

2015-09-10 Thread Sergey Bylokhov
On 10.09.15 13:35, prasanta sadhukhan wrote: On 9/10/2015 3:42 PM, Sergey Bylokhov wrote: On 10.09.15 9:36, prasanta sadhukhan wrote: Please review the modified webrev which solves this artifacts. http://cr.openjdk.java.net/~psadhukhan/8081491/webrev.05/ What will happen if the table will b

Re: [9] Review Request for 8133108: [PIT] Container size is wrong in JEditorPane

2015-09-10 Thread Alexander Scherbatiy
The getMinimumSpan(axis) method is redirected to getPreferredSpan(axis) in the fix for GlyphView in the BasicTextFieldUI. Does it mean that GlyphView itself does not properly display some types of text? Thanks, Alexandr. On 9/3/2015 4:08 PM, Semyon Sadetsky wrote: Hello, I have rew

Re: [9] Review Request for 8030702: Deadlock between subclass of AbstractDocument and UndoManager

2015-09-10 Thread Alexander Scherbatiy
On 9/8/2015 6:11 PM, Semyon Sadetsky wrote: On 9/8/2015 2:10 PM, Alexander Scherbatiy wrote: On 9/8/2015 2:06 PM, Semyon Sadetsky wrote: On 9/8/2015 1:07 PM, Alexander Scherbatiy wrote: On 9/8/2015 12:48 PM, Semyon Sadetsky wrote: On 9/8/2015 12:26 PM, Alexander Scherbatiy wrote: On 9/

Re: [9] Review Request for 8133108: [PIT] Container size is wrong in JEditorPane

2015-09-10 Thread Semyon Sadetsky
Correct. It causes i18n layout errors [https://bugs.openjdk.java.net/browse/JDK-8076164]. GlyphView calculates its minimum width using text wrapping, but it shouldn't do this for the TextField. In the View specs span calculation should be regulated by getSpanWeight()/getBreakWeight() methods, bu

Re: [9] Review Request for 8030702: Deadlock between subclass of AbstractDocument and UndoManager

2015-09-10 Thread Semyon Sadetsky
On 9/10/2015 2:44 PM, Alexander Scherbatiy wrote: On 9/8/2015 6:11 PM, Semyon Sadetsky wrote: On 9/8/2015 2:10 PM, Alexander Scherbatiy wrote: On 9/8/2015 2:06 PM, Semyon Sadetsky wrote: On 9/8/2015 1:07 PM, Alexander Scherbatiy wrote: On 9/8/2015 12:48 PM, Semyon Sadetsky wrote: On

Re: [9] Review Request for 8030702: Deadlock between subclass of AbstractDocument and UndoManager

2015-09-10 Thread Alexander Scherbatiy
On 9/10/2015 3:39 PM, Semyon Sadetsky wrote: On 9/10/2015 2:44 PM, Alexander Scherbatiy wrote: On 9/8/2015 6:11 PM, Semyon Sadetsky wrote: On 9/8/2015 2:10 PM, Alexander Scherbatiy wrote: On 9/8/2015 2:06 PM, Semyon Sadetsky wrote: On 9/8/2015 1:07 PM, Alexander Scherbatiy wrote: On 9/

Re:

2015-09-10 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 9/8/2015 11:57 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8134828 webrev: http://cr.openjdk.java.net/~ssadetsky/8134828/webrev.00/ This is a regression from the 8041642 which

Re: [9] Review Request for 8133864: Wrong display, when the document I18n properties is true.

2015-09-10 Thread Alexander Scherbatiy
On 9/9/2015 3:43 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8133864 webrev: http://cr.openjdk.java.net/~ssadetsky/8133864/webrev.00/ For the i18n mode the TextLayoutStrategy reorders child views in paragraph's row according to th

Re: [9] Review Request for 8133108: [PIT] Container size is wrong in JEditorPane

2015-09-10 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 9/10/2015 3:31 PM, Semyon Sadetsky wrote: Correct. It causes i18n layout errors [https://bugs.openjdk.java.net/browse/JDK-8076164]. GlyphView calculates its minimum width using text wrapping, but it shouldn't do this for the TextField. In t

Re: [9] Review Request for 8030702: Deadlock between subclass of AbstractDocument and UndoManager

2015-09-10 Thread Semyon Sadetsky
On 9/10/2015 3:45 PM, Alexander Scherbatiy wrote: On 9/10/2015 3:39 PM, Semyon Sadetsky wrote: On 9/10/2015 2:44 PM, Alexander Scherbatiy wrote: On 9/8/2015 6:11 PM, Semyon Sadetsky wrote: On 9/8/2015 2:10 PM, Alexander Scherbatiy wrote: On 9/8/2015 2:06 PM, Semyon Sadetsky wrote: On

Re: [9] Review Request for 8030702: Deadlock between subclass of AbstractDocument and UndoManager

2015-09-10 Thread Alexander Scherbatiy
On 9/10/2015 5:07 PM, Semyon Sadetsky wrote: On 9/10/2015 3:45 PM, Alexander Scherbatiy wrote: On 9/10/2015 3:39 PM, Semyon Sadetsky wrote: On 9/10/2015 2:44 PM, Alexander Scherbatiy wrote: On 9/8/2015 6:11 PM, Semyon Sadetsky wrote: On 9/8/2015 2:10 PM, Alexander Scherbatiy wrote: On

Re: [9] Review Request for 8030702: Deadlock between subclass of AbstractDocument and UndoManager

2015-09-10 Thread Semyon Sadetsky
On 9/10/2015 5:13 PM, Alexander Scherbatiy wrote: On 9/10/2015 5:07 PM, Semyon Sadetsky wrote: On 9/10/2015 3:45 PM, Alexander Scherbatiy wrote: On 9/10/2015 3:39 PM, Semyon Sadetsky wrote: On 9/10/2015 2:44 PM, Alexander Scherbatiy wrote: On 9/8/2015 6:11 PM, Semyon Sadetsky wrote:

Re: [9] Review Request for 8133864: Wrong display, when the document I18n properties is true.

2015-09-10 Thread Semyon Sadetsky
On 9/10/2015 4:14 PM, Alexander Scherbatiy wrote: On 9/9/2015 3:43 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8133864 webrev: http://cr.openjdk.java.net/~ssadetsky/8133864/webrev.00/ For the i18n mode the TextLayoutStrategy reo

Re: [9] Review Request for 8030702: Deadlock between subclass of AbstractDocument and UndoManager

2015-09-10 Thread Alexander Scherbatiy
On 9/10/2015 6:26 PM, Semyon Sadetsky wrote: On 9/10/2015 5:13 PM, Alexander Scherbatiy wrote: On 9/10/2015 5:07 PM, Semyon Sadetsky wrote: On 9/10/2015 3:45 PM, Alexander Scherbatiy wrote: On 9/10/2015 3:39 PM, Semyon Sadetsky wrote: On 9/10/2015 2:44 PM, Alexander Scherbatiy wrote: O

Re: [9] Review Request for 8030702: Deadlock between subclass of AbstractDocument and UndoManager

2015-09-10 Thread Semyon Sadetsky
On 9/10/2015 6:46 PM, Alexander Scherbatiy wrote: On 9/10/2015 6:26 PM, Semyon Sadetsky wrote: On 9/10/2015 5:13 PM, Alexander Scherbatiy wrote: On 9/10/2015 5:07 PM, Semyon Sadetsky wrote: On 9/10/2015 3:45 PM, Alexander Scherbatiy wrote: On 9/10/2015 3:39 PM, Semyon Sadetsky wrote: