On 10/25/2016 2:42 PM, Alexandr Scherbatiy wrote:
On 10/10/2016 12:55 PM, Semyon Sadetsky wrote:
Hello,
Please review fix for JDK9:
bug: https://bugs.openjdk.java.net/browse/JDK-8027639
webrev: http://cr.openjdk.java.net/~ssadetsky/8027639/webrev.00/
When the Swing repaint manager paints S
On 10/25/2016 7:58 PM, Sergey Bylokhov wrote:
On 25.10.16 14:42, Alexandr Scherbatiy wrote:
When the Swing repaint manager paints Swing to a separate off-screen
buffer the root window is not painted. So in case of non-opaque root
window having transparent background the repainted buffer area
tr
Hi Avik,
Did the test fail for you? I ran with the launcher auto-hidden in
ubuntu14.04 but it passed for me with the original testcode.
Regards
Prasanta
On 10/26/2016 12:39 PM, Avik Niyogi wrote:
Hi All,
Kindly review the proposed fix for JDK9.
*Bug: https://bugs.openjdk.java.net/browse/JDK
It did not fail on my system but it probably failed for slow systems in testing
environment.
Similar cases raised by Yuri had happened for several other cases which was
confirmed to be fixed by the delay by him.
With Regards,
Avik Niyogi
> On 27-Oct-2016, at 1:55 pm, Prasanta Sadhukhan
> wrote
Oh yes, this fix does help.
My system is not particularly slow but it is dual-screen,
Ubuntu 16.10 -- timing may differ.
Approved.
Thanks,
-yan
On 10/27/2016 11:34 AM, Avik Niyogi wrote:
It did not fail on my system but it probably failed for slow systems in
testing environment.
Similar cases
+1.
Regards
Prasanta
On 10/27/2016 2:24 PM, Yuri Nesterenko wrote:
Oh yes, this fix does help.
My system is not particularly slow but it is dual-screen,
Ubuntu 16.10 -- timing may differ.
Approved.
Thanks,
-yan
On 10/27/2016 11:34 AM, Avik Niyogi wrote:
It did not fail on my system but it pr
Build change looks good.
/Erik
On 2016-10-27 04:24, Pete Brunet wrote:
Please review the latest update at
http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.03/
The change is to AccessBridgeCalls.c. The license has been changed from
GPL2 to BSD. This is because the file was originally
On 27.10.16 11:54, Yuri Nesterenko wrote:
Oh yes, this fix does help.
My system is not particularly slow but it is dual-screen,
Ubuntu 16.10 -- timing may differ.
A few lines below the changed lines there is a delay for 1 seconds, does
it meant that it is not enough on your system?
111
On 27.10.16 10:51, Semyon Sadetsky wrote:
Did you check that if the rootpane background contain non-zero alpha
it does not draws twice? The first one when the the root will be draw
itself and the second time in the new code when the component will be
drawn? probably backbuffer should be initializ
On 27.10.16 8:56, Semyon Sadetsky wrote:
Thank you, Alexander. Please review the updated webrev:
http://cr.openjdk.java.net/~ssadetsky/8074883/webrev.01/
probably it is possible to change the while loop to something? just to
hide the usage of Enumeration? like
Enumiration.asIterator().forEach
The .h files are unlicensed in the bundle/install so no need?
On 10/26/16 11:52 PM, Mandy Chung wrote:
> Should the same change be applied to the .h files as well?
>
> Mandy
>
>> On Oct 26, 2016, at 7:24 PM, Pete Brunet wrote:
>>
>> Please review the latest update at
>> http://cr.openjdk.java.net
On 27.10.16 9:45, Prasanta Sadhukhan wrote:
What I meant to say is hidpi splashscreen support is not there in
solaris (already told earlier too)
http://mail.openjdk.java.net/pipermail/awt-dev/2016-March/010813.html
I think that it should be supported in some way already, because there
is no s
But it still needs to say "jdk9/jdk9" not jdk9/client or jdk9/dev.
-phil.
On 10/26/16, 9:27 PM, Anirvan Sarkar wrote:
Hi,
If you replace the hex number with 'tip' then it will always point to
the latest version.
Something like
http://hg.openjdk.java.net/jdk9/client/jdk/file/tip/src/jdk.acc
On 10/26/2016 10:28 AM, Prasanta Sadhukhan wrote:
Hi All,
Please review a fix for the issue where this obsolete class needs to
be deprecated:
Bug: https://bugs.openjdk.java.net/browse/JDK-8048702
diff -r aae3690e53e3
src/java.desktop/share/classes/javax/swing/plaf/metal/MetalFileChooserUI.j
Thanks for noticing that Phil. Updated at
http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.05/
On 10/27/16 9:20 AM, Philip Race wrote:
> But it still needs to say "jdk9/jdk9" not jdk9/client or jdk9/dev.
>
> -phil.
>
> On 10/26/16, 9:27 PM, Anirvan Sarkar wrote:
>> Hi,
>>
>> If you replac
On 10/27/2016 2:57 PM, Sergey Bylokhov wrote:
On 27.10.16 10:51, Semyon Sadetsky wrote:
Did you check that if the rootpane background contain non-zero alpha
it does not draws twice? The first one when the the root will be draw
itself and the second time in the new code when the component will
On 27.10.16 19:21, Semyon Sadetsky wrote:
Probably you've confused that root is not an instance of the JRootPane.
It is a HW container that is parent of the root pane.
But there is an another color discrepancy here. Since the HW container
is not opaque the background color should not be painted.
This all seems fine.
Do other accessbridge files still have the remnants of SCCS ? :-
That was purged from all the other JDK files when we moved to mercurial.
33 /*
34 * @(#)AccessBridgeCalls.c 1.25 05/08/22
35 */
If "yes", then I suggest to file a clean-up bug to clean up all of
Should they be kept just in the source and not to be included in the
image/include directory?
It’s not clear to me if anyone needs these header files from the JDK image as
AccessBridgeCalls.c is obtained from the source.
Mandy
> On Oct 27, 2016, at 6:48 AM, Pete Brunet wrote:
>
> The .h file
No, we are definitely shipping those.
Unless of course you think we should stop shipping JNI headers too ...
-phil
On 10/27/2016 10:37 AM, Mandy Chung wrote:
Should they be kept just in the source and not to be included in the
image/include directory?
It’s not clear to me if anyone needs thes
> On Oct 27, 2016, at 10:44 AM, Phil Race wrote:
>
> No, we are definitely shipping those.
> Unless of course you think we should stop shipping JNI headers too …
>
No. I tried to understand what is external interface. I took it that these
header files are external interfaces.
I reviewed:
In which case be careful it is not built by the JDK build ..
unless that is actually required .. which I didn't think it was.
-phil.
On 10/27/2016 11:30 AM, Mandy Chung wrote:
Please move AccessBridgeCalls.c to src/jdk.accessibility/windows/native/bridge
directory.
On 10/27/2016 7:38 PM, Sergey Bylokhov wrote:
On 27.10.16 19:21, Semyon Sadetsky wrote:
Probably you've confused that root is not an instance of the
JRootPane.
It is a HW container that is parent of the root pane.
But there is an another color discrepancy here. Since the HW container
is not o
On 10/27/16 1:34 PM, Phil Race wrote:
> In which case be careful it is not built by the JDK build ..
> unless that is actually required .. which I didn't think it was.
It isn't.
>
> -phil.
>
> On 10/27/2016 11:30 AM, Mandy Chung wrote:
>> Please move AccessBridgeCalls.c to
>> src/jdk.accessibili
On 10/27/16 1:34 PM, Phil Race wrote:
> In which case be careful it is not built by the JDK build ..
Build team, Is there anything I need to handle here to make sure it isn't?
> unless that is actually required .. which I didn't think it was.
>
> -phil.
>
> On 10/27/2016 11:30 AM, Mandy Chung wro
On 10/27/16 1:47 PM, Pete Brunet wrote:
>
> On 10/27/16 1:34 PM, Phil Race wrote:
>> In which case be careful it is not built by the JDK build ..
> Build team, Is there anything I need to handle here to make sure it isn't?
Actually, let me give it a try. I should be able to resolve any
issues.
On 10/27/2016 11:52 AM, Pete Brunet wrote:
On 10/27/16 1:47 PM, Pete Brunet wrote:
On 10/27/16 1:34 PM, Phil Race wrote:
In which case be careful it is not built by the JDK build ..
Build team, Is there anything I need to handle here to make sure it isn't?
Actually, let me give it a try. I
Hi Avik,
My suggestion about adding a word "the" was not taken and a couple of other changes were made to the @return statements
which are not optimal. Let's reset and use the following @return statements for each of the methods (to mirror the way
these are described in the Image base class):
On 10/27/16 1:30 PM, Mandy Chung wrote:
>> On Oct 27, 2016, at 10:44 AM, Phil Race wrote:
>>
>> No, we are definitely shipping those.
>> Unless of course you think we should stop shipping JNI headers too …
>>
> No. I tried to understand what is external interface. I took it that these
> header
On 10/27/16 6:31 PM, Pete Brunet wrote:
> On 10/27/16 1:30 PM, Mandy Chung wrote:
>>> On Oct 27, 2016, at 10:44 AM, Phil Race wrote:
>>>
>>> No, we are definitely shipping those.
>>> Unless of course you think we should stop shipping JNI headers too …
>>>
>> No. I tried to understand what is ex
> On Oct 27, 2016, at 4:31 PM, Pete Brunet wrote:
>
> I moved the source to
> src/jdk.accessibility/windows/native/bridge/src
“src” subdirectory is redundant that should be dropped.
> and the includes to
> src/jdk.accessibility/windows/native/bridge/include
Please see the source layout defin
Please find the webrev with the proposed changes.
http://cr.openjdk.java.net/~psadhukhan/8048702/
Regards
Prasanta
On 10/27/2016 8:03 PM, Alexandr Scherbatiy wrote:
On 10/26/2016 10:28 AM, Prasanta Sadhukhan wrote:
Hi All,
Please review a fix for the issue where this obsolete class needs to
32 matches
Mail list logo
