Re: [12]RFR JDK-8212882: links to tutorial should be updated to use https:

looks good to me but src/java.sql.rowset and src/java.sql/ changes should be sent to some other list or prepare the webrev without those changes, as I guess we do not have committer rights for those modules. Regards Prasanta On 24-Oct-18 11:51 AM, Krishna Addepalli wrote: Hi All, Please revi

Re: [12] RFR JDK-8211703: JInternalFrame : java.lang.AssertionError: cannot find the internal frame

Hi Prasanta, I tested with provided binary and issue is resolved with this fix. Thanks for fixing this issue. Regards, Muneer -Original Message- From: Muneer Kolarkunnu Sent: Wednesday, October 24, 2018 12:00 PM To: Prasanta Sadhukhan ; Sergey Bylokhov ; [email protected] Sub

Re: [12]RFR JDK-8212882: links to tutorial should be updated to use https:

Thanks for the review Prasantha, but the list included in the bug includes those locations as well, so I just created an integrated webrev. Can we confirm that we donot have commit rights for those modules? Krishna From: Prasanta Sadhukhan Sent: Wednesday, October 24, 2018 2:44 PM To: K

Re: [12] JDK-7124285: Nothing heard from VoiceOver regarding the status of the progress bar

Hi Shashi, I see, setting setFocusable dynamically is not an option then. At the very least it will be confusing for the user: in some cases progress bar is skipped when traversing focus and in other cases, it's not. Progress bar embedded in a toolbar button is another case. Is progress bar

Re: [12] JDK-7124285: Nothing heard from VoiceOver regarding the status of the progress bar

Hi, Shashi. Can you please provide more information about relation of focusable state and a VoiceOver? The simple JLabel is not focusable, but VoiceOver reads its contents, and it is possible to select the label using VoiceOver's shortcuts. On 22/10/2018 00:36, shashidhara.veerabhadra...@oracle

Re: [TEST] [12] RFR [JDK-8211443] Enable different look and feels in SwingSet3 demo test SplitPaneDemoTest

Looks fine. On 23/10/2018 03:07, Gauri Patil wrote: Hi All, Please review fix for the below task: Bug: https://bugs.openjdk.java.net/browse/JDK-8211443 Webrev: http://cr.openjdk.java.net/~akolarkunnu/8211443/webrev.00/ Description: Enabled different look and feels in SwingSet3 demo test Spl

Re: [12] RFR JDK-8212735:Compilation issue with javax.swing.InputVerifier example in javadoc section

Looks fine. On 23/10/2018 07:45, Prasanta Sadhukhan wrote: Hi All, In https://download.java.net/java/early_access/jdk12/docs/api/java.desktop/javax/swing/InputVerifier.htmljavadoc, the example given does not compile as the "field" variable is not declared. Following fix ensures proper variabl

Re: [12] RFR [JDK-8212897] Some improvements in the EditorPaneDemotest

Looks fine. On 23/10/2018 23:14, Muneer Kolarkunnu wrote: Hi All, Please review fix for the task: Task: https://bugs.openjdk.java.net/browse/JDK-8212897 Webrev: http://cr.openjdk.java.net/~akolarkunnu/8212897/webrev.00/ Description: 1) In Nimbus L&F, background color is not white, but in th

Re: [12]RFR JDK-8212882: links to tutorial should be updated to use https:

Hi, Krishna I think you need to include more groups to this review: hotspot-dev, core-libs-dev and security-dev. On 23/10/2018 23:21, Krishna Addepalli wrote: Hi All, Please review a trivial fix of updating the links to https. Bug: https://bugs.openjdk.java.net/browse/JDK-8212882 Webrev: htt

Re: [12]RFR JDK-8212882: links to tutorial should be updated to use https:

Actually you should remove all those from this review and let jjg file bugs on those areas. It is possible they were included by accident but I don't see where you got the hotspot ones from and they are purely code comments NOT anything official. Let's just fix our own code and not presume to f

Re: [12] JDK-7124285: Nothing heard from VoiceOver regarding the status of the progress bar

Hi Sergey, While fixing this bug I did not verified the behavior of other components and how they behave with respect to the AT. Since the question about other components came up and did some debugging on that part. Below is the reason that I could find: It is all about the focus traversal poli

Re: [12]RFR JDK-8212882: links to tutorial should be updated to use https:

Hi All, I have removed all non-client files and created a new webrev: http://cr.openjdk.java.net/~kaddepalli/8212882/webrev01/ Thanks, Krishna > On 25-Oct-2018, at 10:24 AM, Philip Race wrote: > > Actually you should remove all those