RFR: 8160720: [TEST_BUG] javax/swing/SwingUtilities/TestBadBreak/TestBadBreak.java

2021-02-10 Thread Prasanta Sadhukhan
Test hardcodes bufferedimage and frame bounds so it does not capture correct size if scaling factor is used. The solution is to always use the same uiscale=1, an updated test still can reproduce the JDK-8015085 issue without fix. Additionally, moved the frame to centre of screen for better mach5

Re: RFR: 8260719: Input method character moves with caret

2021-02-10 Thread Denis Konoplev
On Thu, 4 Feb 2021 16:01:29 GMT, Ichiroh Takiguchi wrote: >> Well, I guess I have to solve ubuntu issue and "commiting preedit on mouse >> click". >> Should I close this PR? > > @dekonoplyov , > I think ubuntu Korean IM issue is related XIM spec. It may be limitation... > I have no idea about p

Withdrawn: 8260719: Input method character moves with caret

2021-02-10 Thread Denis Konoplev
On Mon, 1 Feb 2021 18:16:12 GMT, Denis Konoplev wrote: > I've fixed annoying behaviour of input methods in text components. > Code checks caret position before submitting composed text. This pull request has been closed without being integrated. - PR: https://git.openjdk.java.net/

Re: RFR: 8160720: [TEST_BUG] javax/swing/SwingUtilities/TestBadBreak/TestBadBreak.java

2021-02-10 Thread Sergey Bylokhov
On Wed, 10 Feb 2021 10:33:03 GMT, Prasanta Sadhukhan wrote: > Test hardcodes bufferedimage and frame bounds so it does not capture correct > size if scaling factor is used. > The solution is to always use the same uiscale=1, an updated test still can > reproduce the JDK-8015085 issue without f

Re: RFR: 8160720: [TEST_BUG] javax/swing/SwingUtilities/TestBadBreak/TestBadBreak.java

2021-02-10 Thread Prasanta Sadhukhan
On Wed, 10 Feb 2021 11:18:38 GMT, Sergey Bylokhov wrote: >> Test hardcodes bufferedimage and frame bounds so it does not capture correct >> size if scaling factor is used. >> The solution is to always use the same uiscale=1, an updated test still can >> reproduce the JDK-8015085 issue without f

Re: RFR: JDK-8259818: [TEST_BUG] Convert applet-based test test/jdk/javax/swing/JCheckBox/8032667/bug8032667.java to a regular java

2021-02-10 Thread Phil Race
On Fri, 15 Jan 2021 07:59:24 GMT, K Suman Rajkumaar wrote: > Dear All, > > Hi All, Could you please review this fix for JDK17? > > Problem Description: The test > open/test/jdk/javax/swing/JCheckBox/8032667/bug8032667.java is applet based. > > Fix: Rewritten the above applet based test as a

RFR: 8260687: Inherited font size is smaller than expected when using StyleSheet to add styles

2021-02-10 Thread Stanimir Stamenkov
Proposed fix for [JDK-8260687][]. It is noted the issue appeared after the [JDK-8257664][] (PR #1759) fix landed but the underlying problem is present even before that as demonstrated by using the following HTML document variant: 16pt inherited from body 16pt paragraph with the program

Re: RFR: 8049700: Deprecate obsolete classes and methods in javax/swing/plaf/basic [v6]

2021-02-10 Thread Phil Race
On Tue, 9 Feb 2021 07:27:00 GMT, Tejpal Rebari wrote: >> Please review the following fix for jdk17. >> In this fix i have deprecated and marked for removal following classes and >> methods >>public void intervalAdded(ListDataEvent e) >>public void intervalRemoved(ListDataEvent e) >>

Re: RFR: 8160720: [TEST_BUG] javax/swing/SwingUtilities/TestBadBreak/TestBadBreak.java

2021-02-10 Thread Sergey Bylokhov
On Wed, 10 Feb 2021 11:45:35 GMT, Prasanta Sadhukhan wrote: >> test/jdk/javax/swing/SwingUtilities/TestBadBreak/TestBadBreak.java line 43: >> >>> 41: * @summary Shortening via " ... " is broken for Strings containing a >>> combining >>> 42: * diaeresis. >>> 43: * @run main/othervm

Re: RFR: 8160720: [TEST_BUG] javax/swing/SwingUtilities/TestBadBreak/TestBadBreak.java

2021-02-10 Thread Sergey Bylokhov
On Wed, 10 Feb 2021 11:43:11 GMT, Prasanta Sadhukhan wrote: >> test/jdk/javax/swing/SwingUtilities/TestBadBreak/TestBadBreak.java line 94: >> >>> 92: SwingUtilities.invokeAndWait(() -> frame.setVisible(true)); >>> 93: robot.waitForIdle(); >>> 94: robot.delay(1000); >> >

Re: RFR: 8160720: [TEST_BUG] javax/swing/SwingUtilities/TestBadBreak/TestBadBreak.java

2021-02-10 Thread Sergey Bylokhov
On Wed, 10 Feb 2021 21:34:21 GMT, Sergey Bylokhov wrote: >> This is between visible and destroy..The other one before start of the 2nd >> test which will crate 2nd frame.. > > And why do you need both? The test does not use the robot, so the test can > show all windows at once. BTW since the r

Re: RFR: 8160720: [TEST_BUG] javax/swing/SwingUtilities/TestBadBreak/TestBadBreak.java

2021-02-10 Thread Sergey Bylokhov
On Wed, 10 Feb 2021 21:31:21 GMT, Sergey Bylokhov wrote: >> It uses hardcoded 200,90 for frame.setBounds.I guess it should be multiplied >> by scale factor for correct bounds to be used. > > Both coordinates robot/frame use the user's space and internally should be > transformed to the device s

Re: RFR: 8160720: [TEST_BUG] javax/swing/SwingUtilities/TestBadBreak/TestBadBreak.java

2021-02-10 Thread Alexey Ivanov
On Wed, 10 Feb 2021 21:37:35 GMT, Sergey Bylokhov wrote: >> And why do you need both? The test does not use the robot, so the test can >> show all windows at once. > > BTW since the robot is not used it is unclear how the > setUndecorated:true/false and setLocationRelativeTo() may affect the te

Re: RFR: 8260687: Inherited font size is smaller than expected when using StyleSheet to add styles

2021-02-10 Thread Alexey Ivanov
On Wed, 10 Feb 2021 17:55:56 GMT, Stanimir Stamenkov wrote: > Proposed fix for [JDK-8260687][]. > > It is noted the issue appeared after the [JDK-8257664][] (PR #1759) fix > landed but the underlying problem is present even before that as demonstrated > by using the following HTML document va

Re: RFR: 8160720: [TEST_BUG] javax/swing/SwingUtilities/TestBadBreak/TestBadBreak.java

2021-02-10 Thread Prasanta Sadhukhan
On Wed, 10 Feb 2021 21:49:40 GMT, Sergey Bylokhov wrote: >> Both coordinates robot/frame use the user's space and internally should be >> transformed to the device space. But that transformation should be the same, >> there are should not be differences in the final result for both. > > BTW the

Withdrawn: JDK-8259818: [TEST_BUG] Convert applet-based test test/jdk/javax/swing/JCheckBox/8032667/bug8032667.java to a regular java

2021-02-10 Thread K Suman Rajkumaar
On Fri, 15 Jan 2021 07:59:24 GMT, K Suman Rajkumaar wrote: > Dear All, > > Hi All, Could you please review this fix for JDK17? > > Problem Description: The test > open/test/jdk/javax/swing/JCheckBox/8032667/bug8032667.java is applet based. > > Fix: Rewritten the above applet based test as a

Re: RFR: JDK-8259818: [TEST_BUG] Convert applet-based test test/jdk/javax/swing/JCheckBox/8032667/bug8032667.java to a regular java

2021-02-10 Thread K Suman Rajkumaar
On Wed, 10 Feb 2021 17:58:45 GMT, Phil Race wrote: >> Dear All, >> >> Hi All, Could you please review this fix for JDK17? >> >> Problem Description: The test >> open/test/jdk/javax/swing/JCheckBox/8032667/bug8032667.java is applet based. >> >> Fix: Rewritten the above applet based test as a r